October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, engine: Fix VM CD change in JSON RPC
by ofrenkel＠redhat.com 02 Oct '14

02 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, engine: Fix VM CD change in JSON RPC ...................................................................... core, engine: Fix VM CD change in JSON RPC This change fixes a NPE while changing the CD of a running VM. Change-Id: I976354fca483d1cdb45ba7abc006924eb7041af7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I976354fca483d1cdb45ba7abc006924eb7041af7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: ovirt-hosted-engine-setup-1.2.1
by sbonazzo＠redhat.com 02 Oct '14

02 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.2.1 ...................................................................... build: ovirt-hosted-engine-setup-1.2.1 Change-Id: I6f665da96e630acb10541894f30d098b40773d4c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f665da96e630acb10541894f30d098b40773d4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Move cpu_over_commit from VdsDynamic to VdsStatistics
by oourfali＠redhat.com 02 Oct '14

02 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Move cpu_over_commit from VdsDynamic to VdsStatistics ...................................................................... core: Move cpu_over_commit from VdsDynamic to VdsStatistics cpu_over_commit field is rapidly changing, and should be located in VdsStatistics. This patch moves it to vds_statistics and updates the relevant stored procedures and DAOs Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114285 Change-Id: I4cf1d83f67385e4259f8f554ff3b81c68b751122 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0410_move_cpu_over_commit_to_vds_stats.sql M packaging/dbscripts/vds_sp.sql 10 files changed, 47 insertions(+), 44 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cf1d83f67385e4259f8f554ff3b81c68b751122 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, engine: Fix VM CD change in JSON RPC
by oourfali＠redhat.com 02 Oct '14

02 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core, engine: Fix VM CD change in JSON RPC ...................................................................... core, engine: Fix VM CD change in JSON RPC This change fixes a NPE while changing the CD of a running VM. Change-Id: I976354fca483d1cdb45ba7abc006924eb7041af7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I976354fca483d1cdb45ba7abc006924eb7041af7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Check validity of new storage connection mount options...
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Check validity of new storage connection mount options ignoring case ...................................................................... core: Check validity of new storage connection mount options ignoring case When adding a new NFS/Posix storage server connection, the custom mount options should be validated case insensitively Change-Id: Ie5334bdef5955a9b48e266d8dae7ecb339ccc376 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1141500 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommandTest.java 2 files changed, 11 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5334bdef5955a9b48e266d8dae7ecb339ccc376 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set job message properties correct in ForceSelectSPMCo...
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Set job message properties correct in ForceSelectSPMCommand ...................................................................... core: Set job message properties correct in ForceSelectSPMCommand Change-Id: Ib5c3bafdfaea54c354729a3c2c477d0bb61ecb74 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1144841 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ForceSelectSPMCommand.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5c3bafdfaea54c354729a3c2c477d0bb61ecb74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: vdsbroker: no spm failover on attach iso domain failure
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: vdsbroker: no spm failover on attach iso domain failure ...................................................................... vdsbroker: no spm failover on attach iso domain failure Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140430 Change-Id: I93500e5493b7e963c3b218520e5f6e7b96e3fe5f Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> (cherry picked from commit e3d5250e083da6246535e1fa4c7a2d0196ca1a7b) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93500e5493b7e963c3b218520e5f6e7b96e3fe5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Dialog box header drag
by tnisan＠redhat.com 01 Oct '14

01 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: Dialog box header drag ...................................................................... userportal, webadmin: Dialog box header drag - The drag box on dialogs was only 20 px high, while the header was 36 px high. This caused it to not be clear where you could and could drag the window. This patch makes the entire header dragable. - Replaced tabs with spaces in DialogBox.css. Change-Id: I712203d343102c1a61f5256eb0eefbe7162a1d78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139634 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/DialogBox.css 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I712203d343102c1a61f5256eb0eefbe7162a1d78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.0]: core: connection timeout overriden by client timeout
by oourfali＠redhat.com 01 Oct '14

01 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: connection timeout overriden by client timeout ...................................................................... core: connection timeout overriden by client timeout Connection timeout setting was overriden by client timeout. Bug-Url: https://bugzilla.redhat.com/1147487 Change-Id: I6b8b3154071b98f802f001481abf80be5865fe74 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b8b3154071b98f802f001481abf80be5865fe74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.0 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: connection timeout overriden by client timeout
by oourfali＠redhat.com 01 Oct '14

01 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: connection timeout overriden by client timeout ...................................................................... core: connection timeout overriden by client timeout Connection timeout setting was overriden by client timeout. Bug-Url: https://bugzilla.redhat.com/1147487 Change-Id: I6b8b3154071b98f802f001481abf80be5865fe74 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b8b3154071b98f802f001481abf80be5865fe74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0