November 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: Remove suffix from mgmt address taken from the ComputerResou...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: Remove suffix from mgmt address taken from the ComputerResource conf ...................................................................... Remove suffix from mgmt address taken from the ComputerResource conf This parameter is used by ovirt-node and should include only fqdn or ip4 addr with port number or without. For example 10.35.1.85:8080 Change-Id: I5a40ca0b4870d1955b01d18c88df467b8da35fc4 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a40ca0b4870d1955b01d18c88df467b8da35fc4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: ui: fixing addHost form issues when playing with using host ...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: ui: fixing addHost form issues when playing with using host provider ...................................................................... ui: fixing addHost form issues when playing with using host provider Apparently hiding the host provider form was buggy. In this patch we fix the fields cleaning and the visibility of the provider parameters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165670 Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 3 files changed, 12 insertions(+), 18 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: core: Allow automation of first interactions

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Allow automation of first interactions ...................................................................... core: Allow automation of first interactions Move questions to stage setup, add to answer file. Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 Bug-Url: https://bugzilla.redhat.com/1101285 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/misc.py M src/plugins/ovirt-hosted-engine-setup/core/shell.py 3 files changed, 38 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: revert : core: Add foreign keys from async_tasks to command_...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: revert : core: Add foreign keys from async_tasks to command_entities ...................................................................... revert : core: Add foreign keys from async_tasks to command_entities Bare in mind, this is not a pure git revert as DB scripts cannot be reverted (a script that performs "logical revert" should be added) Change-Id: Icf54510178460095b09f529b2c5d26eee9efdeec Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_05_1180_revert_add_foreign_keys_tk_async_tasks_table.sql 4 files changed, 8 insertions(+), 16 deletions(-) Approvals: Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/35380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf54510178460095b09f529b2c5d26eee9efdeec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Calculate disk alias on add disk prior to setting the ...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate disk alias on add disk prior to setting the job message ...................................................................... core: Calculate disk alias on add disk prior to setting the job message The disk alias to be created is calculated during the execution phase so if the user hasn't specified one, during the job creation the alias will not appear in the task description, the setting of the alias (whether it's default or the one the user supplied) is now done in the job message calculation phase Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1143967 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Align Add-Disk operation audit log messages

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Align Add-Disk operation audit log messages ...................................................................... core: Align Add-Disk operation audit log messages Some audit log messages read Add-Disk operation, and some read Operation Add-Disk. Aligned all to the first form. Change-Id: I4a26712bd14fcf6cebdc7bba6216758fb7cb5da7 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a26712bd14fcf6cebdc7bba6216758fb7cb5da7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: AuditLogMessage for internal disk addition

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: AuditLogMessage for internal disk addition ...................................................................... core: AuditLogMessage for internal disk addition When adding a disk as part of an internal command - when no user is involved, the <UNKNOWN> user was specified as user. This is now corrected and new audit log messages were added with no user specification in the message. Change-Id: Ia66bb5fb393802cbfe6847240d6adfbbd1a53e4e Bug-Url: https://bugzilla.redhat.com/1149620 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 10 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia66bb5fb393802cbfe6847240d6adfbbd1a53e4e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Add columns and stored procedures for HostNetworkQos

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: core: Add columns and stored procedures for HostNetworkQos ...................................................................... core: Add columns and stored procedures for HostNetworkQos Updated the qos table to hold the values relevant for host network QoS, and added CRUD operations for these entities. Change-Id: I8aedaef3484e5ceb5b17ab35cff6cfd65e225bd1 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M packaging/dbscripts/network_sp.sql M packaging/dbscripts/qos_sp.sql A packaging/dbscripts/upgrade/03_06_0560_add_host_network_qos_columns.sql 3 files changed, 52 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aedaef3484e5ceb5b17ab35cff6cfd65e225bd1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Add host network QoS entity

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: core: Add host network QoS entity ...................................................................... core: Add host network QoS entity Created the new entity to represent a host network QoS (different parameters from VM network QoS). Change-Id: I9471e68ba36fcc2f1465059037125a4c19a4c07f Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java 3 files changed, 97 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/34119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9471e68ba36fcc2f1465059037125a4c19a4c07f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: aaa: exceptions should be propagated in builtin ldap provider

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: exceptions should be propagated in builtin ldap provider ...................................................................... aaa: exceptions should be propagated in builtin ldap provider All exceptions which are caught during the privileged action execution should be propagated and not swollowed. In addition, NegativeArraySizeException is handled as a severe exception, meaning there will be no attempt to try the next server if is caught Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165721 Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/AuthenticationResult.java 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2014