Change in ovirt-engine[master]: restapi: Expose vm.auto_converge and vm.migrate_compressed p...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed properties
......................................................................
restapi: Expose vm.auto_converge and vm.migrate_compressed properties
<vm>
<migration>
<auto_converge>true|false|inherit</auto_converge>
<compressed>true|false|inherit</compressed>
</migration>
</vm>
And similarly for <cluster>
Change-Id: I9161896d1709c7492201667aa2c5955c5e37efd0
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151001
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HasMigrationOptions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/InheritableBoolean.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ClusterValidator.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MigrationOptionsValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java
M backend/manager/modules/restapi/types/exclude-filters.xml
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InheritableBooleanMapper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MigrationOptionsMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
18 files changed, 215 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/32133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9161896d1709c7492201667aa2c5955c5e37efd0
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: frontend: Add support for auto-convergence and XBZRLE compre...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Add support for auto-convergence and XBZRLE compression
......................................................................
frontend: Add support for auto-convergence and XBZRLE compression
Added ListBox widgets for auto-convergence and migration compression in VM and
Cluster dialogs.
ListBoxes are used because values for auto-convergence and migration
compression can be true/false/null where null signifies inheritance from
higher-level configuration.
Change-Id: Iff0c082dfddf22704a0ff26593b52f1385f342ea
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151001
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/BooleanRendererWithNullText.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreUnitToVmBaseBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
15 files changed, 192 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/32495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff0c082dfddf22704a0ff26593b52f1385f342ea
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: engine: handle memory allignment when checking the balloon h...
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: handle memory allignment when checking the balloon health
......................................................................
engine: handle memory allignment when checking the balloon health
Engine used to check if the ballooning works properly
by comparing the target memory with the actual available
memory and throws a warning if it doesn't match,
the problem is when the requsted target memory value is
not alligned. The system then returns the alligned memory
and the engine thinks the balloon is not working, becuase
the requested value != curent value. This patch changes
the behaviour so it only checks if the current value is closer
to the requested value than the previous value (in other words:
if the current memory moves towards the requested target)
Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9
Bug-Url: https://bugzilla.redhat.com/1120197
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBalloonInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java
3 files changed, 51 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: VM dialog: combobox content trim in IE9 fix
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: VM dialog: combobox content trim in IE9 fix
......................................................................
webadmin: VM dialog: combobox content trim in IE9 fix
IE9 wrongly calculates the width of element - it doesn't take scrollbar
into accout. This causes the content to be shifted to the left and
trimmed.
Resetting 'overflow-y' css property to 'hidden' and back again prevents
the left shift. Extending the element adds space for scrollbar.
Change-Id: I203939fbf96b664280a50b98ca4a2baccec8325d
Bug-Url: https://bugzilla.redhat.com/1160774
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
1 file changed, 50 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
--
To view, visit http://gerrit.ovirt.org/35293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I203939fbf96b664280a50b98ca4a2baccec8325d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: aaa: Adding auth and principal records on session
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: Adding auth and principal records on session
......................................................................
aaa: Adding auth and principal records on session
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163147
Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
2 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: bll: remove usage of RandomUtils
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: bll: remove usage of RandomUtils
......................................................................
bll: remove usage of RandomUtils
RandomUtils is a wrapper to non secure random of java that is not used
nor required within runtime.
implementation of random utils is way too complex than required and
provided as a wrapper instead of utility.
move class to tests.
Change-Id: Id20da6d8eb93ebbd237d20705440c5e583fc486e
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Tal Nisan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id20da6d8eb93ebbd237d20705440c5e583fc486e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: restapi: Null check on domain volume group when attempting t...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Null check on domain volume group when attempting to extend domain
......................................................................
restapi: Null check on domain volume group when attempting to extend domain
When editing a block domain via REST, the LUN passed in the new entity can
come either from the LUNs collection and in case it's empty from the volume
group property and it's LUNs, added a null check on the volume group since
when you do not provide LUNs it automatically falls back to volume group
which might be null
Change-Id: Ic762bdfb4c01d7b9344c94878d6662b9866a4090
Bug-Url: https://bugzilla.redhat.com/1115966
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>restapi:
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic762bdfb4c01d7b9344c94878d6662b9866a4090
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: Revert "core: Store iSCSI Target Address instead of IP Addre...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Revert "core: Store iSCSI Target Address instead of IP Address in DB"
......................................................................
Revert "core: Store iSCSI Target Address instead of IP Address in DB"
This reverts commit c6c9bdb239042ca0ab4543d154d5144740ba4379.
The idea of working with the original address we get from the user
instead of the IP address we get from VDSM works fine in case that the
iscsi server has only one NIC. When it has more than one (Multipath, for
example) the VDSM sends all the addresses it discovered, and we override
all of them with the original address we got from the user. This makes
the login to all of the other targets fail (except for the first one).
Thus, working with the original address is not possible.
Change-Id: I3974820e9039f05aa716752330c1b2ec13591137
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1163948
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
Objections:
Nir Soffer: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/35295
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3974820e9039f05aa716752330c1b2ec13591137
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: engine: don't read external files in unit test
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: engine: don't read external files in unit test
......................................................................
engine: don't read external files in unit test
- Removed trying to read external files that should be there but
in certain situations are not there. Modified it to just read files
inside the source tree.
Change-Id: I47db3324daf11a19cb76c3866a3f4e4152b9a3a1
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java
A backend/manager/modules/utils/src/test/resources/mime.types
4 files changed, 24 insertions(+), 10 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Alexander Wels: Verified
Einav Cohen: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47db3324daf11a19cb76c3866a3f4e4152b9a3a1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: core: Cluster parameters override - scheduler \ actions \ qu...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Cluster parameters override - scheduler \ actions \ queries
......................................................................
core: Cluster parameters override - scheduler \ actions \ queries
This feature allows to configure the 'emulated machine' and 'cpu model'
parameters for each VM separately instead of relying on the cluster default.
Bug-Url: https://bugzilla.redhat.com/838487
Feature-page: http://www.ovirt.org/Features/Cluster_parameters_override
Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSupportedCpuListQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetSupportedCpuListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
A packaging/dbscripts/upgrade/03_06_0550_add_cluster_parameters_override_policy_unit.sql
14 files changed, 289 insertions(+), 47 deletions(-)
Approvals:
Eldan Shachar: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month