November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GetAllDisksByVmIdQuery - improved performance
by laravot＠redhat.com 04 Nov '14

04 Nov '14

Liron Aravot has submitted this change and it was merged. Change subject: core: GetAllDisksByVmIdQuery - improved performance ...................................................................... core: GetAllDisksByVmIdQuery - improved performance Currently when executing GetAllDisksByVmIdQuery, all the vm disks are queried using the GetDisksVmGuid stored procedure and then the vm device for each disk is being loaded to complete to queried data. This can cause to mass of loads that could be prevented, GetDisksVmGuid already performs join with vm_device table so that records could be just returned. Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Bug-Url: https://bugzilla.redhat.com/1130065 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M packaging/dbscripts/all_disks_sp.sql M packaging/dbscripts/create_views.sql 5 files changed, 40 insertions(+), 47 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000524 Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: make constants class ctor private
by laravot＠redhat.com 04 Nov '14

04 Nov '14

Liron Aravot has submitted this change and it was merged. Change subject: core: make constants class ctor private ...................................................................... core: make constants class ctor private Change-Id: Ifef9264b2bfb39150cbcdde2efe376bfde3861b5 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfInfoFileConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifef9264b2bfb39150cbcdde2efe376bfde3861b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "restapi: Fix NPE in request for CDROMs of wrong VM"
by juan.hernandez＠redhat.com 04 Nov '14

04 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: Revert "restapi: Fix NPE in request for CDROMs of wrong VM" ...................................................................... Revert "restapi: Fix NPE in request for CDROMs of wrong VM" This reverts part of commit 8d5aa3646e2402a48f88a0532a70d9bb50347e57, as it breaks listing of empty collections of VM devices. Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Bug-Url: https://bugzilla.redhat.com/1159642 Related-To: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: skip failing proxy when waiting for status
by oourfali＠redhat.com 04 Nov '14

04 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: skip failing proxy when waiting for status ...................................................................... core: skip failing proxy when waiting for status This patch fix a bug when we have a preferred proxy (in 6the same cluster as the fenced host) that failed to perform the desired operation. In this case, we should remember the failed proxy inside the "get status" loop and use the one that had succeeded (if exists) Change-Id: I2b846444ff795e7099b61f6d0be8909402b7bfa1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141514 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 17 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b846444ff795e7099b61f6d0be8909402b7bfa1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: set boot order index 0 for unmanaged nic
by tnisan＠redhat.com 04 Nov '14

04 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: set boot order index 0 for unmanaged nic ...................................................................... core: set boot order index 0 for unmanaged nic This patch fix NPE which was thrown when computing boot order for a VM that has unmanaged network interface. The boot order index for unmanaged network interfaces will now be 0. Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Bug-Url: https://bugzilla.redhat.com/1155667 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added db upgrade job
by dcaroest＠redhat.com 04 Nov '14

04 Nov '14

David Caro has submitted this change and it was merged. Change subject: Added db upgrade job ...................................................................... Added db upgrade job I had to add also some extra files: * support to upgrade from or to a branch * whitelist scripts, triggers, builder and publisher * generic gerrit scm Change-Id: Iae2aaf97d330757441872586aa844ab07cd42f36 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/groovy-scripts/whitelist-filter.groovy A jobs/confs/shell-scripts/ovirt-engine_upgrade-db.cleanup.sh A jobs/confs/shell-scripts/ovirt-engine_upgrade-db.sh A jobs/confs/shell-scripts/whitelist-filter.sh A jobs/confs/yaml/builders/ovirt-engine_upgrade-db.yaml A jobs/confs/yaml/builders/whitelist.yaml A jobs/confs/yaml/jobs/ovirt-engine/ovirt-engine_upgrade-db.yaml A jobs/confs/yaml/publishers/whitelist.yaml A jobs/confs/yaml/scms/gerrit.yaml A jobs/confs/yaml/templates/engine-upgrade-db.yaml M jobs/confs/yaml/triggers/gerrit.yaml 11 files changed, 272 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae2aaf97d330757441872586aa844ab07cd42f36 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add MaxHostNetworkQosShares configuration value
by lvernia＠redhat.com 04 Nov '14

04 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Add MaxHostNetworkQosShares configuration value ...................................................................... core: Add MaxHostNetworkQosShares configuration value This will be used to determine the maximum number of allowed shares given to a specific network - this will be used to set the granularity/resolution of traffic prioritization by network. Change-Id: Idfd8df78fd8a06b5e73d1a66f12897d423cdcfe0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 4 files changed, 8 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/34762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfd8df78fd8a06b5e73d1a66f12897d423cdcfe0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove VmCommand.getBlockSparseInitSizeInGb
by amureini＠redhat.com 04 Nov '14

04 Nov '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VmCommand.getBlockSparseInitSizeInGb ...................................................................... core: Remove VmCommand.getBlockSparseInitSizeInGb This function is unused, and thus could (and should!) be removed. Change-Id: I901faf1a6fec899c0c3604d23533bf180c88eee1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I901faf1a6fec899c0c3604d23533bf180c88eee1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: add element ids to vm general subtab
by awels＠redhat.com 03 Nov '14

03 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: add element ids to vm general subtab ...................................................................... userportal, webadmin: add element ids to vm general subtab Added element ids to the vm general subtab -- every row, every column in the form. The ids will have the format unique-prefix_rowX_colX_label and unique-prefix_rowX_colX_value. Also added some infrastructure to easily add ids to all of the sub-tab form views. Change-Id: I0d2c6843c61a1d9364a36e8d4d3b5b64a1726f69 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundFormWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.java 4 files changed, 48 insertions(+), 1 deletion(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d2c6843c61a1d9364a36e8d4d3b5b64a1726f69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: version bump
by tnisan＠redhat.com 03 Nov '14

03 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Bug-Url: https://bugzilla.redhat.com/1154398 Change-Id: Ib69768ab2b384136308e16624a365c98583fba63 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib69768ab2b384136308e16624a365c98583fba63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0