Change in ovirt-engine[master]: core, engine, webadmin: Consider only online logical CPUs
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core, engine, webadmin: Consider only online logical CPUs
......................................................................
core, engine, webadmin: Consider only online logical CPUs
This patch reports the ids of the logical CPUs which are online in the
Hosts tab of the webadmin interface, and uses this information to
validate the CPU pinning during the VM creation.
A new column in the vds_dynamic table was added to store this list.
Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148092
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_0510_add_online_cpu_list.sql
M packaging/dbscripts/vds_sp.sql
15 files changed, 112 insertions(+), 17 deletions(-)
Approvals:
Vitor de Lima: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: Introduction of new logging framework
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: jsonrpc: Introduction of new logging framework
......................................................................
jsonrpc: Introduction of new logging framework
In order to be able to change logging framework from commons-logging to
slf4j and support future vdsm-jsonrpc-java updates we, introduce
additional dependency in module.xml.
Change-Id: I8669dcdb1dbbde4f6fa45443e120fceae1597059
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1159832
---
M backend/manager/dependencies/src/main/modules/org/ovirt/vdsm-jsonrpc-java/main/module.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Alon Bar-Lev: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34503
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8669dcdb1dbbde4f6fa45443e120fceae1597059
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Fix frontend compile fedora 21
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal,webadmin: Fix frontend compile fedora 21
......................................................................
userportal,webadmin: Fix frontend compile fedora 21
- On java < 8 the missing class definition for GenericApiGWTServiceAsync
was silently ignored and would not cause an issue, but with fedora 21
you can't downgrade to java < 8 so the missing class would cause the
compile to fail. The class is generated but we never added the generated
classes path to the source definition in the POM.xml
Change-Id: Ib7fc9c9ecebf39dcae3a0b9c3923e2790dbb179a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159026
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/pom.xml
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Alexander Wels: Verified
Vojtech Szocs: Verified; Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7fc9c9ecebf39dcae3a0b9c3923e2790dbb179a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: ignore powering-up events when vm is being migrated
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: ignore powering-up events when vm is being migrated
......................................................................
core: ignore powering-up events when vm is being migrated
No need to decrease the pending memory & cpu because of powering-up
events while the VM is being migrated. The migrate command is
responsible to decrease the pending resources when it is finished.
Change-Id: Ib1c57900fd3fbc0cb9a5953bee90e53ab11ef7c4
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
4 files changed, 20 insertions(+), 24 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1c57900fd3fbc0cb9a5953bee90e53ab11ef7c4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: core: assume live snapshot supported as default
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: assume live snapshot supported as default
......................................................................
core: assume live snapshot supported as default
VDSM will report if underlying QEMU reports
live snapshot or not. This information is
provided through libvirt.
If libvirt, or VDSM, no longer report
this capability, Engine get stuck with
the old value and it is no longer updated.
There is an unlucky case on CentOS and RHEL 6.6
on which we can hit this condition.
To fix that, this patch assumes live snapshot
is supported if we don't have word from VDSM.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159211
Related-To: http://bugzilla.redhat.com/1149460
Related-To: http://bugzilla.redhat.com/1158974
Change-Id: I4660560e08f606e2b16a580ef60618abfad49244
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4660560e08f606e2b16a580ef60618abfad49244
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: packaging: setup: Stop remote dwh
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Stop remote dwh
......................................................................
packaging: setup: Stop remote dwh
Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a
Bug-Url: https://bugzilla.redhat.com/1024028
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
A packaging/setup/ovirt_engine_setup/engine_common/dwh_history_timekeeping.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py
3 files changed, 226 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Shirly Radco: Looks good to me, but someone else must approve
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/34566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: core: don't allow snapshot for suspended vm
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: don't allow snapshot for suspended vm
......................................................................
core: don't allow snapshot for suspended vm
creating snapshot while vm is suspended is problematic,
since when resuming, vdsm still use the old volumes,
another problem is that the hibernation volumes info is not saved in the
ovf.
Change-Id: Icf2c4c3ec3561df1d35f5e4da964664d63598434
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120232
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
3 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf2c4c3ec3561df1d35f5e4da964664d63598434
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: core: Update host network QoS supported version to 3.6
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Update host network QoS supported version to 3.6
......................................................................
core: Update host network QoS supported version to 3.6
It used to be 3.4, but due to shortcomings of libvirt it is only made
available in 3.6.
Change-Id: I8bb61c373cb99f36e00d913dd61afc3b33ae34eb
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/34118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bb61c373cb99f36e00d913dd61afc3b33ae34eb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: core: assume live snapshot supported as default
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: assume live snapshot supported as default
......................................................................
core: assume live snapshot supported as default
VDSM will report if underlying QEMU reports
live snapshot or not. This information is
provided through libvirt.
If libvirt, or VDSM, no longer report
this capability, Engine get stuck with
the old value and it is no longer updated.
There is an unlucky case on CentOS and RHEL 6.6
on which we can hit this condition.
To fix that, this patch assumes live snapshot
is supported if we don't have word from VDSM.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159211
Related-To: http://bugzilla.redhat.com/1149460
Related-To: http://bugzilla.redhat.com/1158974
Change-Id: I4660560e08f606e2b16a580ef60618abfad49244
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4660560e08f606e2b16a580ef60618abfad49244
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: core: osinfo - fail backend startup on coliding os id error
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: osinfo - fail backend startup on coliding os id error
......................................................................
core: osinfo - fail backend startup on coliding os id error
fail loading the backend by throwing a RuntimeException if an osinfo
properties have colliding id's.
e.g
os.linux.id.value = 12345
os.windows.id.value = 12345
obviously wrong and should fail with logged exception
"java.lang.RuntimeException: colliding os id 12345 at node /os/windows/id"
Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d
Bug-Url: https://bugzilla.redhat.com/996055
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
2 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months