Change in ovirt-hosted-engine-setup[master]: packaging: setup: matching also virtual interface names
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: matching also virtual interface names
......................................................................
packaging: setup: matching also virtual interface names
Modifying a regular expression to match also virtual interface name
like VLAN ones.
Change-Id: Ib6924883c2d44940f8e43e06b417b869fdb689fd
Bug-Url: https://bugzilla.redhat.com/1172287
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/36047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6924883c2d44940f8e43e06b417b869fdb689fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Remove typo in method name
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove typo in method name
......................................................................
core: Remove typo in method name
Fix typo in method name
Change-Id: I831cffe6fbfd8c2032b627c84a1fe0630f50e427
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I831cffe6fbfd8c2032b627c84a1fe0630f50e427
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in jenkins[master]: Adding the host-deploy create-rpm jobs
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Adding the host-deploy create-rpm jobs
......................................................................
Adding the host-deploy create-rpm jobs
Change-Id: I6645df8e888856f3e39834f35f0ecd7f12c1661c
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/shell-scripts/build_mock_srcrpm.sh
M jobs/confs/shell-scripts/mock_build_onlyrpm.sh
A jobs/confs/yaml/jobs/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml
A jobs/confs/yaml/scms/ovirt-host-deploy.yaml
4 files changed, 60 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6645df8e888856f3e39834f35f0ecd7f12c1661c
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: improve exception handling on run vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: improve exception handling on run vm
......................................................................
core: improve exception handling on run vm
In case an exception is thrown when calling the 'create' verb in VDSM
and there is no point to retry to run the VM on other host, we used to
just re-throw the exception in RunVmCommand to prevent the rerun
mechanism from taking place.
The problem is that this way the pending resources were not cleared
in this flow. The solution is to improve the error handling:
1. If Done/exists exception was thrown, we call the reportCompleted to
decrease the pending resources
2. If VDS_NETWORK_ERROR/PROVIDER_FAILURE exception was thrown, we call
the runningFailed to decrease the pending resources (in this case, the
VM should be treated as if it went down, we should remove its
stateless snapshot if such snapshot exists for example).
Change-Id: Iee3bdb65ca58c49de65770d4e9cf9435bbbe5070
Bug-Url: https://bugzilla.redhat.com/1163142
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/35890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee3bdb65ca58c49de65770d4e9cf9435bbbe5070
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in jenkins[master]: Doing proper mock cleanup
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Doing proper mock cleanup
......................................................................
Doing proper mock cleanup
Now it checks if there are any mounted dirs inside the chroot and tries to
umount before removing. It will fail if unable to umount.
Also the cleanup has been put as post-build task, so it should always run.
Changed the logs tarball extension to more standard tgz
Change-Id: I20cb54fb968556f3d1bdcf3a9ab14e826c56b352
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/shell-scripts/mock_cleanup.sh
M jobs/confs/shell-scripts/mock_setup.sh
M jobs/confs/yaml/builders/mock_install.yaml
M jobs/confs/yaml/builders/mock_rpm.yaml
A jobs/confs/yaml/publishers/mock-cleanup.yaml
M jobs/confs/yaml/templates/create-rpms_mock.yaml
M jobs/confs/yaml/templates/install-rpm-sanity.yaml
7 files changed, 134 insertions(+), 12 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20cb54fb968556f3d1bdcf3a9ab14e826c56b352
Gerrit-PatchSet: 9
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: prevent disks from remaining in locked status
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: prevent disks from remaining in locked status
......................................................................
core: prevent disks from remaining in locked status
When disks are marked to remain in ILLEGAL status after failed creation
they remain LOCKED because getRelevantDiskImage() retunrs null.
As this patch is about to be backported to the 3.5 branch and it's
preferred to keep the side effects to be minimal, in this patch i
overload the setImageStatus method so that the disk will be passed to
it.
Change-Id: Iaf82438a9985b86b8f5412158f236628972c0f3f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1172130
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/36020
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf82438a9985b86b8f5412158f236628972c0f3f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: core: prevent disks from remaining in locked status
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: prevent disks from remaining in locked status
......................................................................
core: prevent disks from remaining in locked status
When disks are marked to remain in ILLEGAL status after failed creation
they remain LOCKED because getRelevantDiskImage() retunrs null.
As this patch is about to be backported to the 3.5 branch and it's
preferred to keep the side effects to be minimal, in this patch i
overload the setImageStatus method so that the disk will be passed to
it.
Change-Id: Iaf82438a9985b86b8f5412158f236628972c0f3f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1172130
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf82438a9985b86b8f5412158f236628972c0f3f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: rename: handle dwh_history_timekeeping
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: rename: handle dwh_history_timekeeping
......................................................................
packaging: rename: handle dwh_history_timekeeping
Change the dwh fqdn when running rename in the table
dwh_history_timekeeping.
Change-Id: I66faffd0d2fb40f2b30d084da24e194fe7dc29ec
Bug-Url: https://bugzilla.redhat.com/1170229
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 0d36281921156995ef9fca659333b71ba9103632)
---
A packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-dwh/__init__.py
A packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-dwh/database.py
2 files changed, 82 insertions(+), 0 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66faffd0d2fb40f2b30d084da24e194fe7dc29ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-dwh-3.5
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-dwh[master]: packaging: rename: handle dwh_history_timekeeping
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: rename: handle dwh_history_timekeeping
......................................................................
packaging: rename: handle dwh_history_timekeeping
Change the dwh fqdn when running rename in the table
dwh_history_timekeeping.
Change-Id: I66faffd0d2fb40f2b30d084da24e194fe7dc29ec
Bug-Url: https://bugzilla.redhat.com/1170229
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
A packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-dwh/__init__.py
A packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-dwh/database.py
2 files changed, 82 insertions(+), 0 deletions(-)
Approvals:
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66faffd0d2fb40f2b30d084da24e194fe7dc29ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: tools: tests: FirstMatchSimpleFilter ignore ordering
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering
......................................................................
tools: tests: FirstMatchSimpleFilter ignore ordering
ignore ordering of output events as it may be at any order as long as
correct events are sent.
simplify tests while doing so.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1171160
Change-Id: I935b68fa497cd793a503aff7f84be03e80603e94
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java
1 file changed, 20 insertions(+), 71 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I935b68fa497cd793a503aff7f84be03e80603e94
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years