December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: tests: FirstMatchSimpleFilter ignore ordering
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering ...................................................................... tools: tests: FirstMatchSimpleFilter ignore ordering ignore ordering of output events as it may be at any order as long as correct events are sent. simplify tests while doing so. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1171160 Change-Id: I935b68fa497cd793a503aff7f84be03e80603e94 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java 1 file changed, 20 insertions(+), 71 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I935b68fa497cd793a503aff7f84be03e80603e94 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: rename: drop handling of RedirectServletReportsPage
by sbonazzo＠redhat.com 09 Dec '14

09 Dec '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: rename: drop handling of RedirectServletReportsPage ...................................................................... packaging: rename: drop handling of RedirectServletReportsPage This option does not exist in 3.5. Bug-Url: https://bugzilla.redhat.com/1170229 Change-Id: If22134524c7699d53fb944b9b26dc158ac71ea49 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py 1 file changed, 0 insertions(+), 31 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If22134524c7699d53fb944b9b26dc158ac71ea49 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Remove Storage connection on import domain failure
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Remove Storage connection on import domain failure ...................................................................... webadmin: Remove Storage connection on import domain failure Remove storage server connection if we failed to import an existing Storage Domain. Change-Id: I553a311fe8856b9cd5825405fef39e91e4c6e771 Bug-Url: https://bugzilla.redhat.com/1136930 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I553a311fe8856b9cd5825405fef39e91e4c6e771 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, engine: Disable CPU pinning validation
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: core, engine: Disable CPU pinning validation ...................................................................... core, engine: Disable CPU pinning validation This patch disables the validation responsible for checking if a physical CPU exists during the verification of CPU pinning settings. This is needed in ppc64 due to the lack of a list of which CPUs are online, something that is correctly reported currently only in x86-64. As soon as this missing info is fixed in ppc64, this patch can be reverted. Change-Id: I98c7a2f136b278a7a695bae8b2eadd3658f3e65c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1171724 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java 2 files changed, 0 insertions(+), 43 deletions(-) Approvals: Vitor de Lima: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98c7a2f136b278a7a695bae8b2eadd3658f3e65c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix cpu profile changes for import
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fix cpu profile changes for import ...................................................................... webadmin: fix cpu profile changes for import When importing vm/template and changing cluster didn't change corresponding cpu profile. Change-Id: Ia524e72fcff6d3cc655e6aee9f078b9365faaba3 Bug-Url: https://bugzilla.redhat.com/1168532 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 1 file changed, 20 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Gilad Chaplik: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia524e72fcff6d3cc655e6aee9f078b9365faaba3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: CPU shares custom value is now possible
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: CPU shares custom value is now possible ...................................................................... webadmin: CPU shares custom value is now possible On the "New Virtual Machine" dialog, inside the "Resource Allocation" tab on the left, when selecting "Custom" on the CPU shares combobox, the textbox on the right(Where you set the actual value of the CPU shares) wasn't changeable. Now, it becomes changeable once "Custom" is chosen and unchangeable once another value is chosen in the combobox. Change-Id: Ie1fe20afa682926ac14b7d9ac7c5fa589b3b0459 Bug-Url: https://bugzilla.redhat.com/1152636 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1fe20afa682926ac14b7d9ac7c5fa589b3b0459 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix disk move and export metadata
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix disk move and export metadata ...................................................................... restapi: Fix disk move and export metadata The description of the operations to move, copy and export disks using the top level disks collection is incorrect. This means that these operations aren't supported in the SDKs and in the CLI. This patch fixes the documentation. Change-Id: I8a5cec5bf3049d3a9325b23a7d54c21565388b51 Bug-Url: https://bugzilla.redhat.com/1169376 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a3589e9e649f076344b1949aa9cc99944d7de942) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5cec5bf3049d3a9325b23a7d54c21565388b51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix missing QoS name from audig log
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix missing QoS name from audig log ...................................................................... core: fix missing QoS name from audig log Change-Id: Id37d5210e4dc963217587ff93ff88d428cb38919 Bug-Url: https://bugzilla.redhat.com/1168250 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id37d5210e4dc963217587ff93ff88d428cb38919 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed misalignment 'Copy Quota' dialog.
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fixed misalignment 'Copy Quota' dialog. ...................................................................... webadmin: Fixed misalignment 'Copy Quota' dialog. On the french version of the webadmin, Inside the "Copy Quota" dialog, the "copy consumers and permissions" label was sliding of to the next line. This error was fixed by extending the width of the "copyPermissionsEditor" field to 600px. Change-Id: I5bb7d488d9570591215118633e69437bd0f6af17 Bug-Url: https://bugzilla.redhat.com/1123796 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomer Saban: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bb7d488d9570591215118633e69437bd0f6af17 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: rest: Validation of the protocol values
by oourfali＠redhat.com 09 Dec '14

09 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: rest: Validation of the protocol values ...................................................................... rest: Validation of the protocol values We did not check protocol values provided so update of the host with wrong protocol string failed on backend whereas it should fail during initial validation. Change-Id: I666b5469bcaf2bd00f793ad4320c3f37505d49b0 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1170125 --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HostProtocol.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/HostValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 6 files changed, 81 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I666b5469bcaf2bd00f793ad4320c3f37505d49b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0