Change in ovirt-engine[ovirt-engine-3.5]: core: Enable Live Merge in Snapshots Overview
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Enable Live Merge in Snapshots Overview
......................................................................
core: Enable Live Merge in Snapshots Overview
Enable Live Merge in the snapshots overview. This required enabling
the action in CanDoAction using code similar to RemoveSnapshotCommand,
and branching RemoveDiskSnapshotsCommand to use CoCo in executing the
Live Merge rather than task handlers for cold merge.
The task handlers for cold merge are initialized early in the command
lifecycle, before the command knows if the VM is up. Therefore, a
means of disabling these handlers is provided so that once the command
can determine a Live Merge is occurring, it can disable the handlers
and rely on command coordination for the merge execution.
Change-Id: I30d152a70ebdeacf0410d7ad15a49e44fb564a18
Bug-Url: https://bugzilla.redhat.com/1133890
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java
6 files changed, 295 insertions(+), 10 deletions(-)
Approvals:
Greg Padgett: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30d152a70ebdeacf0410d7ad15a49e44fb564a18
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Enable Live Merge in Snapshots Overview
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Enable Live Merge in Snapshots Overview
......................................................................
core: Enable Live Merge in Snapshots Overview
Enable Live Merge in the snapshots overview. This required enabling
the action in CanDoAction using code similar to RemoveSnapshotCommand,
and branching RemoveDiskSnapshotsCommand to use CoCo in executing the
Live Merge rather than task handlers for cold merge.
The task handlers for cold merge are initialized early in the command
lifecycle, before the command knows if the VM is up. Therefore, a
means of disabling these handlers is provided so that once the command
can determine a Live Merge is occurring, it can disable the handlers
and rely on command coordination for the merge execution.
Change-Id: I30d152a70ebdeacf0410d7ad15a49e44fb564a18
Bug-Url: https://bugzilla.redhat.com/1133890
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java
6 files changed, 295 insertions(+), 10 deletions(-)
Approvals:
Greg Padgett: Verified
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30d152a70ebdeacf0410d7ad15a49e44fb564a18
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: Add support for copied disk template
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add support for copied disk template
......................................................................
core: Add support for copied disk template
Add support for copied disk Template so an unregistered Template can be
registered with its copied disks
Change-Id: Id7514146d26792a361e47d1de820f5233ff9bf40
Bug-Url: https://bugzilla.redhat.com/1138136
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java
1 file changed, 79 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/35998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7514146d26792a361e47d1de820f5233ff9bf40
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: Increment DB Generation when image is copied
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Increment DB Generation when image is copied
......................................................................
core: Increment DB Generation when image is copied
Increment the DB genereation when a template image is being copied, so
the desctination Storage Domain will be updated with the Template OVF.
Change-Id: Icdd5e02387fe729195bd4b3c502636671a914e5d
Bug-Url: https://bugzilla.redhat.com/1138136
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/35997
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdd5e02387fe729195bd4b3c502636671a914e5d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: Fetch unregisterd entity from all the Storage Domains.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fetch unregisterd entity from all the Storage Domains.
......................................................................
core: Fetch unregisterd entity from all the Storage Domains.
Add the ability to fetch an entity from all the
Storage Domains with a stored procedure, by passing null as storage domain id.
This stored procedure should be used for fetching Tempalte with disk copied on several
Storage Domains.
Change-Id: Ia279818045ee3adfcda6383b010ac9f7e283886f
Bug-Url: https://bugzilla.redhat.com/1138136
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQueryTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/unregistered_OVF_data_sp.sql
10 files changed, 66 insertions(+), 31 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/35996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia279818045ee3adfcda6383b010ac9f7e283886f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: Add a warnning when OVF_STORE disks does not exists.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add a warnning when OVF_STORE disks does not exists.
......................................................................
core: Add a warnning when OVF_STORE disks does not exists.
Add a warnning on attach operation to notify the user that there are no
backup componenets if the Storage Domain was handled before in a Data
Center version lower then 3.5
Change-Id: I79de5110898852a5bf3d46227aa7eef36a74a74a
Bug-Url: https://bugzilla.redhat.com/1168132
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/35995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79de5110898852a5bf3d46227aa7eef36a74a74a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: more accurate cores(threads) ui representation
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: more accurate cores(threads) ui representation
......................................................................
core: more accurate cores(threads) ui representation
in case of 2 cores 2 sockets and cluster-count threads as cores, we want
to show at the host general tab
2(4) which reads 2 cores which is actual 4 for scheduling.
without that fixed it showed the overall count which was 2(8)
Change-Id: I4a2c3563bfd667331a58bf558c1161d4e379c624
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1169404
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Roy Golan: Verified
--
To view, visit http://gerrit.ovirt.org/36014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a2c3563bfd667331a58bf558c1161d4e379c624
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[ovirt-engine-3.5]: packaging: rename: drop handling of RedirectServletReportsPage
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: rename: drop handling of RedirectServletReportsPage
......................................................................
packaging: rename: drop handling of RedirectServletReportsPage
This option does not exist in 3.5.
Bug-Url: https://bugzilla.redhat.com/1170229
Change-Id: If22134524c7699d53fb944b9b26dc158ac71ea49
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 9601e6223b9f602a6c6a30ec8e1b25d985876258)
---
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py
1 file changed, 0 insertions(+), 31 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/36004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If22134524c7699d53fb944b9b26dc158ac71ea49
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: ImportVmFromExportDomainModel#doInit DLS
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: ImportVmFromExportDomainModel#doInit DLS
......................................................................
webadmin: ImportVmFromExportDomainModel#doInit DLS
Removed the unused local variable cluster which was causing a FindBugs
warning.
Change-Id: Iaf9dc95b3099c202cebdf955db6706990f4cf0bf
Bug-Url: https://bugzilla.redhat.com/1168532
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf9dc95b3099c202cebdf955db6706990f4cf0bf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: webadmin: ImportVmFromExportDomainModel#doInit DLS
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: ImportVmFromExportDomainModel#doInit DLS
......................................................................
webadmin: ImportVmFromExportDomainModel#doInit DLS
Removed the unused local variable cluster which was causing a FindBugs
warning.
Change-Id: Iaf9dc95b3099c202cebdf955db6706990f4cf0bf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/36002
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf9dc95b3099c202cebdf955db6706990f4cf0bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years