February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Correct timezone offset for Sri Lanka
by ofrenkel＠redhat.com 23 Feb '14

23 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Correct timezone offset for Sri Lanka ...................................................................... engine: Correct timezone offset for Sri Lanka The offset should be GMT+05:30 instead of GMT+06:00 Change-Id: I2243780f409443e6d9a59eb89b30076a47ae1707 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1045681 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2243780f409443e6d9a59eb89b30076a47ae1707 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: customization fixed capitalizing in patch
by ydary＠redhat.com 23 Feb '14

23 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: customization fixed capitalizing in patch ...................................................................... packaging: customization fixed capitalizing in patch Change-Id: Id72b0a26be20a7d99e971b99facd891505ec144d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/jasper-war-patches/300_003_jsp_rebrand-tab-headers.patch 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id72b0a26be20a7d99e971b99facd891505ec144d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: block migration for paused vm only in case of an error
by ofrenkel＠redhat.com 23 Feb '14

23 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: block migration for paused vm only in case of an error ...................................................................... core: block migration for paused vm only in case of an error We used to block migration for every VM which is in paused state but actually VMs which are in paused state not due to an error should be able to migrate so we should not block it for such VMs. Change-Id: Ic6e7a7d41fcf66e2d3c13b93de7dd68b42aeaecb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 17 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6e7a7d41fcf66e2d3c13b93de7dd68b42aeaecb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3]: build: post ovirt-engine-dwh-3.3.4_beta
by ydary＠redhat.com 23 Feb '14

23 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.3.4_beta ...................................................................... build: post ovirt-engine-dwh-3.3.4_beta Change-Id: I13adff832a0e603b7767931955161a4d6dc068de Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13adff832a0e603b7767931955161a4d6dc068de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: use war name regardless of package name
by ydary＠redhat.com 23 Feb '14

23 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: use war name regardless of package name ...................................................................... packaging: setup: use war name regardless of package name support both ce and pro. Change-Id: Id8d87d04039cc61138e2524a0caf1021bd353560 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/jasper-master.properties.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8d87d04039cc61138e2524a0caf1021bd353560 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Meaningful WebSockeProxy config description
by ofrenkel＠redhat.com 23 Feb '14

23 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: tools: Meaningful WebSockeProxy config description ...................................................................... tools: Meaningful WebSockeProxy config description Currently WebSockeProxy config description makes little sense. This patch should put more light on possible config values description. Change-Id: Ifc49f77dcb5d686c6066ddd7f0badbf5493fb556 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc49f77dcb5d686c6066ddd7f0badbf5493fb556 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Provide defaultRoute property for management network
by masayag＠redhat.com 23 Feb '14

23 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Provide defaultRoute property for management network ...................................................................... engine: Provide defaultRoute property for management network The engine should pass for setup networks requests a new property for the management network if it was configured as DHCP or with a static IP and a gateway was set for it. The new property will be supported from cluster levels 3.4 and above. This will allow vdsm to be name-agnostic in regards to the management network. Change-Id: Id7bc20065ce28926ceb977c09f0480b345c66da5 Bug-Url: https://bugzilla.redhat.com/1015009 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 5 files changed, 43 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/23232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7bc20065ce28926ceb977c09f0480b345c66da5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Block labeling a bond without slaves
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Block labeling a bond without slaves ...................................................................... engine: Block labeling a bond without slaves SetupNetworks doesn't support a bond without at least 2 slaves, therefore such bonds shouldn't be labeled. Bug-Url: http://bugzilla.redhat.com/1054187 Change-Id: Ifeb8854797d397aaaf23001ff481b39916289445 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifeb8854797d397aaaf23001ff481b39916289445 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Allow network update if vnics are unplugged
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Allow network update if vnics are unplugged ...................................................................... engine: Allow network update if vnics are unplugged If a network is configured on running VMs, but no active nic is using it, the update should be permitted. Change-Id: I0bdbc159edb95b530b1c0b04b81589495a2c1123 Bug-Url: https://bugzilla.redhat.com/1059741 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bdbc159edb95b530b1c0b04b81589495a2c1123 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: revert refresh synchornization
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: revert refresh synchornization ...................................................................... webadmin: revert refresh synchornization - Revert Change-Id: I8742785cb9b3d890c39859586b03cd53c64b31e5 As this patch created a bunch of unforseen regressions. - Properly fixing those issues will take longer than the time we have for 3.4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066953 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066489 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066956 Change-Id: I00c0454852f875d7d2b6734caebda63af47b7eb0 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridController.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmMonitorModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java 8 files changed, 72 insertions(+), 147 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00c0454852f875d7d2b6734caebda63af47b7eb0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0