February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix CDA message to include status
by iheim＠redhat.com 20 Feb '14

20 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix CDA message to include status ...................................................................... core: Fix CDA message to include status Use format message correctly for Storage validation Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1067103 Bug-Url: https://bugzilla.redhat.com/1066838 Change-Id: I9620d167ec969ee6523829f0bd92fd1ca65f6b1f --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9620d167ec969ee6523829f0bd92fd1ca65f6b1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: cleanup nfs exports usage
by iheim＠redhat.com 20 Feb '14

20 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: cleanup nfs exports usage ...................................................................... packaging: setup: cleanup nfs exports usage 1. if exports.d exists and we registered ourselves previously in exports, move the entry to our own file. 2. if ACL specified enforce a new entry. 3. do not touch anything on upgrade unless (2). Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058018 Change-Id: Ie3df61b1b52aead5ddf457da14f26324dbc2a56c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py 2 files changed, 121 insertions(+), 82 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3df61b1b52aead5ddf457da14f26324dbc2a56c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin, backend: control of hosted engine maintenance mode
by iheim＠redhat.com 20 Feb '14

20 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin, backend: control of hosted engine maintenance mode ...................................................................... webadmin, backend: control of hosted engine maintenance mode Allow control of hosted engine local/global maintenance. Global maintenance is performed via right-clicking on the host, while local maintenance is tied into the existing host vds maintenance operation. Change-Id: I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74 Bug-Url: https://bugzilla.redhat.com/1047649 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetHaMaintenanceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetHaMaintenanceParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HaMaintenanceMode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetHaMaintenanceModeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetHaMaintenanceModeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_04_0620_add_ha_maintenance_events.sql 27 files changed, 403 insertions(+), 7 deletions(-) Approvals: Greg Padgett: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: show hosted engine info in host>general tab
by iheim＠redhat.com 20 Feb '14

20 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: show hosted engine info in host>general tab ...................................................................... webadmin: show hosted engine info in host>general tab Display a single entry in the host > general tab displaying hosted engine status, if it is configured on the selected host. Change-Id: I17f0eff120b2ab99b4badc53da1780c1e758299c Bug-Url: https://bugzilla.redhat.com/1047649 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 6 files changed, 81 insertions(+), 4 deletions(-) Approvals: Jiří Moskovčák: Looks good to me, but someone else must approve Greg Padgett: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17f0eff120b2ab99b4badc53da1780c1e758299c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: backend, db: store additional hosted engine info
by iheim＠redhat.com 20 Feb '14

20 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: backend, db: store additional hosted engine info ...................................................................... backend, db: store additional hosted engine info New fields for hosted engine, allowing UI display/control of maintenance operations. Adds: ha_configured - HA is installed on the host ha_active - HA is currently running/updating on the host ha_global_maintenance - HA global maintenance is enabled according to the host ha_local_maintenance - HA local maintenance is enabled on the host Change-Id: Ib62849ffe0f7392c1feb1f2a0536a23410b58210 Bug-Url: https://bugzilla.redhat.com/1047649 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_04_0610_add_ha_columns_to_vds_statistics.sql M packaging/dbscripts/vds_sp.sql 10 files changed, 202 insertions(+), 23 deletions(-) Approvals: Greg Padgett: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib62849ffe0f7392c1feb1f2a0536a23410b58210 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: broker: check status of network bridge
by gpadgett＠redhat.com 20 Feb '14

20 Feb '14

Greg Padgett has submitted this change and it was merged. Change subject: broker: check status of network bridge ...................................................................... broker: check status of network bridge The bridge status submonitor used to only check for the existence of a network bridge. Now, it will also check to see if there are any ports associated with the bridge. Change-Id: I24a18e729df30440411fbfeeb8cfbdb564dec29e Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/submonitors/mgmt_bridge.py 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24a18e729df30440411fbfeeb8cfbdb564dec29e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix CDA message to include status
by derez＠redhat.com 20 Feb '14

20 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix CDA message to include status ...................................................................... core: Fix CDA message to include status Use format message correctly for Storage validation Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I9620d167ec969ee6523829f0bd92fd1ca65f6b1f --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9620d167ec969ee6523829f0bd92fd1ca65f6b1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.4]: packaging: configuration cleanups
by sbonazzo＠redhat.com 20 Feb '14

20 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: configuration cleanups ...................................................................... packaging: configuration cleanups - install imageuploader.conf with 0640 access mode - avoid to install hidden empty files for creating an empty configuration directory Change-Id: Idb1559da5d95e723d4b9c2b45760a71700d865f8 Bug-Url: https://bugzilla.redhat.com/1058810 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-image-uploader.spec.in D src/.keep M src/Makefile.am 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb1559da5d95e723d4b9c2b45760a71700d865f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: packaging: configuration cleanups
by sbonazzo＠redhat.com 20 Feb '14

20 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: configuration cleanups ...................................................................... packaging: configuration cleanups - install imageuploader.conf with 0640 access mode - avoid to install hidden empty files for creating an empty configuration directory Change-Id: Idb1559da5d95e723d4b9c2b45760a71700d865f8 Bug-Url: https://bugzilla.redhat.com/1058810 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-image-uploader.spec.in D src/.keep M src/Makefile.am 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb1559da5d95e723d4b9c2b45760a71700d865f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Base the log rotation on time instead of the log file size
by msivak＠redhat.com 20 Feb '14

20 Feb '14

Martin Sivák has submitted this change and it was merged. Change subject: Base the log rotation on time instead of the log file size ...................................................................... Base the log rotation on time instead of the log file size Change-Id: I22f227fd402071a696fd6dccd688e87d733634eb Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit fbdb4da80a8dc3169fe97fa7e97bdb9d0734bff6) --- M ovirt_hosted_engine_ha/agent/agent-log.conf.in M ovirt_hosted_engine_ha/broker/broker-log.conf.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22f227fd402071a696fd6dccd688e87d733634eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0