Change in ovirt-engine[master]: 1. [WIP] core: Changing UserDomainsCacheManager to be a regu...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: 1. [WIP] core: Changing UserDomainsCacheManager to be a regular singleton
......................................................................
1. [WIP] core: Changing UserDomainsCacheManager to be a regular singleton
There is no particular need for this to be an EJB singleton.
Change-Id: I68d4cff4ecf7bbf0052d0473f9a833e17b4e8d1c
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java
2 files changed, 16 insertions(+), 33 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68d4cff4ecf7bbf0052d0473f9a833e17b4e8d1c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Add more files to .gitignore
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Add more files to .gitignore
......................................................................
Add more files to .gitignore
Change-Id: I694be218c187ec1d531a426dfcf76f8c8764da2a
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit b8f29d2197589247cf70108da76218e8d6a30d1c)
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I694be218c187ec1d531a426dfcf76f8c8764da2a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.1
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
10 years, 10 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Document the Agent FSM using docstrings and autogenerate the...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Document the Agent FSM using docstrings and autogenerate the graphviz sources
......................................................................
Document the Agent FSM using docstrings and autogenerate the graphviz sources
This adds two special lines to state class docstrings:
:transition[ destination]: description
- describes transition from current class to destination
- it is treated as staying in the current state when
destination is not provided
:transitions_from StateClass:
- used to support inheritance, copies all transitions
from StateClass to the current class
This patch also adds a script that reads the state_machine.py and
states.py modules and generates the fill graphviz source for the
state machine.
make fsm then generates the new source and png file with the state
machine.
Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit 21a18395a2b9d8724a3712910e20efaed78ae3ac)
---
M Makefile.am
A build/build-aux/gen_gv.py
M doc/agent-fsm.gv
M ovirt_hosted_engine_ha/agent/state_machine.py
M ovirt_hosted_engine_ha/agent/states.py
5 files changed, 258 insertions(+), 31 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.1
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
10 years, 10 months
Change in ovirt-hosted-engine-ha[master]: Add more files to .gitignore
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Add more files to .gitignore
......................................................................
Add more files to .gitignore
Change-Id: I694be218c187ec1d531a426dfcf76f8c8764da2a
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified
Greg Padgett: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I694be218c187ec1d531a426dfcf76f8c8764da2a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-hosted-engine-ha[master]: Document the Agent FSM using docstrings and autogenerate the...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Document the Agent FSM using docstrings and autogenerate the graphviz sources
......................................................................
Document the Agent FSM using docstrings and autogenerate the graphviz sources
This adds two special lines to state class docstrings:
:transition[ destination]: description
- describes transition from current class to destination
- it is treated as staying in the current state when
destination is not provided
:transitions_from StateClass:
- used to support inheritance, copies all transitions
from StateClass to the current class
This patch also adds a script that reads the state_machine.py and
states.py modules and generates the fill graphviz source for the
state machine.
make fsm then generates the new source and png file with the state
machine.
Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M Makefile.am
A build/build-aux/gen_gv.py
M doc/agent-fsm.gv
M ovirt_hosted_engine_ha/agent/state_machine.py
M ovirt_hosted_engine_ha/agent/states.py
5 files changed, 258 insertions(+), 31 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified
Greg Padgett: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Fix singleton of LdapQueryExecutionBuilderImpl
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix singleton of LdapQueryExecutionBuilderImpl
......................................................................
core: Fix singleton of LdapQueryExecutionBuilderImpl
a. Remove static initialization
b. Instance will be initialized on demand
Change-Id: I7c8bfd1cef736518788a33cb0377a548afd3c831
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java
1 file changed, 8 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c8bfd1cef736518788a33cb0377a548afd3c831
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Removes legacy CLIParser
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Removes legacy CLIParser
......................................................................
tools: Removes legacy CLIParser
Removes legacy class CLIParser for command line argument parsing.
Change-Id: I5ba75031178d6f2b9500f932fc4d547f43066b2d
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CLIParser.java
1 file changed, 0 insertions(+), 36 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ba75031178d6f2b9500f932fc4d547f43066b2d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Remove dead code from KerberosConfigCheck
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Remove dead code from KerberosConfigCheck
......................................................................
tools: Remove dead code from KerberosConfigCheck
Removes dead code (not called from project) from KerberosConfigCheck
class.
Change-Id: I6521dd2b5bdc5ecc46b722528196886e4ee97328
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java
1 file changed, 1 insertion(+), 46 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6521dd2b5bdc5ecc46b722528196886e4ee97328
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Remove dead code from KrbConfCreator
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Remove dead code from KrbConfCreator
......................................................................
tools: Remove dead code from KrbConfCreator
Removes dead code (not called from project) from KrbConfCreator class.
Change-Id: I8d1fc4bac6480c40b0f6ff3df81f33570b4c0608
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java
1 file changed, 0 insertions(+), 65 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d1fc4bac6480c40b0f6ff3df81f33570b4c0608
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: tools: notifier: fix broken dao test.
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: tools: notifier: fix broken dao test.
......................................................................
tools: notifier: fix broken dao test.
Fixing breakage introduced by 320b46314d1f4018ee32ea9fcf5c1f0d9f8fb92d.
Change-Id: I0f3fd7a053ea94927e3e89051cfc6c85d1a54232
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f3fd7a053ea94927e3e89051cfc6c85d1a54232
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
10 years, 10 months