February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: Change existing disk validation CDA message in case of...
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Change existing disk validation CDA message in case of null disk alias ...................................................................... core: Change existing disk validation CDA message in case of null disk alias When try to import a VM which one or more of it's disks already exist on the system there's a CDA message containing the disk aliases of the existing disks, the aliases are taken from the disks in the export domian but in case the alias is null (mainly in backups of versions <V3.0, P2V, V2V etc..) the alias was displayed as a blank string, the CDA message was change and in case the alias is null the alias will be taken from the disk in the system Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/928864 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java 2 files changed, 32 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: database: cast port to str
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: cast port to str ...................................................................... packaging: setup: database: cast port to str old psycopg2 does not accept unicode string as port. python-psycopg2-2.0.14-2.el6.x86_64 TypeError: port must be a string or int *DO NOT* cast to int as usock will not work. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067058 Change-Id: I51476e7a07ae6bf475415329873c96ddea638686 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51476e7a07ae6bf475415329873c96ddea638686 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Control verbosity of GWT compiler
by vszocs＠redhat.com 19 Feb '14

19 Feb '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Control verbosity of GWT compiler ...................................................................... webadmin,userportal: Control verbosity of GWT compiler Using INFO as default GWT compiler log level. Can be customized through "gwt.logLevel" property, for example: make DEV_EXTRA_BUILD_FLAGS="-Dgwt.logLevel=TRACE" ... make EXTRA_BUILD_FLAGS="-Dgwt.logLevel=TRACE" ... Change-Id: I4d7333078bf4718687004938fa55a082bbcd6426 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d7333078bf4718687004938fa55a082bbcd6426 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: add use_latest_template_version to vm restapi
by juan.hernandez＠redhat.com 19 Feb '14

19 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: add use_latest_template_version to vm restapi ...................................................................... restapi: add use_latest_template_version to vm restapi Add the new optional parameter that is relevant for stateless vm creation. It can be also passed when updating a vm. By using it, users can select to always create stateless vm based on its latest version of the used template. Feature page http://www.ovirt.org/Features/Template_Versions#REST_API Change-Id: I38b569f7ef6df4d485dac15b804427c8248ab540 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 79 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Omer Frenkel: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b569f7ef6df4d485dac15b804427c8248ab540 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: timestamp tarball and rpms from master
by gpadgett＠redhat.com 19 Feb '14

19 Feb '14

Greg Padgett has submitted this change and it was merged. Change subject: packaging: timestamp tarball and rpms from master ...................................................................... packaging: timestamp tarball and rpms from master Change-Id: I2a5c49229df58c7d4a4ab2c3c4b037a5274c26ab Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a5c49229df58c7d4a4ab2c3c4b037a5274c26ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Add make test, make it work and use it in rpm build
by msivak＠redhat.com 19 Feb '14

19 Feb '14

Martin Sivák has submitted this change and it was merged. Change subject: Add make test, make it work and use it in rpm build ...................................................................... Add make test, make it work and use it in rpm build Change-Id: If7162928be49d1f505abc44d8f61c1d17b18de5b Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M Makefile.am M ovirt-hosted-engine-ha.spec.in A ovirt_hosted_engine_ha/broker/test/__init__.py M ovirt_hosted_engine_ha/broker/test/test_monitor.py 4 files changed, 8 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7162928be49d1f505abc44d8f61c1d17b18de5b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Fix the way we compute cpu_load average and add tests for it
by msivak＠redhat.com 19 Feb '14

19 Feb '14

Martin Sivák has submitted this change and it was merged. Change subject: Fix the way we compute cpu_load average and add tests for it ...................................................................... Fix the way we compute cpu_load average and add tests for it Change-Id: Id9e05c753f41dcd94d5a4734ac39f90581ddc0c0 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/Makefile.am M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/state_data.py A ovirt_hosted_engine_ha/agent/state_data_test.py M ovirt_hosted_engine_ha/agent/state_machine.py M ovirt_hosted_engine_ha/agent/states.py 6 files changed, 137 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9e05c753f41dcd94d5a4734ac39f90581ddc0c0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Separate the state machine into machine, states with logic a...
by msivak＠redhat.com 19 Feb '14

19 Feb '14

Martin Sivák has submitted this change and it was merged. Change subject: Separate the state machine into machine, states with logic and communication ...................................................................... Separate the state machine into machine, states with logic and communication The FSM is designed in such a way that each state is essentially immutable and knows only about the world that was seen when the state was created. When consume is called it uses the remembered info and the new info to determine where to go next and returns a new state instance. This allows us to write unit tests for each state without having to mock anything as all decisions are based only on passed immutable structures. This patch also kills some of the timers we used and replaces them with separate states and universal check_timer decorator. Change-Id: Icad82e819b653cd8b9210d0a71e0312fc6b20134 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M configure.ac M ovirt_hosted_engine_ha/agent/Makefile.am M ovirt_hosted_engine_ha/agent/agent.py M ovirt_hosted_engine_ha/agent/hosted_engine.py A ovirt_hosted_engine_ha/agent/state_data.py A ovirt_hosted_engine_ha/agent/state_decorators.py A ovirt_hosted_engine_ha/agent/state_machine.py A ovirt_hosted_engine_ha/agent/states.py M ovirt_hosted_engine_ha/lib/Makefile.am A ovirt_hosted_engine_ha/lib/fsm/Makefile.am A ovirt_hosted_engine_ha/lib/fsm/__init__.py A ovirt_hosted_engine_ha/lib/fsm/machine.py M ovirt_hosted_engine_ha/lib/metadata.py M ovirt_hosted_engine_ha/lib/util.py 14 files changed, 1,565 insertions(+), 842 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icad82e819b653cd8b9210d0a71e0312fc6b20134 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change existing disk validation CDA message in case of...
by tnisan＠redhat.com 19 Feb '14

19 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Change existing disk validation CDA message in case of null disk alias ...................................................................... core: Change existing disk validation CDA message in case of null disk alias When try to import a VM which one or more of it's disks already exist on the system there's a CDA message containing the disk aliases of the existing disks, the aliases are taken from the disks in the export domian but in case the alias is null (mainly in backups of versions <V3.0, P2V, V2V etc..) the alias was displayed as a blank string, the CDA message was change and in case the alias is null the alias will be taken from the disk in the system Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/928864 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java 2 files changed, 32 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: database: cast port to str
by sbonazzo＠redhat.com 19 Feb '14

19 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: cast port to str ...................................................................... packaging: setup: database: cast port to str old psycopg2 does not accept unicode string as port. python-psycopg2-2.0.14-2.el6.x86_64 TypeError: port must be a string or int *DO NOT* cast to int as usock will not work. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067058 Change-Id: I51476e7a07ae6bf475415329873c96ddea638686 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51476e7a07ae6bf475415329873c96ddea638686 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0