February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: AddDiskCommand - added disk can never be a disk snapshot
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: AddDiskCommand - added disk can never be a disk snapshot ...................................................................... core: AddDiskCommand - added disk can never be a disk snapshot When adding a disk the added disk can never be a disk snapshot, Currently when adding DiskImages the disk's Image object is "active" member has a default value of false, which leads to wrongly treat that disk as a disk snapshot through validations rather than a regular added disk. Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066834 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/24715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: HA Vm reservation check failure event log is not well ...
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: HA Vm reservation check failure event log is not well resolved ...................................................................... core: HA Vm reservation check failure event log is not well resolved Making the event log message more user readable, using the host name and not the toString. Change-Id: I245f8eea3a955bcd8e75c574c572cf2608452d68 Bug-Url: https://bugzilla.redhat.com/1057584 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Kobi Ianko: Verified -- To view, visit http://gerrit.ovirt.org/24658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I245f8eea3a955bcd8e75c574c572cf2608452d68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: database: fix create language
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: fix create language ...................................................................... packaging: setup: database: fix create language condition should compare to 0 and not nothing. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066459 Change-Id: I19248410c43b1916c32a89dd3595a667b035a715 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19248410c43b1916c32a89dd3595a667b035a715 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix allocation policy and storage domain when edit...
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Fix allocation policy and storage domain when editing VM disk ...................................................................... webadmin: Fix allocation policy and storage domain when editing VM disk Edit Vm disk window always displayed disk allocation policy based on the storage type instead of displaying the actual allocation policy of that disk. In case of the storage domain, first domain from the list of available storage domains was displayed instead of the storage domain of that disk. Change-Id: Ifae8052b4e37a7ad7f39eb38081268a7b6bd1a43 Bug-Url: https://bugzilla.redhat.com/1057622 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 3 files changed, 20 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/24686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifae8052b4e37a7ad7f39eb38081268a7b6bd1a43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Only iSCSI storage connections are viable for iSCSI ...
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond ...................................................................... engine: Only iSCSI storage connections are viable for iSCSI Bond iSCSI Bond is the new managed entity introduced in 3.4 in order to configure iSCSI multipathing. This entity is configured based on iSCSI storage connections therefore only connections of that type should be presented to the user when it configures the iSCSI Bond in UI. Change-Id: Iae30db6aa0c5d2989e9e31566d6555d70259799e Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConnectionsByDataCenterAndStorageTypeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/IscsiBondModel.java 6 files changed, 54 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/24682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae30db6aa0c5d2989e9e31566d6555d70259799e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Introduce getConnectableStorageConnectionsByStorageT...
by iheim＠redhat.com 19 Feb '14

19 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Introduce getConnectableStorageConnectionsByStorageType API ...................................................................... engine: Introduce getConnectableStorageConnectionsByStorageType API This API allows to retrieve all connectable storage connections by storage type. If storage type is not specified then this API returns the same result as getAllConnectableStorageSeverConnection - all connectable storage connections. Change-Id: I9cea901ff2707bb4caa52e8f8eff06d533d5ddb6 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M packaging/dbscripts/storages_san_sp.sql 4 files changed, 64 insertions(+), 6 deletions(-) Approvals: Sergey Gotliv: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cea901ff2707bb4caa52e8f8eff06d533d5ddb6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: add template versions support
by ofrenkel＠redhat.com 19 Feb '14

19 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: restapi: add template versions support ...................................................................... restapi: add template versions support Add to templates REST resource a new section that describes template version details. The user will be able to add this in POST (add template), update version name in PUT (update) and see version details in GET requests. Feature page: http://www.ovirt.org/Features/Template_Versions Change-Id: Id8e4c498c4a1856ac341237837db40db8375c6da Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java 6 files changed, 155 insertions(+), 13 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8e4c498c4a1856ac341237837db40db8375c6da Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: RFE: add hostname attribute for windows sysprep
by shavivi＠redhat.com 19 Feb '14

19 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: RFE: add hostname attribute for windows sysprep ...................................................................... Engine: RFE: add hostname attribute for windows sysprep Change-Id: I3284b45f032c9c1ec3c976481351b7e81e66f0f6 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 4 files changed, 42 insertions(+), 9 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3284b45f032c9c1ec3c976481351b7e81e66f0f6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Adding proper database setup
by eedri＠redhat.com 19 Feb '14

19 Feb '14

Eyal Edri has submitted this change and it was merged. Change subject: Adding proper database setup ...................................................................... Adding proper database setup Jobs were failing on database setup when trying to connect to it as the pg_hba file was being removed each time. Change-Id: I1d9daebdb557880a63d8eeca5c838d28d3808b1e Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/ovirt_engine_upgrade_params/update_engine_params.sh 1 file changed, 126 insertions(+), 103 deletions(-) Approvals: Eyal Edri: Looks good to me, approved David Caro: Verified -- To view, visit http://gerrit.ovirt.org/24781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d9daebdb557880a63d8eeca5c838d28d3808b1e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RSDL - Throw Exception For Dir Creation Error
by oliel＠redhat.com 19 Feb '14

19 Feb '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: RSDL - Throw Exception For Dir Creation Error ...................................................................... restapi: RSDL - Throw Exception For Dir Creation Error Change-Id: I9c242d3ca052f6ac596cd69b03eb3f1744ead38e Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlIOManager.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c242d3ca052f6ac596cd69b03eb3f1744ead38e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0