Change in ovirt-engine[master]: frontend: Remove redundant classes from uioverrides
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Remove redundant classes from uioverrides
......................................................................
frontend: Remove redundant classes from uioverrides
Change-Id: I2f3f4cebe5cad4d0c038225ddfe8b2a9b2b38878
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/lang/InterruptedException.java
D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/lang/Thread.java
2 files changed, 0 insertions(+), 74 deletions(-)
Approvals:
Tal Nisan: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f3f4cebe5cad4d0c038225ddfe8b2a9b2b38878
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Fix admin@internal permissions
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix admin@internal permissions
......................................................................
core: Fix admin@internal permissions
Fix permissions for admin@internal user by setting
last_admin_check_status to true. The same is done in
AddPermissionCommand if admin role is assigned to user.
Change-Id: Iacc197cbff33d74cf8f2d7bd1b18c31092fdea43
Bug-Url: https://bugzilla.redhat.com/1057087
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_04_0630_fix_admin_internal_permissions.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24107
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacc197cbff33d74cf8f2d7bd1b18c31092fdea43
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: webadmin: Unite broken lines in AppErrors.properties
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Unite broken lines in AppErrors.properties
......................................................................
webadmin: Unite broken lines in AppErrors.properties
The entry for LABELED_NETWORK_ATTACHED_TO_WRONG_INTERFACE
is split into two lines.
Change-Id: I5d140e1dbe20e7945bc04b85cd9010441c643f6f
Bug-Url: https://bugzilla.redhat.com/1065713
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
2 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d140e1dbe20e7945bc04b85cd9010441c643f6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: core: Permissions of group are not inherited when adding a user
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Permissions of group are not inherited when adding a user
......................................................................
core: Permissions of group are not inherited when adding a user
When adding a user, the group_ids column at the users table
is not modified, so all the related stored procedures that
calculate the permissions do not calculate the correct set of
permissions.
Bug-Url: https://bugzilla.redhat.com/1065615
Change-Id: I47caf474fe9acfce26e6232a51918849d970f4cb
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47caf474fe9acfce26e6232a51918849d970f4cb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in otopi[master]: core: print environment diff based on str conversion
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: print environment diff based on str conversion
......................................................................
core: print environment diff based on str conversion
enable detect complex object modification within environment, such as
lists.
Change-Id: I15969681d8fab57e326a7977a5ed0703d4e9fbd7
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/context.py
1 file changed, 16 insertions(+), 7 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15969681d8fab57e326a7977a5ed0703d4e9fbd7
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 10 months
Change in ovirt-node-plugin-vdsm[master]: engine_page: remove unused import: exceptions
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: engine_page: remove unused import: exceptions
......................................................................
engine_page: remove unused import: exceptions
Change-Id: Ibeb466a5a6dc76ebf6ac1fce1214e73fd9f00fd6
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibeb466a5a6dc76ebf6ac1fce1214e73fd9f00fd6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-node-plugin-vdsm[master]: engine_page: remove unused app from ovirt.node
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: engine_page: remove unused app from ovirt.node
......................................................................
engine_page: remove unused app from ovirt.node
Change-Id: I3963e8ddd64f1d1a3c03f3f5012a0d8aa8b644c2
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3963e8ddd64f1d1a3c03f3f5012a0d8aa8b644c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in gerrit-admin[master]: Changing from wget to curl
by dcaroest@redhat.com
David Caro has submitted this change and it was merged.
Change subject: Changing from wget to curl
......................................................................
Changing from wget to curl
We are having segmentation faults with wget, hoping curl does not have
them. This is an temporary solution until the hooks are migrated to
python code.
Change-Id: I0cf356141f58b394070a540ff4e90bd383f0e9e3
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M hooks/lib/bz.sh
1 file changed, 29 insertions(+), 10 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cf356141f58b394070a540ff4e90bd383f0e9e3
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
10 years, 10 months
Change in ovirt-node-plugin-vdsm[master]: engine_page: use vdsm to detect mgmt interface
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: engine_page: use vdsm to detect mgmt interface
......................................................................
engine_page: use vdsm to detect mgmt interface
Replace the method to detect the mgmt interface by VDSM.
Change-Id: I9e1b69c0f465f1e38779e451777cae67bd4cde40
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058257
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 11 insertions(+), 7 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Antoni Segura Puimedon: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e1b69c0f465f1e38779e451777cae67bd4cde40
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin, userportal: Use X-UA-Compatible with IE=10
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin,userportal: Use X-UA-Compatible with IE=10
......................................................................
webadmin,userportal: Use X-UA-Compatible with IE=10
This patch is meant to address problems when loading
GWT applications in Internet Explorer 11.
IE11 user agent string is missing the "MSIE" part but
instead includes the "like Gecko" part. For example:
Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko
This causes GWT selector script (*.nocache.js) to pick
and load Firefox (Gecko) permutation of GWT application.
Since IE11 has issues with Gecko permutation [1], the
workaround is to tell IE11 to render page as IE10:
<meta http-equiv="X-UA-Compatible" content="IE=10">
[1] http://code.google.com/p/google-web-toolkit/issues/detail?id=8228
This shouldn't affect behavior of GWT applications
when loaded in earlier Internet Explorer versions:
- IE8: selector script uses 'ie8' permutation
- IE9: selector script uses 'ie9' permutation
- IE10: selector script uses highest available
permutation ('ie9')
Note: there might be issues with IE10 + 'ie9' GWT
permutation combination. These issues should be
addressed as part of GWT upgrade which should add
proper support (permutation) for IE10.
Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04
Bug-Url: https://bugzilla.redhat.com/1062716
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit http://gerrit.ovirt.org/24211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months