February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: remove: first remove files, then content
by iheim＠redhat.com 14 Feb '14

14 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: remove: first remove files, then content ...................................................................... packaging: setup: remove: first remove files, then content remove is stronger than content. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058018 Change-Id: Ibc4cc0c126dcc214ebaddd1bbdb2e86b7db4f5a8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc4cc0c126dcc214ebaddd1bbdb2e86b7db4f5a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: remove: do not touch file if not changed
by iheim＠redhat.com 14 Feb '14

14 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: remove: do not touch file if not changed ...................................................................... packaging: setup: remove: do not touch file if not changed Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058018 Change-Id: I6c2fa5c514984512bc817323e026e56c9bdb9d44 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c2fa5c514984512bc817323e026e56c9bdb9d44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: database: support ':' within password
by iheim＠redhat.com 14 Feb '14

14 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: support ':' within password ...................................................................... packaging: setup: database: support ':' within password at least in rhel postgresql 8.4 the pgpassfile is not read according to documentation, the password is read as plain, postgresql 9 seems to respect the documentation. this behavior is handled by client side postgresql libraries, the simplest way to detect what library we use is to query psql utility version. [1] http://www.postgresql.org/docs/8.4/static/libpq-pgpass.html Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064428 Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-backup.sh M packaging/setup/plugins/ovirt-engine-common/db/pgpass.py M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py 3 files changed, 84 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved James W. Mills: Verified; Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: James W. Mills <jamills(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: database: support ':' within password
by iheim＠redhat.com 14 Feb '14

14 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: support ':' within password ...................................................................... packaging: setup: database: support ':' within password at least in rhel postgresql 8.4 the pgpassfile is not read according to documentation, the password is read as plain, postgresql 9 seems to respect the documentation. this behavior is handled by client side postgresql libraries, the simplest way to detect what library we use is to query psql utility version. [1] http://www.postgresql.org/docs/8.4/static/libpq-pgpass.html Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064428 Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-backup.sh M packaging/setup/ovirt_engine_setup/database.py 2 files changed, 43 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: typo: added a missing colon
by tjelinek＠redhat.com 14 Feb '14

14 Feb '14

Tomas Jelinek has submitted this change and it was merged. Change subject: typo: added a missing colon ...................................................................... typo: added a missing colon Added the colon after the "User" in the roleOnUser to make it consistent with the userWithRole. Change-Id: Ie9f274cc5ba4c8d85c95ef37cee207c0bc04aa5b Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f274cc5ba4c8d85c95ef37cee207c0bc04aa5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: remove: first remove files, then content
by sbonazzo＠redhat.com 14 Feb '14

14 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: remove: first remove files, then content ...................................................................... packaging: setup: remove: first remove files, then content remove is stronger than content. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058018 Change-Id: Ibc4cc0c126dcc214ebaddd1bbdb2e86b7db4f5a8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc4cc0c126dcc214ebaddd1bbdb2e86b7db4f5a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: remove: do not touch file if not changed
by sbonazzo＠redhat.com 14 Feb '14

14 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: remove: do not touch file if not changed ...................................................................... packaging: setup: remove: do not touch file if not changed Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058018 Change-Id: I6c2fa5c514984512bc817323e026e56c9bdb9d44 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c2fa5c514984512bc817323e026e56c9bdb9d44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fix permissions for users added by engine-manage-domains
by yzaslavs＠redhat.com 14 Feb '14

14 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fix permissions for users added by engine-manage-domains ...................................................................... tools: Fix permissions for users added by engine-manage-domains Fix permissions for users added by engine-manage-domains by setting last_admin_check_status to true. The same is done in AddPermissionCommand if admin role is assigned to user. Change-Id: Id7565f00d26cf641efd82aa5508deece9f4ee7cf Bug-Url: https://bugzilla.redhat.com/1057087 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7565f00d26cf641efd82aa5508deece9f4ee7cf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: order imports
by dougsland＠redhat.com 13 Feb '14

13 Feb '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: order imports ...................................................................... engine_page: order imports Following http://www.python.org/dev/peps/pep-0008/#imports Change-Id: I019e73fb0c940312a73521177870db4277049cce Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Joey Boggs: Looks good to me, but someone else must approve Ryan Barry: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I019e73fb0c940312a73521177870db4277049cce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: moved postgres driver setup to patches
by ydary＠redhat.com 13 Feb '14

13 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: moved postgres driver setup to patches ...................................................................... packaging: setup: moved postgres driver setup to patches Change-Id: I3879c7ebe13d216765c2daa72770c0ec5a041f7c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A packaging/jasper-war-patches/100_002_meta-inf_remove_pgsql_jar_from_exclude.patch A packaging/jasper-war-patches/200_004_web-inf_add_pgsql_driver_to_datasources.patch M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 3 files changed, 22 insertions(+), 36 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3879c7ebe13d216765c2daa72770c0ec5a041f7c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0