February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add a validation when deactivate ISO domain.
by mlipchuk＠redhat.com 13 Feb '14

13 Feb '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add a validation when deactivate ISO domain. ...................................................................... core: Add a validation when deactivate ISO domain. Adding a CDA when deactivating an ISO storage domain if there are VMs with an ISO file attached to them and are not down. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 105 insertions(+), 11 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Add support for adding and plugging disk to a runni...
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Add support for adding and plugging disk to a running VM ...................................................................... restapi: Add support for adding and plugging disk to a running VM Change-Id: I4fd08ceeaba6cef75606f774188e575f82f14948 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Related-to: https://bugzilla.redhat.com/856272 --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fd08ceeaba6cef75606f774188e575f82f14948 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: database: support ':' within password
by sbonazzo＠redhat.com 13 Feb '14

13 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: support ':' within password ...................................................................... packaging: setup: database: support ':' within password at least in rhel postgresql 8.4 the pgpassfile is not read according to documentation, the password is read as plain, postgresql 9 seems to respect the documentation. this behavior is handled by client side postgresql libraries, the simplest way to detect what library we use is to query psql utility version. [1] http://www.postgresql.org/docs/8.4/static/libpq-pgpass.html Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064428 Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-backup.sh M packaging/setup/ovirt_engine_setup/database.py 2 files changed, 43 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core: adding ovirt glance repository"
by oourfali＠redhat.com 13 Feb '14

13 Feb '14

Oved Ourfali has submitted this change and it was merged. Change subject: Revert "core: adding ovirt glance repository" ...................................................................... Revert "core: adding ovirt glance repository" This reverts commit 4da97ac9dbed693ea1048c8a84b540f1a3650568. Change-Id: I344bcb927a1eff830c073ded319762acf3e43473 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- D packaging/dbscripts/upgrade/03_04_0630_add_public_glance_repository.sql 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I344bcb927a1eff830c073ded319762acf3e43473 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: add info tooltip for Cloud-Init custom script
by shavivi＠redhat.com 13 Feb '14

13 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: UI: add info tooltip for Cloud-Init custom script ...................................................................... UI: add info tooltip for Cloud-Init custom script Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: Id3990c7ccc646f3c9653993a36c3b1c5668a453f Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml 3 files changed, 23 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3990c7ccc646f3c9653993a36c3b1c5668a453f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: NPE when trying to run Windows with no Domain
by shavivi＠redhat.com 13 Feb '14

13 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: NPE when trying to run Windows with no Domain ...................................................................... engine: NPE when trying to run Windows with no Domain Change-Id: I897a372ebe8cc7575b2a3824cad7accfbc1874e3 Bug-Url:https://bugzilla.redhat.com/1063883 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I897a372ebe8cc7575b2a3824cad7accfbc1874e3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: UI: Prevent dialog close when pressing Enter in TextArea
by shavivi＠redhat.com 13 Feb '14

13 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: UI: Prevent dialog close when pressing Enter in TextArea ...................................................................... UI: Prevent dialog close when pressing Enter in TextArea By default add/edit VM dialog close when pressing Enter (for fast navigation), This is a problem while edition TextArea when the enter key is used. Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: I436d4ab656d2739a9681a6b3d2f80038eb0c2063 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextAreaEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextAreaEditor.java 3 files changed, 90 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I436d4ab656d2739a9681a6b3d2f80038eb0c2063 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: CloudInit custom script section
by shavivi＠redhat.com 13 Feb '14

13 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: CloudInit custom script section ...................................................................... engine: CloudInit custom script section Custom Script: User can add arbitrary CloudInit section in additional to the defaults (such as hostname, timezone etc) User can add files and other non supported sections. This will add two new files: write_files: - content: | # some file content path: /root/myfile - encoding: b64 content: CiMgVGhpcyBmaWxlIGNvbnRyb2xzIHRoZSBzdGF0ZSBvZiBTRUxpbnV4... owner: root:root path: /etc/sysconfig/selinux permissions: '0644' Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: Ibbe4107401cc5add22a519f6a18bad96f1055615 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbe4107401cc5add22a519f6a18bad96f1055615 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: UI: set the default initial run to false in RunOnce dialog
by shavivi＠redhat.com 13 Feb '14

13 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: UI: set the default initial run to false in RunOnce dialog ...................................................................... UI: set the default initial run to false in RunOnce dialog We change the default to false only if the is_initialized flag is true (ie the user already run/initialize the VM), Assuming that the user don't want to re-initialize the VM again. Change-Id: I2ac2eeee70d1fb4db2712b5407ee3e778e7293c1 Bug-Url: https://bugzilla.redhat.com/1051041 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ac2eeee70d1fb4db2712b5407ee3e778e7293c1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Allow changing a VM disk alias when the VM is not ...
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Allow changing a VM disk alias when the VM is not down ...................................................................... webadmin: Allow changing a VM disk alias when the VM is not down Change-Id: I4c5bd598986b7bdbc96893948dd22592c4c05908 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-url: https://bugzilla.redhat.com/1064877 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 2 files changed, 3 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c5bd598986b7bdbc96893948dd22592c4c05908 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0