February 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: VmInit root-password not fetch from DB

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: engine: VmInit root-password not fetch from DB ...................................................................... engine: VmInit root-password not fetch from DB By default we don't fetch the password when getting VmInit for security reasons (we don't want to display the password in plain text via API or in the source code of the UI). For this reason the password was not copy when creating a Template, New Pool. Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: I9206906e3b61551023b21e4358663a4842018c7c Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 3 files changed, 28 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9206906e3b61551023b21e4358663a4842018c7c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: UI: add indication the VMInit root password is set

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: UI: add indication the VMInit root password is set ...................................................................... UI: add indication the VMInit root password is set Since we are not returning the password on edit VM, we need to let the user know that the password is set. Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: Iedfea8520e885c948772dd0d1b612296aeced895 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 6 files changed, 85 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfea8520e885c948772dd0d1b612296aeced895 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: command: allow --help and --version as unprivileged user

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: command: allow --help and --version as unprivileged user ...................................................................... command: allow --help and --version as unprivileged user Change-Id: I79d48d69409494156799ef5a2bd8965ef000e3b5 Bug-Url: https://bugzilla.redhat.com/1059654 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d48d69409494156799ef5a2bd8965ef000e3b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-log-collector[master]: command: allow --help and --version as unprivileged user

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: command: allow --help and --version as unprivileged user ...................................................................... command: allow --help and --version as unprivileged user Change-Id: I79d48d69409494156799ef5a2bd8965ef000e3b5 Bug-Url: https://bugzilla.redhat.com/1059654 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d48d69409494156799ef5a2bd8965ef000e3b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in gerrit-admin[master]: Bugzilla change a bit the format of the bug xml

by dcaroest＠redhat.com

David Caro has submitted this change and it was merged. Change subject: Bugzilla change a bit the format of the bug xml ...................................................................... Bugzilla change a bit the format of the bug xml It mage the hooks fail to detect if a bug was private. Change-Id: I0df9e821f45c848c664c1bbd90416525c01a926d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/lib/bz.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0df9e821f45c848c664c1bbd90416525c01a926d Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in gerrit-admin[master]: Fixed bug when detecting open patches

by dcaroest＠redhat.com

David Caro has submitted this change and it was merged. Change subject: Fixed bug when detecting open patches ...................................................................... Fixed bug when detecting open patches Also improved the logging a bit Change-Id: I197470c60e1d7a0270361d554afa9d38e75bcbc9 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/bz/patchset-created.warn_if_not_merged_to_previous_branch 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I197470c60e1d7a0270361d554afa9d38e75bcbc9 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-reports[master]: packaging: moved log location change to patch

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: moved log location change to patch ...................................................................... packaging: moved log location change to patch This is instead of overwriting the whole file, just for this change. Change-Id: Id52f44264db2e69a83d696af1748b010b950f17d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M .gitignore M Makefile D packaging/jasper-customizations/WEB-INF/log4j.properties.in A packaging/jasper-war-patches/900_004_props_change_logs_location.patch.in 4 files changed, 22 insertions(+), 141 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id52f44264db2e69a83d696af1748b010b950f17d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Change backward compatibility logic for add/update vnic

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: engine: Change backward compatibility logic for add/update vnic ...................................................................... engine: Change backward compatibility logic for add/update vnic The current backward compatibility logic designed for resolving a vnic profile id for a given network should be modified, since REST clients which provides both network name and vnic profile id might face issues, such ignoring the vnic profile id. For that purpose the engine will attempt to find a change in the network name provided by the user to what is already configured on the vnic: 1. If network name is provided, and unchanged - the vnic profile id from the parameters is used. 2. If the network name is provided and changed, use it instead of the vnic profile id. Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Bug-Url: https://bugzilla.redhat.com/1064823 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java 5 files changed, 55 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Persist comment in AddVmTemplateCommand

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Persist comment in AddVmTemplateCommand ...................................................................... engine: Persist comment in AddVmTemplateCommand AddVmTemplateCommand did not map comment field from given VM to newly created template. Also added corresponding mapping to frontend CommonUnitToVmBaseBuilder. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013670 Change-Id: I5ef17d46b067036063865fbb0e64d266493132cb Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CommonUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/FullUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/pools/BaseVmListModelTest.java 5 files changed, 7 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/24117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ef17d46b067036063865fbb0e64d266493132cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: adding ovirt glance repository

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: adding ovirt glance repository ...................................................................... core: adding ovirt glance repository We recently added a public Glance repository in glance.ovirt.org This patch adds it as a provider + storage domain, to be used by default in oVirt installations. Change-Id: I66215abe4c68e2a7ffe919124745be6136f8f550 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0630_add_public_glance_repository.sql 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66215abe4c68e2a7ffe919124745be6136f8f550 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

10 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2014