Change in ovirt-engine[master]: core, restapi: provide capabillity to get vm ovf config
by laravot@redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core, restapi: provide capabillity to get vm ovf config
......................................................................
core, restapi: provide capabillity to get vm ovf config
This patch adds the capabllity to get the current vm configuration (if
possible) through the ovirt rest-api.
The usage is done through a GET request to /api/vms or /api/vms/GUID/
with All-Content header with 'true' as the value.
If the VM OVF configuration couldn't be generated succesfully (if the vm
is currentky locked for example), the configuration won't be returned as
part of the result.
Change-Id: I5cbcd666519ffd138fd3efd4e130495529eaec0f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047965
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmOvfByVmIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmOvfByVmIdQueryTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmOvfByVmIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
11 files changed, 287 insertions(+), 5 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cbcd666519ffd138fd3efd4e130495529eaec0f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Make sure disk alias will never be null
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Make sure disk alias will never be null
......................................................................
core: Make sure disk alias will never be null
In case of running a VM with disks imported from version lower than V3.0
OVFs or from P2V/V2V, the disk aliases created can be null, when the
CreateVmVdsCommand is running it sorts the disks by the aliases yet the
comparator does not check if one of the aliases is null and fails on an
NPE, this patch fixes this issue by making sure that the disk alias
property will never be null
Change-Id: I110f40b121a0bff8117888399fd5b798a9f19c10
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-url: https://bugzilla.redhat.com/1059403
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Liron Ar: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I110f40b121a0bff8117888399fd5b798a9f19c10
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Allow changing a VM disk alias when the VM is not ...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Allow changing a VM disk alias when the VM is not down
......................................................................
webadmin: Allow changing a VM disk alias when the VM is not down
Change-Id: I4c5bd598986b7bdbc96893948dd22592c4c05908
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c5bd598986b7bdbc96893948dd22592c4c05908
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Allow alignment scan on multiple disks of the same VM
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Allow alignment scan on multiple disks of the same VM
......................................................................
webadmin: Allow alignment scan on multiple disks of the same VM
Change-Id: I6a430fc790979b7d6237511dd4c7adbffb1ab9eb
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-url: https://bugzilla.redhat.com/1006439
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 14 insertions(+), 51 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a430fc790979b7d6237511dd4c7adbffb1ab9eb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: rename MigrateVmCommand#getVdsDestination
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: rename MigrateVmCommand#getVdsDestination
......................................................................
core: rename MigrateVmCommand#getVdsDestination
MigrateVmCommand#getVdsDestination used to return the name of the
destination VDS for audit log messages. Its name was confusing as we
already have method called getDestinationVds in MigrateVmCommand and it
didn't reflect the purpose of this method well. Thus it is renamed to
getDestinationVdsName.
Change-Id: Iab5e534d298bd99bb6b2692d58c378effae3760f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
2 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab5e534d298bd99bb6b2692d58c378effae3760f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: move the validation of active iso domain on run vm
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: move the validation of active iso domain on run vm
......................................................................
core: move the validation of active iso domain on run vm
The validation which checks that there is an active ISO domain when the
VM is configured with 'iso path' was located in RunVmCommand, while it
should be located in RunVmValidator. Besides moving that validation to
the RunVmValidator class, a minor improvement is introduced: instead of
searching the id of the active ISO domain each time we need it (and
we're planning to use it more soon), it is now cached for the lifetime
of the RunVm command.
Change-Id: Ic1bc81686be01088aa2dde5c61e4b83c96643f73
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
4 files changed, 48 insertions(+), 56 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/21206
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1bc81686be01088aa2dde5c61e4b83c96643f73
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-reports[master]: reports: added a single folder to save reports during upgrade
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: added a single folder to save reports during upgrade
......................................................................
reports: added a single folder to save reports during upgrade
Change-Id: I04cdc6cbffa547d10a69ba2540e4409acb52e961
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M packaging/ovirt-reports/resources/.folder.xml
A packaging/ovirt-reports/resources/saved_reports/.folder.xml
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
3 files changed, 31 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24394
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04cdc6cbffa547d10a69ba2540e4409acb52e961
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 10 months
Change in ovirt-reports[master]: packaging: setup: made export of only the dwh datasource
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: made export of only the dwh datasource
......................................................................
packaging: setup: made export of only the dwh datasource
Change-Id: I352d0494a6eb82789d1f2bcea52df160e8a94f21
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24400
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I352d0494a6eb82789d1f2bcea52df160e8a94f21
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: core: cleanup in RunVmParams
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: cleanup in RunVmParams
......................................................................
core: cleanup in RunVmParams
1. Rename methods & fields that had '_' in the middle of their name
to the standard convention in Java
2. Remove the '_' and "private" prefixes from several class fields
3. Remove unused and redundant constructors
Change-Id: Iebc0d1a33b991e444f0639978bb08ccd5eade350
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
6 files changed, 64 insertions(+), 92 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22222
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebc0d1a33b991e444f0639978bb08ccd5eade350
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: restapi : Handle empty int values in JAX-B parser
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi : Handle empty int values in JAX-B parser
......................................................................
restapi : Handle empty int values in JAX-B parser
JAX-B replacement IntegerParser should handle empty
values for integer fields. Set the default value to 0.
Change-Id: I3823d8894f316d78f753034fdbd89a79f480516e
Bug-Url: https://bugzilla.redhat.com/1064456
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24401
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3823d8894f316d78f753034fdbd89a79f480516e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months