February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: refactor failure to run vm flow - part 5
by ofrenkel＠redhat.com 12 Feb '14

12 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 5 ...................................................................... core: refactor failure to run vm flow - part 5 This patch is a preliminary step before removing MigrateVmCommand#reportCompleted: - Move the call to freeLock to RunVmCommandBase#reportCompleted - Extract the code that actually ends the command's monitoring job/step to separate method. RunVmCommand & RunVmOnceCommand used to override RunVmCommandBase#reportCompleted just to change the way the job/step is ended, so they are now override the new method instead. Change-Id: Ib02c6a37333785845e6e8246b1a8f4c326e9049d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 4 files changed, 29 insertions(+), 23 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib02c6a37333785845e6e8246b1a8f4c326e9049d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: changed admin user name to non-branded
by ydary＠redhat.com 12 Feb '14

12 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: changed admin user name to non-branded ...................................................................... reports: changed admin user name to non-branded Change-Id: I513e5d80a933316562828926cbda791b46fe1b0b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/jasper-war-patches/300_001_jsp_change-login-help-info.patch M packaging/ovirt-reports/index.xml A packaging/ovirt-reports/users/admin.xml D packaging/ovirt-reports/users/ovirt-002dadmin.xml M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/admin.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 6 files changed, 20 insertions(+), 16 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I513e5d80a933316562828926cbda791b46fe1b0b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make sure disk alias will never be null
by tnisan＠redhat.com 12 Feb '14

12 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Make sure disk alias will never be null ...................................................................... core: Make sure disk alias will never be null In case of running a VM with disks imported from version lower than V3.0 OVFs or from P2V/V2V, the disk aliases created can be null, when the CreateVmVdsCommand is running it sorts the disks by the aliases yet the comparator does not check if one of the aliases is null and fails on an NPE, this patch fixes this issue by making sure that the disk alias property will never be null Change-Id: I110f40b121a0bff8117888399fd5b798a9f19c10 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-url: https://bugzilla.redhat.com/1059403 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I110f40b121a0bff8117888399fd5b798a9f19c10 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: services: sysv: fix metadata
by iheim＠redhat.com 12 Feb '14

12 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: services: sysv: fix metadata ...................................................................... packaging: services: sysv: fix metadata Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063860 Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: spec: register/unregister sysv daemons
by iheim＠redhat.com 12 Feb '14

12 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: register/unregister sysv daemons ...................................................................... packaging: spec: register/unregister sysv daemons Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063873 Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: timestamp tarball and rpms from master
by sbonazzo＠redhat.com 12 Feb '14

12 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: timestamp tarball and rpms from master ...................................................................... packaging: timestamp tarball and rpms from master Change-Id: I941b925ee4419700a930c3b6f1b47f5b6e935828 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I941b925ee4419700a930c3b6f1b47f5b6e935828 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: fix broken autopoint.
by sbonazzo＠redhat.com 12 Feb '14

12 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: fix broken autopoint. ...................................................................... packaging: fix broken autopoint. Change-Id: I994b551184c870572e0ca14a13137bd1b6af6d5d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994b551184c870572e0ca14a13137bd1b6af6d5d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: disable DocsServletTest
by awels＠redhat.com 12 Feb '14

12 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: disable DocsServletTest ...................................................................... engine: disable DocsServletTest - Disabled DocsServletTest as it caused intermittent issues for automated testing. Change-Id: I2be8811ec3d3daf680b9209671cdce6638fb36c7 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/DocsServletTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2be8811ec3d3daf680b9209671cdce6638fb36c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: services: sysv: fix metadata
by iheim＠redhat.com 12 Feb '14

12 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: services: sysv: fix metadata ...................................................................... packaging: services: sysv: fix metadata Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063860 Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: register/unregister sysv daemons
by iheim＠redhat.com 12 Feb '14

12 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: register/unregister sysv daemons ...................................................................... packaging: spec: register/unregister sysv daemons Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063873 Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0