Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix useDnsLookup behavior
......................................................................
core: fix useDnsLookup behavior
This patch fixes the usage of "useDnsLookup" flag
at engine-manage-domains configuration.
only When --ldap-servers is used, this flag should be ignored if set to true.
Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b
Bug-Url: https://bugzilla.redhat.com/1063286
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: packaging: services: sysv: fix metadata
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: services: sysv: fix metadata
......................................................................
packaging: services: sysv: fix metadata
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063860
Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in
M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in
2 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: packaging: spec: register/unregister sysv daemons
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: register/unregister sysv daemons
......................................................................
packaging: spec: register/unregister sysv daemons
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063873
Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: packaging: spec: remove 3.2 upgrade workarounds
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: remove 3.2 upgrade workarounds
......................................................................
packaging: spec: remove 3.2 upgrade workarounds
Change-Id: I531f196045cf72e7e3651a6076b11fc18ade86a9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 0 insertions(+), 20 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I531f196045cf72e7e3651a6076b11fc18ade86a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: engine: Log unsupported network update
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Log unsupported network update
......................................................................
engine: Log unsupported network update
When hosts need to be updated on an unsupporting data center, an audit
log will be sent that specifies that the automatic update will not be
happening.
As specified in:
http://www.ovirt.org/Features/MultiHostNetworkConfiguration#Events
Change-Id: I9b37fbdec5134b3131c1cafb1cd9e0596c2efb74
Bug-Url: https://bugzilla.redhat.com/1055161
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 14 insertions(+), 7 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b37fbdec5134b3131c1cafb1cd9e0596c2efb74
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: gluster: fix releasing lock in task sync-job
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: fix releasing lock in task sync-job
......................................................................
gluster: fix releasing lock in task sync-job
When a remove-brick start is CLI and
engine detects it and creates a job for it.
A lock is acquired for the volume, and released.
Now the lock won't be released, the same will be
released when the task is completed.
Change-Id: Ib1934bfa976456949a475f6675866bbd083185f4
Bug-Url: https://bugzilla.redhat.com/1061677
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Kanagaraj M: Verified
Sahina Bose: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1934bfa976456949a475f6675866bbd083185f4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: tools: Adds more argument validations to engine-manage-domains
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Adds more argument validations to engine-manage-domains
......................................................................
tools: Adds more argument validations to engine-manage-domains
Checks that all entered arguments are valid for specified action
(previous behavior was to ignore args that have no meaning for specified
action).
Change-Id: I7684387b62ce8eeda0416e4d2b3cfb2337cd7f16
Bug-Url: https://bugzilla.redhat.com/1057172
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java
1 file changed, 53 insertions(+), 36 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24339
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7684387b62ce8eeda0416e4d2b3cfb2337cd7f16
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Change backward compatibility logic for add/update vnic
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Change backward compatibility logic for add/update vnic
......................................................................
engine: Change backward compatibility logic for add/update vnic
The current backward compatibility logic designed for
resolving a vnic profile id for a given network should
be modified, since REST clients which provides both
network name and vnic profile id might face issues, such
ignoring the vnic profile id.
For that purpose the engine will attempt to find a change
in the network name provided by the user to what is already
configured on the vnic:
1. If network name is provided, and unchanged - the vnic
profile id from the parameters is used.
2. If the network name is provided and changed, use it
instead of the vnic profile id.
Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75
Bug-Url: https://bugzilla.redhat.com/1047887
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java
5 files changed, 55 insertions(+), 11 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: restapi: Fix group search and add
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: Fix group search and add
......................................................................
restapi: Fix group search and add
The RESTAPI doesn't currently accept group names with the format
domain/organization/group. This patch fixes that.
Change-Id: Iffb4ba829d5e07b46c0bb6d71e46bdbdbcb2442c
Bug-Url: https://bugzilla.redhat.com/1057214
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 1d1d67629052022c0c8e8958dc2e0d04977569c5)
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DirectoryGroupSearchQueryTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java
4 files changed, 16 insertions(+), 8 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffb4ba829d5e07b46c0bb6d71e46bdbdbcb2442c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in otopi[otopi-1.1]: core: miniyum: return group id and not group name
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: miniyum: return group id and not group name
......................................................................
core: miniyum: return group id and not group name
group name returns a description, while groupid returns the group name.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063941
Change-Id: I6b1b1386c76a6649fa40fa9571755b64f47bb448
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/otopi/miniyum.py
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b1b1386c76a6649fa40fa9571755b64f47bb448
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.1
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 10 months