February 2014 - Engine-commits - oVirt List Archives

Change in otopi[master]: core: miniyum: return group id and not group name
by Alon Bar-Lev 11 Feb '14

11 Feb '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: miniyum: return group id and not group name ...................................................................... core: miniyum: return group id and not group name group name returns a description, while groupid returns the group name. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063941 Change-Id: I6b1b1386c76a6649fa40fa9571755b64f47bb448 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/miniyum.py 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b1b1386c76a6649fa40fa9571755b64f47bb448 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add method to determine if StorageDomainType is of typ...
by tnisan＠redhat.com 11 Feb '14

11 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add method to determine if StorageDomainType is of type ISO or Export ...................................................................... core: Add method to determine if StorageDomainType is of type ISO or Export The checks if a storage domain is of ISO/Export or Data/Master repeats itself throughout the code base, there is already a method on the StorageDomainType enum to determine if the type is Data/Master, added another method to determine if the type is ISO/Export and replaced the checks for each combination with the respected method Change-Id: I8d10d0eca9127b3e0e6fbf89484301e61bf233b2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java 15 files changed, 23 insertions(+), 42 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d10d0eca9127b3e0e6fbf89484301e61bf233b2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: refactor failure to run vm flow - part 4
by ofrenkel＠redhat.com 11 Feb '14

11 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 4 ...................................................................... core: refactor failure to run vm flow - part 4 Remove MigrateVmCommand#failedToMigrate which was confusing now that we have MigrateVmCommand#runningFailed method. In addition MigrateVmCommand#runningSucceeded is removed. For the changes above, the calls to CommandBase#freeLock was moved to the relevant places in RunVmCommandBase, which are better places for them as they are relevant to all command that extend RunVmCommandBase. Note that the freeLock method handle the case where the lock is null, so it is ok in case the command release the lock at the end of the execute method as well. Change-Id: I42cefc4c5f7974730a2b38f63f310ab975f73622 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 3 files changed, 47 insertions(+), 53 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42cefc4c5f7974730a2b38f63f310ab975f73622 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Make VM disks editable
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Make VM disks editable ...................................................................... core: Make VM disks editable When a VM is updated the data from the database is compared to the updated VM object provided by the caller. But the VM object loaded from the database doesn't contain the list of disks, so if the caller provides an VM object that contains the list of disks the UpdateVM command will wrongly assume that the caller is trying to modify this list. To avoid this issue this patch marks the list of disks as editable, so that the UpdateVM command will ignore it. Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600 Bug-Url: https://bugzilla.redhat.com/1059713 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix group search and add
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix group search and add ...................................................................... restapi: Fix group search and add The RESTAPI doesn't currently accept group names with the format domain/organization/group. This patch fixes that. Change-Id: Iffb4ba829d5e07b46c0bb6d71e46bdbdbcb2442c Bug-Url: https://bugzilla.redhat.com/1057214 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DirectoryGroupSearchQueryTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java 4 files changed, 16 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb4ba829d5e07b46c0bb6d71e46bdbdbcb2442c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: improve audit log when creating diskless template
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: improve audit log when creating diskless template ...................................................................... core: improve audit log when creating diskless template Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 17 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/24307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Assure network existence when adding a vnic profile
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Assure network existence when adding a vnic profile ...................................................................... restapi: Assure network existence when adding a vnic profile In order to create a vnic profile, the user must provide the network id to which he wishes to add the profile. If a network cannot be obtained by the id, the parameters should consider invalid and a proper message should be returned. The backend has logic for this scenario, however when performing this action with a user that its permissions should be verified, there is a generic "User is not authorized to perform this action" even though the message refers to a non-existing network entity. Change-Id: Ib517cc0fd04c4f0e12fd6bdbdca8c6277600e325 Bug-Url: https://bugzilla.redhat.com/1031369 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResourceTest.java 3 files changed, 23 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib517cc0fd04c4f0e12fd6bdbdca8c6277600e325 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: When ActivateVDS fails, move VDS out of Unassigned status
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: When ActivateVDS fails, move VDS out of Unassigned status ...................................................................... core: When ActivateVDS fails, move VDS out of Unassigned status If ActivateVDS command fails, in some rare scenarios the VDS will be stuck on Unassigned status, locking any ability to remove/activate the VDS. This patch will move failed VDS to Error status. Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Bug-Url: https://bugzilla.redhat.com/962180 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Don't duplicate directory name in the DB
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Don't duplicate directory name in the DB ...................................................................... core: Don't duplicate directory name in the DB Currently in the "users" table we store the directory name in the "domain" column and also, as a suffix added to the user name, in the in the "username" column. This duplication causes confusion, and makes the SQL schema a bit more non normalized. This patch removes that duplication and changes the places that need to display the directory name (GUI and RESTAPI) so that it is done explicitly. Bug-Url: https://bugzilla.redhat.com/1055881 Bug-Url: https://bugzilla.redhat.com/1059258 Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FormatUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java M packaging/dbscripts/common_sp.sql M packaging/dbscripts/create_functions.sql A packaging/dbscripts/upgrade/03_04_0620_remove_directory_suffix_from_login_name.sql 11 files changed, 98 insertions(+), 38 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: SDValidator - fix message for locked SD
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: SDValidator - fix message for locked SD ...................................................................... core: SDValidator - fix message for locked SD StorageDomainValidator -> isDomainExistAndActive: if the storage domain is not in status Active, the following canDo message should be returned: "The relevant Storage Domain's status is ${status}" Change-Id: I329d974710faa0437fe657c7e650aebb39960960 Bug-Url: https://bugzilla.redhat.com/1060516 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 5 files changed, 7 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329d974710faa0437fe657c7e650aebb39960960 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0