Change in ovirt-engine[master]: db: cleanup: removing obsolete scripts
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: cleanup: removing obsolete scripts
......................................................................
db: cleanup: removing obsolete scripts
backup.sh and restore.sh are obsolete.
engine-backup should be used for backup and restore.
create_db.sh is not used since 3.3.
encryptionvalidator.sh is not used since 3.3.
exportDbSchema.sh is not used.
*_schema_checksum.sh are not used.
Change-Id: I4133c2f442bef91bebb427b7acac34cad278f396
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
R build/dbscripts-duplicate_upgrade_scripts.sh
D build/dbscripts/calc_db_schema_checksum.sh
D build/dbscripts/check_db_schema_checksum.sh
D build/dbscripts/store_db_schema_checksum.sh
D packaging/dbscripts/backup.sh
D packaging/dbscripts/create_db.sh
D packaging/dbscripts/encryptionvalidator.sh
D packaging/dbscripts/exportDbSchema.sh
D packaging/dbscripts/restore.sh
10 files changed, 2 insertions(+), 611 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4133c2f442bef91bebb427b7acac34cad278f396
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[master]: packaging: setup: db: remove unused engine certificate env
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: packaging: setup: db: remove unused engine certificate env
......................................................................
packaging: setup: db: remove unused engine certificate env
since 3.3 it is not used.
Change-Id: I08387adefb347ee362026e3b9d99e2cefde563bc
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08387adefb347ee362026e3b9d99e2cefde563bc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[master]: db: remove drop_old_uuid_functions
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: remove drop_old_uuid_functions
......................................................................
db: remove drop_old_uuid_functions
no need for this since 3.3, only function that uses postgres user.
Change-Id: I8c6f128785fb63f275587aec74e51c266c20931e
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/dbscripts/create_schema.sh
M packaging/dbscripts/dbfunctions.sh
D packaging/dbscripts/drop_old_uuid_functions.sql
3 files changed, 0 insertions(+), 41 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c6f128785fb63f275587aec74e51c266c20931e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[master]: db: functions: remove unused pg_version
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: functions: remove unused pg_version
......................................................................
db: functions: remove unused pg_version
more than it is unused it checks only for client side libraries version,
which is incorrect.
Change-Id: I5ee352658a00ab7efd935060b002bce96875eda1
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/dbscripts/dbfunctions.sh
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ee352658a00ab7efd935060b002bce96875eda1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[master]: doc: README.developer: add notes per comments
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: doc: README.developer: add notes per comments
......................................................................
doc: README.developer: add notes per comments
Change-Id: Iff82d0fe1a813c0d4abee92ba6f1c216a3231652
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M README.developer
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff82d0fe1a813c0d4abee92ba6f1c216a3231652
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in otopi[master]: core: miniyum: fix http range error when yum cache exists
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: miniyum: fix http range error when yum cache exists
......................................................................
core: miniyum: fix http range error when yum cache exists
Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/otopi/miniyum.py
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 1 month
Change in otopi[otopi-1.1]: core: miniyum: fix http range error when yum cache exists
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: miniyum: fix http range error when yum cache exists
......................................................................
core: miniyum: fix http range error when yum cache exists
Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/otopi/miniyum.py
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25119
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.1
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.4]: core, restapi: Fix add permissions
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core, restapi: Fix add permissions
......................................................................
core, restapi: Fix add permissions
The refactoring of the authentication mechanism introduced two different
identifiers for users and groups: one used internally by the engine and
one used by the external directory. The RESTAPI wasn't correctly
handling requests to add permissions when the provided identifier was
the internal one. The patch fixes the RESTAPI and the backend so that
they will accept both identifiers when adding users or groups.
Change-Id: I0d05c4bf4ebd242fd3a01a2f9a8d679f687c4982
Bug-Url: https://bugzilla.redhat.com/1064829
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 072cc1f4c3495b75f344688c9b28691875a12f88)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/PermissionMapperTest.java
10 files changed, 335 insertions(+), 80 deletions(-)
Approvals:
Juan Hernandez: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d05c4bf4ebd242fd3a01a2f9a8d679f687c4982
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Bad vertical alignment in add user screen
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Bad vertical alignment in add user screen
......................................................................
webadmin: Bad vertical alignment in add user screen
When adding a new user, the dropdown box for
selecting the domain and the search box are misaligned
Change-Id: I967023959027f2b977592cf8a6b61952960e24c3
Bug-Url: https://bugzilla.redhat.com/1057109
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml
1 file changed, 14 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25082
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I967023959027f2b977592cf8a6b61952960e24c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.4]: core: Disabling an SD with unplugged disk of a VM
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Disabling an SD with unplugged disk of a VM
......................................................................
core: Disabling an SD with unplugged disk of a VM
Prior to this patch, when disabling a Storage Domain the canDoAction()
would check that it does not contain any disks in that belong to running
VM, and if it does, the command is failed.
This behavior is overly strict, and we should be able to disable a
domain which contains unplugged disks, even if they are attached to a
running VM.
This patch contains:
1. Changing the GetVmsByStorageDomainId stored procedure to take only
plugged disks in to account.
2. In fixtures.xml, plugging disk 1b26a52b-b60f-44cb-9f46-3ef333b04a35
into VM 77296e00-0cad-4e5a-9299-008a7b6f4355, as opposed to just
attaching it in order for this fix to be tested.
3. Updating the DAO tests accordingly.
Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a
Bug-Url: https://bugzilla.redhat.com/1065747
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/vms_sp.sql
6 files changed, 31 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
