February 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Enable ServletUtilsTest.testCanReadFile()

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Enable ServletUtilsTest.testCanReadFile() ...................................................................... core: Enable ServletUtilsTest.testCanReadFile() This test was disabled in commit efa1582eafeac05b5f911dd2ce93fdfe8aa0e542 as it fails when run as root. This patch offers a cleaner way to make sure the build passes - instead of ignoring the test, Assume is used to make sure the user is not root, and if it is, silently skip the test. Using this technique we can make sure that the test is run at least some of time, and gain some extra stability. Change-Id: I754a358221d9fc370d6418a06baf08b97c25b4fa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/23713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I754a358221d9fc370d6418a06baf08b97c25b4fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: add disk description mapping

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: add disk description mapping ...................................................................... restapi: add disk description mapping This patch adds the disk description to the disk mapper so that it'll be passed from the rest to the backend. Change-Id: I42f5509b06363adfc15427d540e704d5f0cef5ec Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1056245 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42f5509b06363adfc15427d540e704d5f0cef5ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: refactor OvfVmReader#readHardwareSection

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor OvfVmReader#readHardwareSection ...................................................................... core: refactor OvfVmReader#readHardwareSection The method OvfVmReader#readHardwareSection was too long. By extracting the handling of each hardware type into a separate method and using the relatively new capability in Java of switch-case statement on String, this patch simplify that method. Change-Id: I403489679eb97359842a3662278b7312a81911fd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 1 file changed, 131 insertions(+), 85 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I403489679eb97359842a3662278b7312a81911fd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Check VDSM supported clusters to deserialize QoS

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: engine: Check VDSM supported clusters to deserialize QoS ...................................................................... engine: Check VDSM supported clusters to deserialize QoS It is not in fact correct check the cluster's compatibility version to see if Host Network QoS is supported, since GetVdsCapabilities should work even if the VDSM is too old for the cluster's compatibility version, and in case there's QoS configured on a host we'd want it to be reported even if it resides in an older cluster. Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Bug-Url: https://bugzilla.redhat.com/1056155 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: Change used configured range for display port to 5900-6923

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: Change used configured range for display port to 5900-6923 ...................................................................... Change used configured range for display port to 5900-6923 this changes the AIO configuration and the database vdc_options for iptables rules. This patch goes together with http://gerrit.ovirt.org/#/c/23940 Change-Id: I1b93517965437b74b88e092d666fe2e91c43a6d3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1052162 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/firewalld/aio/ovirt-aio.xml.in 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Vinzenz Feenstra: Verified -- To view, visit http://gerrit.ovirt.org/23941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b93517965437b74b88e092d666fe2e91c43a6d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix templates search query

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix templates search query ...................................................................... core: Fix templates search query This patch improves the performance of the SearchQuery mechanism for the vm_templates view Change-Id: I0ef77348bc6126f5b038e40d949de6d5804def5f Bug-Url: https://bugzilla.redhat.com/1057561 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/23811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ef77348bc6126f5b038e40d949de6d5804def5f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Check VDSM supported clusters to deserialize QoS

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Check VDSM supported clusters to deserialize QoS ...................................................................... engine: Check VDSM supported clusters to deserialize QoS It is not in fact correct check the cluster's compatibility version to see if Host Network QoS is supported, since GetVdsCapabilities should work even if the VDSM is too old for the cluster's compatibility version, and in case there's QoS configured on a host we'd want it to be reported even if it resides in an older cluster. Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Bug-Url: https://bugzilla.redhat.com/1056155 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Improve audit_log seach query

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: Improve audit_log seach query ...................................................................... core: Improve audit_log seach query This patch improves the performance of the SearchQuery mechanism for the audit_log table. Change-Id: I396a90d63a10fc049a37e4792d3e558ff2a7fea3 Bug-Url: https://bugzilla.redhat.com/1056064 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 46 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/23567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I396a90d63a10fc049a37e4792d3e558ff2a7fea3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: support classless IN-ADDR.ARPA delegation

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: support classless IN-ADDR.ARPA delegation ...................................................................... packaging: setup: support classless IN-ADDR.ARPA delegation support reverse query checking for RFC2317("Classless IN-ADDR.ARPA delegation") type domain host. recent version requires to set local host domain in /etc/hosts or private DNS server. this update treats sub-delegated reverse zone, which uses CNAME to forward NS. Change-Id: I9f65fbc27992ddae0b3d01e19d317a2abe39db7b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Signed-off-by: Mark Kachi <love.cairn(a)gmail.com> --- M packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Mark Kachi: Verified -- To view, visit http://gerrit.ovirt.org/23818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f65fbc27992ddae0b3d01e19d317a2abe39db7b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mark Kachi <love.cairn(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mark Kachi <love.cairn(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Add warning when modifying management network

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Add warning when modifying management network ...................................................................... webadmin: Add warning when modifying management network Added warning that certain changes in the management network's properties could lead to loss of connectivity to hosts in the DC. Change-Id: Icf768a00fc78335227e77f23ed6b9ffe1aac39ec Bug-Url: https://bugzilla.redhat.com/906359 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf768a00fc78335227e77f23ed6b9ffe1aac39ec Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2014