February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Console client page url retrieval
by awels＠redhat.com 03 Feb '14

03 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: frontend: Console client page url retrieval ...................................................................... frontend: Console client page url retrieval Retrieving console client resources page should differentiate between absolute and relative links. Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/24003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Collect metadata for packaging jobs.
by eedri＠redhat.com 03 Feb '14

03 Feb '14

Eyal Edri has submitted this change and it was merged. Change subject: Collect metadata for packaging jobs. ...................................................................... Collect metadata for packaging jobs. Change-Id: Ica3339549f0afe284ccdfad3cd083f4efccc880b Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- A jobs/packaging/gather_jobs_info.sh 1 file changed, 63 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved Kiril Nesenko: Verified -- To view, visit http://gerrit.ovirt.org/23985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica3339549f0afe284ccdfad3cd083f4efccc880b Gerrit-PatchSet: 14 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: history: Added is_local_storage to dwh_datacenter_configurat...
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: history: Added is_local_storage to dwh_datacenter_configuration_history_view ...................................................................... history: Added is_local_storage to dwh_datacenter_configuration_history_view This patch adds is_local_storage to dwh_datacenter_configuration_history_view A storage pool can be marked as local - contains local on host storage or shared - contains shared storages of various types. Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Related-To: https://bugzilla.redhat.com/1038053 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: align user instruction for database creation
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: align user instruction for database creation ...................................................................... packaging: setup: align user instruction for database creation 'create user' -> 'create role' Also: 'engine_history' -> 'engine_reports' Change-Id: I60499d3485178bcf26372d5b332f0389dc9de57e Related-To: https://bugzilla.redhat.com/1040572 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60499d3485178bcf26372d5b332f0389dc9de57e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: disable virtio-scsi for unsupported OSes
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: disable virtio-scsi for unsupported OSes ...................................................................... webadmin: disable virtio-scsi for unsupported OSes VM dialog: * When selecting an OS that doesn't support VirtIO-SCSI, 'VirtIO-SCSI Enabled' checkbox should be disabled. * Updated VmModelBehaviorBase and derived behavior models accordingly. Change-Id: I0256b84e1c82a6c2330287f1e68385d785d26b26 Bug-Url: https://bugzilla.redhat.com/1038613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 8 files changed, 79 insertions(+), 15 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0256b84e1c82a6c2330287f1e68385d785d26b26 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: typo
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: typo ...................................................................... packaging: setup: typo charecters -> characters Change-Id: I6b9355187808e5619aebdaa7fb0e19c3f85e3753 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b9355187808e5619aebdaa7fb0e19c3f85e3753 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic
by yzaslavs＠redhat.com 03 Feb '14

03 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Eliminate unneeded updates to VdsDynamic ...................................................................... core: Eliminate unneeded updates to VdsDynamic This patch tries to minimize updates to VdsDynamic by checking the database value before updating the entity. Change-Id: Icab3ed7d251573f150d28f966d0ad2363ecc3441 Bug-Url: https://bugzilla.redhat.com/1016634 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CheckedUpdate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 5 files changed, 52 insertions(+), 2 deletions(-) Approvals: Liran Zelkha: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icab3ed7d251573f150d28f966d0ad2363ecc3441 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Move ResourceManager to batch update VdsDynamic
by yzaslavs＠redhat.com 03 Feb '14

03 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Move ResourceManager to batch update VdsDynamic ...................................................................... core: Move ResourceManager to batch update VdsDynamic There is a TODO in ResourceManager to allow batch updates of VdsDynamic this patch introduces MassOperations to VdsDynamic and allow batch updates of it. I also changed ResourceManager to use the batch capability. Change-Id: If857a328d591f87cf453f1620f134d5e0a137363 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 3 files changed, 101 insertions(+), 120 deletions(-) Approvals: Liran Zelkha: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If857a328d591f87cf453f1620f134d5e0a137363 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Fix command line args in engine-manage-domains
by yzaslavs＠redhat.com 03 Feb '14

03 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fix command line args in engine-manage-domains ...................................................................... tools: Fix command line args in engine-manage-domains 1) Converts java-type arguments (-configFile) into proper long arguments (--config-file) 2) Removes --action argument since action has to be always specified 3) Renames argument --force-delete to --force Change-Id: I1296958a54d8b802e0d6fb59f1f75cc608e75818 Bug-Url: https://bugzilla.redhat.com/904029 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResultEnum.java A backend/manager/tools/src/main/resources/manage-domains-help.properties M packaging/bin/engine-manage-domains.sh M packaging/man/man8/engine-manage-domains.8 6 files changed, 651 insertions(+), 322 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1296958a54d8b802e0d6fb59f1f75cc608e75818 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adds cli parser supporting short and long args
by yzaslavs＠redhat.com 03 Feb '14

03 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adds cli parser supporting short and long args ...................................................................... core: Adds cli parser supporting short and long args Adds command line arguments parser that supports parsing short (-h) and long arguments (--help). Change-Id: Id7fe3bf761bd26c86d684ad1dc85751d4492239b Bug-Url: https://bugzilla.redhat.com/904029 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/Argument.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ArgumentBuilder.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ExtendedCliParser.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ArgumentBuilderTest.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ExtendedCliParserTest.java 5 files changed, 770 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7fe3bf761bd26c86d684ad1dc85751d4492239b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0