March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: change domains status to unknown when there are no rep...
by laravot＠redhat.com 24 Mar '14

24 Mar '14

Liron Ar has submitted this change and it was merged. Change subject: core: change domains status to unknown when there are no reporting hosts ...................................................................... core: change domains status to unknown when there are no reporting hosts Currently the monitored pool domains 'change' their statuses according to the reports received by the pool hosts that are in status UP. When there are no reporting hosts - the status of the pool domains that are monitored should be changed to unknown, because otherwise nothing will trigger the status change. In that case (an example) we might be left with a domain in 'active' status although there are no reporting hosts. Change-Id: I8091a4864711aeccee41effb1bc7d9823a1870c7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=975742 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StoragePoolDomainHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReconstructMasterVDSCommand.java 5 files changed, 90 insertions(+), 48 deletions(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8091a4864711aeccee41effb1bc7d9823a1870c7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Bump version
by msivak＠redhat.com 24 Mar '14

24 Mar '14

Martin Sivák has submitted this change and it was merged. Change subject: Bump version ...................................................................... Bump version Change-Id: Ib31b2b720df249cef42a1d9a7aa206fbf81a3552 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Jiří Moskovčák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31b2b720df249cef42a1d9a7aa206fbf81a3552 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix eclipse/findbugs warnings
by emesika＠redhat.com 24 Mar '14

24 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: engine: fix eclipse/findbugs warnings ...................................................................... engine: fix eclipse/findbugs warnings Change-Id: I280d5b697d8736cec4f5736cd3af25a0cf2db6c1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeCommand.java 3 files changed, 5 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/26018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I280d5b697d8736cec4f5736cd3af25a0cf2db6c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: enforce lock file permissions same as ca private key
by sbonazzo＠redhat.com 24 Mar '14

24 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: enforce lock file permissions same as ca private key ...................................................................... pki: enforce lock file permissions same as ca private key Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075209 Change-Id: I89d1bee3c7fff1bae2ee555d556e35171bef612c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-enroll-request.sh 1 file changed, 30 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d1bee3c7fff1bae2ee555d556e35171bef612c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fixing taskcleaner.sh utility help
by oourfali＠redhat.com 24 Mar '14

24 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixing taskcleaner.sh utility help ...................................................................... core: fixing taskcleaner.sh utility help This patch fixes the -R option description to note that all tasks will be removed unless also the -z option is given. Change-Id: If139423d1158060b00d0c205bc94608a06e1572c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079469 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If139423d1158060b00d0c205bc94608a06e1572c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Do not enable NFS on upgrade
by sbonazzo＠redhat.com 24 Mar '14

24 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Do not enable NFS on upgrade ...................................................................... packaging: setup: Do not enable NFS on upgrade Do not allow configuring an NFS ISO domain on upgrade. Bug-Url: https://bugzilla.redhat.com/1056777 Change-Id: I10734f3debd5e3fb122707deb0cb8b354fbe2fa6 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ofer Schreiber: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/25167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10734f3debd5e3fb122707deb0cb8b354fbe2fa6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: disable command's logging on runningFailed
by ahadas＠redhat.com 24 Mar '14

24 Mar '14

Arik Hadas has submitted this change and it was merged. Change subject: core: disable command's logging on runningFailed ...................................................................... core: disable command's logging on runningFailed After calling RunVmCommandBase#runningFailed the automatic logging should be disabled since the 'log()' method is called directly by this method. A call to 'setCommandShouldBeLogged(false)' was added inside RunVmCommandBase#runningFailed. It is safe since this method is called on rerun flows, where the automatic logging is not invoked anyway, and from one place as part of the execution phase where the automatic logging is already disabled. Change-Id: Ied9130d2e8dacb94924da220e8ba1a1f1204e681 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied9130d2e8dacb94924da220e8ba1a1f1204e681 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove vm fields for migration from & to ports
by ahadas＠redhat.com 24 Mar '14

24 Mar '14

Arik Hadas has submitted this change and it was merged. Change subject: core: remove vm fields for migration from & to ports ...................................................................... core: remove vm fields for migration from & to ports VM#migreatingToPort & VM#migreatingFromPort fields were unused so they are removed. Change-Id: I0742195dabff682943c5afae08ffa6e9539497a4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 2 files changed, 0 insertions(+), 24 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0742195dabff682943c5afae08ffa6e9539497a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: build: ovirt-engine-reports-3.4.0-2
by ydary＠redhat.com 24 Mar '14

24 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.4.0-2 ...................................................................... build: ovirt-engine-reports-3.4.0-2 Also added release notes. Change-Id: I91dc4b85243f354f307856198dc87b52b602d91b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91dc4b85243f354f307856198dc87b52b602d91b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: build: ovirt-engine-dwh-3.4.0-2
by ydary＠redhat.com 24 Mar '14

24 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.4.0-2 ...................................................................... build: ovirt-engine-dwh-3.4.0-2 Also added release notes. Change-Id: I6eb7857009196be53e3763fa88ced4a649f1da7c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eb7857009196be53e3763fa88ced4a649f1da7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0