April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Replaced the check of whether a storage pool contains ...
by tnisan＠redhat.com 28 Apr '14

28 Apr '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Replaced the check of whether a storage pool contains mixed type ...................................................................... core: Replaced the check of whether a storage pool contains mixed type Replaced the check of whether a storage pool contains storage domains of mixed types to use a designated query that fetches distinct storage types instead of fetching all the storage domains and filtering by that, in that way we are fetching less data and eliminating the use for logic in engine to determine if the domain is mixed thus resulting in better performance Change-Id: I86cf1512655865831de3cbd16c10a7bc243f08cd Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86cf1512655865831de3cbd16c10a7bc243f08cd Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added a query to fetch storage types in a storage pool
by tnisan＠redhat.com 28 Apr '14

28 Apr '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added a query to fetch storage types in a storage pool ...................................................................... core: Added a query to fetch storage types in a storage pool Added a query that fetches all the storage types of the data storage domains contained in a certain pool Change-Id: I97447e0fc3e087958101156947bded12c1fb9418 Related-To: https://bugzilla.redhat.com/1085395 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageTypesInPoolByPoolIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java M packaging/dbscripts/storages_sp.sql 6 files changed, 101 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97447e0fc3e087958101156947bded12c1fb9418 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: dal: Added a mixed storage pool to fixtures.xml
by tnisan＠redhat.com 28 Apr '14

28 Apr '14

Tal Nisan has submitted this change and it was merged. Change subject: dal: Added a mixed storage pool to fixtures.xml ...................................................................... dal: Added a mixed storage pool to fixtures.xml Added a mixed storage pool to fixtures.xml file to allow dao tests to test cases of mixed storage pools also Change-Id: I285c420902ce8d28cb7e8bfcc2ad3a11c225c0fb Bug-Url: https://bugzilla.redhat.com/1085395 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkQosDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNicDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 6 files changed, 82 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I285c420902ce8d28cb7e8bfcc2ad3a11c225c0fb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: engine-backup: support dwh and reports
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: engine-backup: support dwh and reports ...................................................................... packaging: engine-backup: support dwh and reports Bug-Url: https://bugzilla.redhat.com/1068979 Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 541 insertions(+), 81 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/27131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: setup: hide passwords
by ydary＠redhat.com 28 Apr '14

28 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: hide passwords ...................................................................... packaging: setup: hide passwords Filter in log Change mode for conf files Change-Id: I7faca5776b63859f0a391a68832443197e54cfc5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-reports-setup.py 2 files changed, 54 insertions(+), 16 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7faca5776b63859f0a391a68832443197e54cfc5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: win32: Retrieve the active session through enumeration
by vfeenstr＠redhat.com 28 Apr '14

28 Apr '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Retrieve the active session through enumeration ...................................................................... win32: Retrieve the active session through enumeration Using WTSGetActiveConsoleSessionId() does in case of RDP connections give a session id which is not corresponding to the users session in some cases. By enumerating through the sessions and retriving the session with the 'State' 'WTSActive' we are able to reliably retrieve the current active session. This is required in order to get the logged-in user and being able to retrieve the user token for performing operations in their name. Change-Id: I569d4b6b80e102b83b7e6e39c12524f2d588ad37 Bug-Url: https://bugzilla.redhat.com/1068750 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I569d4b6b80e102b83b7e6e39c12524f2d588ad37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup: support dwh and reports
by sbonazzo＠redhat.com 28 Apr '14

28 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: support dwh and reports ...................................................................... packaging: engine-backup: support dwh and reports Bug-Url: https://bugzilla.redhat.com/1068979 Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 541 insertions(+), 81 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/25850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "core: Host's Compatibility Version doesn't match the...
by emesika＠redhat.com 28 Apr '14

28 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: Revert "core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version", as it was decided that this implementation is wrong ...................................................................... Revert "core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version", as it was decided that this implementation is wrong This reverts commit 9d99c9b4cfea147f4213d1aca67f4a2a90fe12cd. Change-Id: Iea9113ac67590c8f7a39b8c458e2de60f623491f Signed-off-by: lzelkha(a)redhat.com --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HandleVdsVersionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 7 files changed, 19 insertions(+), 137 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/27124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea9113ac67590c8f7a39b8c458e2de60f623491f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: Lessen permissions needed for VmPool creation
by ofrenkel＠redhat.com 28 Apr '14

28 Apr '14

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Lessen permissions needed for VmPool creation ...................................................................... backend: Lessen permissions needed for VmPool creation Changed AddVmPoolWithVmsCommand to require only CREATE_VM permission for the template instead of CREATE_VM_POOL to make it consistent with user's ability to create VMs. Change-Id: Ib28ae681a91d7b11455283041062779733e61f2b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058290 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib28ae681a91d7b11455283041062779733e61f2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: build: require newer jasperreports
by ydary＠redhat.com 28 Apr '14

28 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: build: require newer jasperreports ...................................................................... packaging: build: require newer jasperreports Bug-Url: https://bugzilla.redhat.com/1086003 Change-Id: Ia3e97b69bff67dc70f11eba13761a7ed952094d7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3e97b69bff67dc70f11eba13761a7ed952094d7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0