April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-3.4]: history:fixed message in MinimalVersionCheck job
by ydary＠redhat.com 28 Apr '14

28 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: history:fixed message in MinimalVersionCheck job ...................................................................... history:fixed message in MinimalVersionCheck job fixed incorrect instructions for upgrade of engine & dwh on MinimalVersionCheck job. Change-Id: Ib566681c00b745ec6459154a35816cce2e0acb7d Bug-Url: https://bugzilla.redhat.com/1090914 Signed-off-by: Shirly Radco <sradco(a)redhat.com> (cherry picked from commit aeaadde7719caeeb31f46f9e39daebc93400a2ec) --- M etl_export/src/ovirt_engine_dwh/minimalversioncheck_3_4/MinimalVersionCheck.java M tos_project/process/MinimalVersionCheck_3.4.item M tos_project/process/MinimalVersionCheck_3.4.properties 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib566681c00b745ec6459154a35816cce2e0acb7d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Use custom pg_dump format
by sbonazzo＠redhat.com 28 Apr '14

28 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Use custom pg_dump format ...................................................................... packaging: setup: Use custom pg_dump format Related-To: https://bugzilla.redhat.com/1059286 Change-Id: I684f025c9c1d29c701068ba967be5a2115c7a6fb Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I684f025c9c1d29c701068ba967be5a2115c7a6fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Avoid storing external network label in oVirt-engine DB
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Avoid storing external network label in oVirt-engine DB ...................................................................... engine: Avoid storing external network label in oVirt-engine DB Network labels for oVirt-engine and for Neutron should not be mixed when creating a network and labelling it. For oVirt-engine network only oVirt-engine labels should be presented for newly created network and for Neutron network only Neutron labels. External network label should not be stored in oVirt-engine DB. As soon as we won't store the external network labels it would never be mixed up with the oVirt-engine managed network labels. Change-Id: Ic3c041d6900a8af852f1d186c626be315d205be6 Bug-Url: https://bugzilla.redhat.com/1077132 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java A packaging/dbscripts/upgrade/03_04_0760_nullify_external_network_labels.sql 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/27119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c041d6900a8af852f1d186c626be315d205be6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: import vm dialog - fix list-box crop
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: import vm dialog - fix list-box crop ...................................................................... webadmin: import vm dialog - fix list-box crop Import VM/Template dialog: fix cropping of 'Default Storage Domain' select-box. Change-Id: I2a40dae9ec88246b3844eafde680a22b7644a0fa Bug-Url: https://bugzilla.redhat.com/1087088 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.ui.xml 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/27103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a40dae9ec88246b3844eafde680a22b7644a0fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: handle 'source' domains when adding a vm from template
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: handle 'source' domains when adding a vm from template ...................................................................... core: handle 'source' domains when adding a vm from template When adding a vm from template we need to make sure to choose an Active domain on which the template disks stored on for the operation- 1. If there's no such domain, a CDA message should be displayed. 2. If the source disk is stored on few domains, the engine will attempt to select the same domain as the target domain for possibly faster copy. 3. For better user experience, at first we inspect if all the source disks have a copy on Active domain, later on the destination domains are being verified and then the source domains will be selected as explained in (2). Change-Id: I8d02cfded41a3588dc944d9dfcd5a3eec88c45ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037439 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 217 insertions(+), 8 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/27111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d02cfded41a3588dc944d9dfcd5a3eec88c45ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: loadbalancing: prevent VM bounces between hosts
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: loadbalancing: prevent VM bounces between hosts ...................................................................... core: loadbalancing: prevent VM bounces between hosts When balancing a cluster, the balancing logic should return a VM and acceptable hosts, while filtering those hosts the scheduler#balance doesn't take into account the predicted VM CPU load. This may result in a VM bouncing between 2 hosts (if VM consumes all the CPU resources on both hosts). Change-Id: I6beebf4324bfa5218d9617619b350fb9a2de56d3 Bug-Url: https://bugzilla.redhat.com/1043233 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java 1 file changed, 38 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6beebf4324bfa5218d9617619b350fb9a2de56d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Reorganize SD space validations in AddVm
by amureini＠redhat.com 27 Apr '14

27 Apr '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Reorganize SD space validations in AddVm ...................................................................... core: Reorganize SD space validations in AddVm This is the first of two patches meant to fix faulty storage space allocations validations in the different add VM commands. This patch keeps the current (faulty) validations and reorganizes them in methods that can be overridden in the derived classes when needed. It also adds two new threshold tests - verifying the AddVmCommand behaviour to the simulated StorageDomainValidator.isDomainWithinThresholds . Change-Id: I482709d7edb0333a6aa7b9ab723eea7f4c5a00d3 Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=917682 Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=1053742 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 103 insertions(+), 26 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I482709d7edb0333a6aa7b9ab723eea7f4c5a00d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removed redundant storage allocation checks
by amureini＠redhat.com 27 Apr '14

27 Apr '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed redundant storage allocation checks ...................................................................... core: Removed redundant storage allocation checks AddVmCommandTest contains storage allocation checks. StorageDomainValidator already has the necessary tests, so there's no need for this redundancy. Therefore removing storage tests from AddVmCommandTest. Change-Id: Ia0e28f6cc8bd2834d6fe6ce6288a20946a69e9b3 Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=917682 Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=1053742 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 0 insertions(+), 78 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/26732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e28f6cc8bd2834d6fe6ce6288a20946a69e9b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix AddVm faulty storage allocation checks
by amureini＠redhat.com 27 Apr '14

27 Apr '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix AddVm faulty storage allocation checks ...................................................................... core: Fix AddVm faulty storage allocation checks Fix AddVmCommand and its descendants storage allocation checks. Amended and added relevant tests. Note that the tests here rely on the fact that StorageDomainValidator is well tested, and only simulate its output, then testing the commands according to it. Change-Id: Iff4ad246934b3b94f21ae602067033347c913780 Bug-Url: https://bugzilla.redhat.com/917682 Bug-Url: https://bugzilla.redhat.com/1053742 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java 6 files changed, 313 insertions(+), 53 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff4ad246934b3b94f21ae602067033347c913780 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-3.4]: packaging: setup: clean up jasper artifacts after import
by ydary＠redhat.com 27 Apr '14

27 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: clean up jasper artifacts after import ...................................................................... packaging: setup: clean up jasper artifacts after import Without this change, _articfacts and _import can in principle be called with any order, however, since otopi sorts methods by name they'll always be called in order reverse of intended. Change-Id: I9e836357771d76e269ff5c582bd7dd525ea30f3a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 547f1eb77185dc2342a016e9a05a5b990f1e2ef0) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e836357771d76e269ff5c582bd7dd525ea30f3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0