April 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-reports[master]: packaging: setup: clean up jasper artifacts after import

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: clean up jasper artifacts after import ...................................................................... packaging: setup: clean up jasper artifacts after import Without this change, _articfacts and _import can in principle be called with any order, however, since otopi sorts methods by name they'll always be called in order reverse of intended. Change-Id: I9e836357771d76e269ff5c582bd7dd525ea30f3a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e836357771d76e269ff5c582bd7dd525ea30f3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Avoid storing external network label in oVirt-engine DB

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid storing external network label in oVirt-engine DB ...................................................................... engine: Avoid storing external network label in oVirt-engine DB Network labels for oVirt-engine and for Neutron should not be mixed when creating a network and labelling it. For oVirt-engine network only oVirt-engine labels should be presented for newly created network and for Neutron network only Neutron labels. External network label should not be stored in oVirt-engine DB. As soon as we won't store the external network labels it would never be mixed up with the oVirt-engine managed network labels. Change-Id: Ic3c041d6900a8af852f1d186c626be315d205be6 Bug-Url: https://bugzilla.redhat.com/1077132 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java A packaging/dbscripts/upgrade/03_05_0330_nullify_external_network_labels.sql 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/26033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c041d6900a8af852f1d186c626be315d205be6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-dwh[master]: history:fixed message in MinimalVersionCheck job

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: history:fixed message in MinimalVersionCheck job ...................................................................... history:fixed message in MinimalVersionCheck job fixed incorrect instructions for upgrade of engine & dwh on MinimalVersionCheck job. Change-Id: Ib566681c00b745ec6459154a35816cce2e0acb7d Bug-Url: https://bugzilla.redhat.com/1090914 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/minimalversioncheck_3_4/MinimalVersionCheck.java M tos_project/process/MinimalVersionCheck_3.4.item M tos_project/process/MinimalVersionCheck_3.4.properties 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib566681c00b745ec6459154a35816cce2e0acb7d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-reports[master]: reports: br4 report - added comments to queries

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br4 report - added comments to queries ...................................................................... reports: br4 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I81ec6668e41299df4116e4c8aa6f976f11f872de Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/br7 full details.jrxml.data 2 files changed, 664 insertions(+), 455 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ec6668e41299df4116e4c8aa6f976f11f872de Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: handle 'source' domains when adding a vm from template

by laravot＠redhat.com

Liron Ar has submitted this change and it was merged. Change subject: core: handle 'source' domains when adding a vm from template ...................................................................... core: handle 'source' domains when adding a vm from template When adding a vm from template we need to make sure to choose an Active domain on which the template disks stored on for the operation- 1. If there's no such domain, a CDA message should be displayed. 2. If the source disk is stored on few domains, the engine will attempt to select the same domain as the target domain for possibly faster copy. 3. For better user experience, at first we inspect if all the source disks have a copy on Active domain, later on the destination domains are being verified and then the source domains will be selected as explained in (2). Change-Id: I8d02cfded41a3588dc944d9dfcd5a3eec88c45ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037439 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 217 insertions(+), 8 deletions(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d02cfded41a3588dc944d9dfcd5a3eec88c45ab Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: adding GetDiskSnapshotByImageId Query

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: adding GetDiskSnapshotByImageId Query ...................................................................... core: adding GetDiskSnapshotByImageId Query Adding a new query for retrieving a disk snapshot by image id: GetDiskSnapshotByImageIdQuery. Change-Id: Ib297ea07bd8b2d53ae21c5e93fe7dcc7b11c4a59 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskSnapshotByImageIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib297ea07bd8b2d53ae21c5e93fe7dcc7b11c4a59 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: extract PrepareSnapshotConfig method to BaseImagesCommand

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: extract PrepareSnapshotConfig method to BaseImagesCommand ...................................................................... core: extract PrepareSnapshotConfig method to BaseImagesCommand Extracted PrepareSnapshotConfigWithoutImageSingleImage from RemoveImageCommand into BaseImagesCommand for reusability in other derivative commands. Change-Id: I965a099ce8d048eb0b19bda96b387140b26bdf2b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 2 files changed, 46 insertions(+), 44 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I965a099ce8d048eb0b19bda96b387140b26bdf2b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: extract SnapshotsEngineLock to BaseImagesCommand

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: extract SnapshotsEngineLock to BaseImagesCommand ...................................................................... core: extract SnapshotsEngineLock to BaseImagesCommand Extracted SnapshotsEngineLock from RemoveImageCommand into BaseImagesCommand for reusability in other derivative commands. Change-Id: Idc4b46a2c53a0ec6ac13c1dba73089ae4512bea7 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 2 files changed, 24 insertions(+), 18 deletions(-) Approvals: Daniel Erez: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc4b46a2c53a0ec6ac13c1dba73089ae4512bea7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-reports[ovirt-engine-3.4]: build: ovirt-engine-reports-3.4.1_rc

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.4.1_rc ...................................................................... build: ovirt-engine-reports-3.4.1_rc Change-Id: I6b945385a3c1d52888a5c6b3f5c87f66bfec1f94 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b945385a3c1d52888a5c6b3f5c87f66bfec1f94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 8 months

1
0
0 / 0

Change in ovirt-reports[ovirt-engine-3.4]: build: post ovirt-engine-reports-3.4.1_rc

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.4.1_rc ...................................................................... build: post ovirt-engine-reports-3.4.1_rc Change-Id: I352f75fea8605951d30a903c63a35547babbd734 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352f75fea8605951d30a903c63a35547babbd734 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits April 2014