Change in ovirt-engine[ovirt-engine-3.4]: core, webadmin: remove name from template version
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core, webadmin: remove name from template version
......................................................................
core, webadmin: remove name from template version
>From now, the template.name for template versions will be the name of
the base template, and template versions will only use the version name.
in this patch:
- backend: make sure name of template version is the same as the name of the base
template (ie. allow duplicate name for template base and its versions).
- backend + UI: dont check name already exist for template versions.
- UI: disable 'name' field on new template dialog for versions,
this field will show the selected base name.
- UI: template grid - show 'version_name (version_number)' instead of
'name (version_name)'.
- UI: show template version name for importing templates, on template
sub tab of export domain, and on import template dialog.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075074
Change-Id: I27f26e7d196d1d2eebfe86e8aac886f3e6a8fc5e
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/upgrade/03_04_0750_update_template_version_naming.sql
M packaging/dbscripts/vm_templates_sp.sql
20 files changed, 136 insertions(+), 29 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27f26e7d196d1d2eebfe86e8aac886f3e6a8fc5e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Distinguish between manual fence resulted..
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Distinguish between manual fence resulted..
......................................................................
core: Distinguish between manual fence resulted..
Distinguish between manual fence resulted from user action and manual fence called internally by auto fence
Manual fence currently can be executed in 2 flows
1) As part of the non responding treatment when host is restart via its
PM agent.
2) As a result of a manual host stopping and choosing "confirm Host has
been rebooted" from the right-click popup menu
The messages generated by both to the log are of the format:
Manual fence for host ${VdsName} was started.
Manual fence for host ${VdsName} failed.
When this occurs in scenario 1) above, the term "manual" in the audit
log is confusing and should be changed to reflect the fact that was done
internally by the engine code and not by the user
This patch logs different messages to the audit log when resulted from
scenario 1) above.
Change-Id: I274ec95bb3f2c217bd9871afa9d761a1b975d793
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083750
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I274ec95bb3f2c217bd9871afa9d761a1b975d793
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: KeyValueWidget to accept field width
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: KeyValueWidget to accept field width
......................................................................
webadmin: KeyValueWidget to accept field width
Enable KeyValueLineWidget to accept any arbitrary field width as
argument, to better style it for different dialogs.
Change-Id: Ic39c010099c49f8af8612233a5257249e2e7d069
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
3 files changed, 27 insertions(+), 30 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/26649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic39c010099c49f8af8612233a5257249e2e7d069
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: Set AddRemoveRowWidget visibility by model
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Set AddRemoveRowWidget visibility by model
......................................................................
webadmin: Set AddRemoveRowWidget visibility by model
Change the visibility of the widget according to whether its backing
model is available.
Change-Id: I69da372cf45a52f125ebf61890c70387e9541a33
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/26648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69da372cf45a52f125ebf61890c70387e9541a33
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: KeyValueModel to report valid if unavailable
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: KeyValueModel to report valid if unavailable
......................................................................
webadmin: KeyValueModel to report valid if unavailable
Changed KeyValueModel to report that it's valid if it is set to be
unavailable, to make it consistent with model validation in general.
Change-Id: Id731ac9159af1bcb3a7bc2fc9296e73674bbbdc5
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/26647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id731ac9159af1bcb3a7bc2fc9296e73674bbbdc5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: Serialize null QoS to empty dictionary entry
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Serialize null QoS to empty dictionary entry
......................................................................
engine: Serialize null QoS to empty dictionary entry
Previously it was serialized to no dictionary entry at all, in which
case the VDSM would leave the QoS settings as they already were
(instead of overwriting them to be unlimited).
Change-Id: I6a1316f81a7b89783eae04c055e2e686df5e7c98
Bug-Url: https://bugzilla.redhat.com/1077684
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NetworkQosMapper.java
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a1316f81a7b89783eae04c055e2e686df5e7c98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: unlock the VM after unsuccessful migration
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: unlock the VM after unsuccessful migration
......................................................................
core: unlock the VM after unsuccessful migration
This patch fixes a regression that caused VM to remain locked after
migration fails (in all rerun attempts).
Change-Id: I83de3934f801bf5c9be22173b5caf8ae0bf5b519
Bug-Url: https://bugzilla.redhat.com/1086280
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/26686
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83de3934f801bf5c9be22173b5caf8ae0bf5b519
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: add helper method for template version
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: add helper method for template version
......................................................................
core: add helper method for template version
some places in addVmTemplate command are checking for
baseTemplateId==null to understand if we add base template or template
version.
this patch encapsulate this logic into a method with a clear name.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075074
Change-Id: I25229303fcee443191be1f2a1de84be345f96aff
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26698
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25229303fcee443191be1f2a1de84be345f96aff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: aaa: Changing API to 3.3 behavior
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: aaa: Changing API to 3.3 behavior
......................................................................
aaa: Changing API to 3.3 behavior
Changing back the behavior of the API to 3.3 behavior.
Changing also the behavior of internal id allocation -
this is cancelled, and internal id (primary key) will always be the guid
returned from the directory.
Although in 3.5 we will have directories that are non ldap,
hence can have ids that are not GUID, we would like to handle
the user id representation differently, and this is a first stage.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1080230
Topic: AAA
Change-Id: Iff51fb9df33b4b679eba5b1c3ef2bea6ea7b3e07
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java
A packaging/dbscripts/upgrade/03_04_0730_change_group_ids.sql
A packaging/dbscripts/upgrade/03_04_0740_update_user_ids.sql
18 files changed, 104 insertions(+), 68 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Yair Zaslavsky: Verified
--
To view, visit http://gerrit.ovirt.org/26053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff51fb9df33b4b679eba5b1c3ef2bea6ea7b3e07
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in otopi[master]: build: fix typo in autoconf help
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: fix typo in autoconf help
......................................................................
build: fix typo in autoconf help
Change-Id: Iecd6ae052dad9e55cdf913505ff3302e0e03c298
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecd6ae052dad9e55cdf913505ff3302e0e03c298
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
