April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-iso-uploader[master]: nit: pep8 fixes
by sbonazzo＠redhat.com 15 Apr '14

15 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: nit: pep8 fixes ...................................................................... nit: pep8 fixes Change-Id: I3d268ab935b0826b66d4c70bb5068b9a8119462e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d268ab935b0826b66d4c70bb5068b9a8119462e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[master]: nit: pep8 fix
by sbonazzo＠redhat.com 15 Apr '14

15 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: nit: pep8 fix ...................................................................... nit: pep8 fix Leftover from Simone's patch Change-Id: I9865a5ee662bc453fb7ab19cbf509911961ed18f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovf/ovfenvelopetest.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9865a5ee662bc453fb7ab19cbf509911961ed18f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[master]: Clean the code to pass pep8 checks
by sbonazzo＠redhat.com 15 Apr '14

15 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Clean the code to pass pep8 checks ...................................................................... Clean the code to pass pep8 checks Refactor the code due to pep8 complains in order to be able to reenable it in the stardard build process Change-Id: I8b37c4a5c2449a93a4bc8b90d74301b66ae945e3 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 1,016 insertions(+), 424 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/26314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b37c4a5c2449a93a4bc8b90d74301b66ae945e3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: Remove redundant scroll bar in VM gener...
by tjelinek＠redhat.com 15 Apr '14

15 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Remove redundant scroll bar in VM general tab ...................................................................... userportal,webadmin: Remove redundant scroll bar in VM general tab The ProfilesInstanceTypeEditor had the vertical size hardcoded and was wrapped by a ScrollPanel. This caused the redundant scroll bar in the VM general tab to appear. Fixed by removing the ScrollPanel since in all other tabs in the VM dialog the scrolling is handled by the dialog itself - this change makes the behavior consistent with the rest of the tabs. Change-Id: I735fe5fb280f76c6ec771389879433cc9c42ff91 Bug-Url: https://bugzilla.redhat.com/1047883 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I735fe5fb280f76c6ec771389879433cc9c42ff91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Changing cluster of existing VM changes...
by tjelinek＠redhat.com 15 Apr '14

15 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Changing cluster of existing VM changes OS type ...................................................................... userportal,webadmin: Changing cluster of existing VM changes OS type Fixed by selecting the already selected OS type if it is still applicable under the context of the newly selected cluster. Change-Id: Ifaf27934e200e69beeb0912db22f26525b85e9b1 Bug-Url: https://bugzilla.redhat.com/1080056 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaf27934e200e69beeb0912db22f26525b85e9b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: resize columns
by awels＠redhat.com 14 Apr '14

14 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: resize columns ...................................................................... webadmin: resize columns - Made resizing columns in the grid easier by increasing the size of the area that can be grabbed from 3 to 5 pixels. As well as making the area available left and right of the splitting line. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037477 Change-Id: Id3d89413e5d3376b2c8ac29ecfbac58e2eead68f Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/HasResizableColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java 3 files changed, 36 insertions(+), 7 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3d89413e5d3376b2c8ac29ecfbac58e2eead68f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: system tree splitter enhancement
by awels＠redhat.com 14 Apr '14

14 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: system tree splitter enhancement ...................................................................... webadmin: system tree splitter enhancement - Fixed issue where the system tree size was not retained properly when refreshing the entire page. Change-Id: I2324bacd961361d64ffeb442752c35e939a562bc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1071316 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1071322 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/main/TabbedSplitLayoutPanel.java 1 file changed, 54 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2324bacd961361d64ffeb442752c35e939a562bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core, engine, userportal, webadmin: Run Once: avoid SPICE in...
by oourfali＠redhat.com 14 Apr '14

14 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core, engine, userportal, webadmin: Run Once: avoid SPICE in ppc64 VMs ...................................................................... core, engine, userportal, webadmin: Run Once: avoid SPICE in ppc64 VMs The Run Once command and the respective dialog on the frontend allowed the selection of the SPICE display protocol in ppc64 VMs. Since this is not supported, this change blocks this. Change-Id: Ic20fb0174710ae25057ea6a798add648fc868933 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067561 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Gustavo Frederico Temple Pedrosa: Verified -- To view, visit http://gerrit.ovirt.org/24851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20fb0174710ae25057ea6a798add648fc868933 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: dropping date from tarball
by sbonazzo＠redhat.com 14 Apr '14

14 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: dropping date from tarball ...................................................................... packaging: dropping date from tarball Dropping date from tarball, it's causing only issues in jenkins without any real benefit. Change-Id: I002fca0de044f154ee68fc291eed3184f19547a5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I002fca0de044f154ee68fc291eed3184f19547a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: ListModelTypeAheadListBox to not always add to val...
by lvernia＠redhat.com 14 Apr '14

14 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: ListModelTypeAheadListBox to not always add to valid values ...................................................................... webadmin: ListModelTypeAheadListBox to not always add to valid values Added a parameter that determines whether the widget should automatically add values to the list of "valid" values (those suggested). This is particularly useful when the selected value is initialized to some value, that shouldn't be chosen again once it's been changed (which is the case for the vNIC widget). Change-Id: Ic35073123696fe7e727464079c31794935a7ad70 Bug-Url: https://bugzilla.redhat.com/1020861 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileEditor.java 3 files changed, 26 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic35073123696fe7e727464079c31794935a7ad70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0