April 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: Adding RHEL7 Guest support

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: Adding RHEL7 Guest support ...................................................................... Adding RHEL7 Guest support Change-Id: Iaddd08e730898fc526f11c1c8c9371fed7801038 Bug-Url: https://bugzilla.redhat.com/1083065 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/rhel_7x64.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/rhel_7x64.jpg M packaging/conf/osinfo-defaults.properties 4 files changed, 10 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified Roy Golan: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaddd08e730898fc526f11c1c8c9371fed7801038 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: ui: remove non used enum mapping

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: ui: remove non used enum mapping ...................................................................... ui: remove non used enum mapping Change-Id: Ie4a6449e27b650ff3d664d34133927aa08aac135 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java 1 file changed, 0 insertions(+), 44 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vinzenz Feenstra: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/26543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4a6449e27b650ff3d664d34133927aa08aac135 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: host-deploy: SSHDialog: close streams after sink is stopped

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: SSHDialog: close streams after sink is stopped ...................................................................... host-deploy: SSHDialog: close streams after sink is stopped this solves Pipe Closed exception happens because of try-with-resources that was introduced at main thread, this closed the input stream before the reader thread could terminate properly. this also reverts 4d544a99, as it happens from same root cause, and I read the java sources incorrectly, the buffered input stream uses byte-by-byte read and not buffered. add unit test to reproduce this issue. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1084911 Change-Id: I180a9883eefac57c9b528ff7b6df0eda11149255 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java 3 files changed, 167 insertions(+), 75 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I180a9883eefac57c9b528ff7b6df0eda11149255 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: host-deploy: flush both stdout, stderr at ssh execute

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: flush both stdout, stderr at ssh execute ...................................................................... host-deploy: flush both stdout, stderr at ssh execute although until unclear why it is needed. 1. flush before java attempt to close using try-with-resources. 2. flush also stderr. 3. perform at one location. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1084911 Change-Id: I14424723f2ef6abff6f3abdc1072e5ac621d4e67 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java 2 files changed, 10 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14424723f2ef6abff6f3abdc1072e5ac621d4e67 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Bookmarks do not work when Search expr...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: Bookmarks do not work when Search expr... ...................................................................... core: Bookmarks do not work when Search expr... Bookmarks do not work when Search expression is not empty This patch changes the search string to empty string when switching between the Tree , Bookmarks & Tags in the web admin west pane. Change-Id: I7bb9e815e84a2ca1c8a740f7e236d16835ddeeef Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1052151 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java 1 file changed, 21 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bb9e815e84a2ca1c8a740f7e236d16835ddeeef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Add config values for mixed domain types in data center

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add config values for mixed domain types in data center ...................................................................... core: Add config values for mixed domain types in data center Change-Id: I9dd924bd1e53136fc5a1b6195700c7920658dde0 Bug-Url: https://bugzilla.redhat.com/1083560 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 19 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd924bd1e53136fc5a1b6195700c7920658dde0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Disallow domains of mixed subtype (file/block) in <3.4...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: Disallow domains of mixed subtype (file/block) in <3.4 storage pool ...................................................................... core: Disallow domains of mixed subtype (file/block) in <3.4 storage pool Disallow adding domains of a different subtype (file/block) that the domains alread contained in the pool with a compatibility version lower than 3.4 which contains domain Change-Id: I8226c29e6c34ab6434d0a5ec07aa7fa1d4d00306 Bug-Url: https://bugzilla.redhat.com/1083560 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 2 files changed, 37 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8226c29e6c34ab6434d0a5ec07aa7fa1d4d00306 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: db: 0000_config.sql - update OvirtIsoPrefix

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: db: 0000_config.sql - update OvirtIsoPrefix ...................................................................... db: 0000_config.sql - update OvirtIsoPrefix Update OvirtIsoPrefix to get iso name correctly during the search for the iso in upstream and downstream. Change-Id: I39ad1403b4afc8e6a5500c910560172395ee31fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1082612 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39ad1403b4afc8e6a5500c910560172395ee31fe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: backend: fix username in console connected/disconnected events.

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: backend: fix username in console connected/disconnected events. ...................................................................... backend: fix username in console connected/disconnected events. In all audits comming from commands the username does not include the domain, so in these two commands where the event is created explicitly, domain name should be removed. Change-Id: I6792cc4bf147dc6eced646b359537ee126341ac9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079208 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6792cc4bf147dc6eced646b359537ee126341ac9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 1 month

1
0
0 / 0

Change in ovirt-reports[master]: reports: br44 - added comments to queries

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br44 - added comments to queries ...................................................................... reports: br44 - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I60e0daf9c6ce94e51a541325a59c783d2ce7e5a7 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data M packaging/ovirt-reports/resources/Reports/Inventory/ccp_vm_inventory_br44_files/full details.jrxml.data 2 files changed, 961 insertions(+), 748 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60e0daf9c6ce94e51a541325a59c783d2ce7e5a7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits April 2014