April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: db: enable triggers after disable
by yzaslavs＠redhat.com 08 Apr '14

08 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: db: enable triggers after disable ...................................................................... db: enable triggers after disable Fixing an upgrade script that disables triggers twice on a table instead of re-enable them at the cleanup stage. Change-Id: Ia9cc47d1e2b65e6370e73ae58b472c899e1f6945 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/03_05_0220_update_user_ids.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9cc47d1e2b65e6370e73ae58b472c899e1f6945 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix failed unit test for http://gerrit.ovirt.org/#/c/2...
by emesika＠redhat.com 08 Apr '14

08 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix failed unit test for http://gerrit.ovirt.org/#/c/26068 ...................................................................... core: Fix failed unit test for http://gerrit.ovirt.org/#/c/26068 Patch http://gerrit.ovirt.org/#/c/26068 caused a failed dao unit test This patch fixes it. Change-Id: I741dbca28732fc27bd90c9598a040f4a969e9cb0 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsStaticByNameQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M packaging/dbscripts/vds_sp.sql 4 files changed, 28 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/26533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I741dbca28732fc27bd90c9598a040f4a969e9cb0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: edited ic query-only_vms_name
by ydary＠redhat.com 08 Apr '14

08 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: edited ic query-only_vms_name ...................................................................... reports: edited ic query-only_vms_name I edited the, only_vms_name, input control query, so it will be more readable and added comments. Change-Id: I3d3706c6d280a80fdd2d82d79f915dd980f9db9b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_VM_ID.xml 1 file changed, 90 insertions(+), 33 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d3706c6d280a80fdd2d82d79f915dd980f9db9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: edited ic query-only_storage_type
by ydary＠redhat.com 08 Apr '14

08 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: edited ic query-only_storage_type ...................................................................... reports: edited ic query-only_storage_type I edited the, only_storage_type, input control query, so it will be more readable and added comments. Change-Id: I4cc429f5ae714c88512183bd998f9ff4d51f1b41 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/P_Storage_Type.xml 1 file changed, 78 insertions(+), 24 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cc429f5ae714c88512183bd998f9ff4d51f1b41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: adding missing space to fix type
by oourfali＠redhat.com 08 Apr '14

08 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: adding missing space to fix type ...................................................................... tools: adding missing space to fix type Bug-Url: https://bugzilla.redhat.com/1058957 Change-Id: I663852b5ab9617e864413f760afe56e79cbdf3cb Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I663852b5ab9617e864413f760afe56e79cbdf3cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Added host interface label character validation
by oourfali＠redhat.com 08 Apr '14

08 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Added host interface label character validation ...................................................................... webadmin: Added host interface label character validation Previously the characters input into a newly-assigned label were only validated by the backend, now the dialog checks that no illegal characters were entered as well. Change-Id: I25bef382cb658e6e78bf5e2e0cfd1a273280d953 Bug-Url: https://bugzilla.redhat.com/1063846 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit f0dbb79b42884987a457780a09f403a50aeb4317) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/25549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25bef382cb658e6e78bf5e2e0cfd1a273280d953 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix listing name for Intel Haswell
by oourfali＠redhat.com 08 Apr '14

08 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix listing name for Intel Haswell ...................................................................... core: Fix listing name for Intel Haswell All Intel models are listed as "Intel <Model> Family", except for Haswell, wich does no contain "Family" in its listing name. Fixing. Change-Id: I8a8fd8e270bb23200f0d25f00afa8f7108a0f0a0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079420 Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Amador Pahim: Verified -- To view, visit http://gerrit.ovirt.org/26510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a8fd8e270bb23200f0d25f00afa8f7108a0f0a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools : engine-config is over writing the previous values
by oourfali＠redhat.com 08 Apr '14

08 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools : engine-config is over writing the previous values ...................................................................... tools : engine-config is over writing the previous values 'engine-config -s' is over writing the existing values with the new ones from command line. A new option to merge the new values provided with the values in the database has been added. 'engine-config -m' or 'engine-config --merge' This concatenates the new value with the exisiting value in the database. Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Bug-Url: https://bugzilla.redhat.com/1069768 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 83 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/26499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: Clean up ST warnings
by emesika＠redhat.com 08 Apr '14

08 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: findbugs: Clean up ST warnings ...................................................................... findbugs: Clean up ST warnings Removed all-out ST category suppression and replaced it with narrow, targeted suppressions, so that future instance methods updating static variables will be caught by FindBugs. Change-Id: I158d22e2c7e5f1ccedb6782b3288473f33e47a3f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M exclude-filters-general.xml M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/uicommonweb/exclude-filters.xml M frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 6 files changed, 73 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/26474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I158d22e2c7e5f1ccedb6782b3288473f33e47a3f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: findbugs: Clean up Dubious Method warnings
by emesika＠redhat.com 08 Apr '14

08 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: findbugs: Clean up Dubious Method warnings ...................................................................... findbugs: Clean up Dubious Method warnings Findbugs' Dubious Method Used warning are about calling methods that would work, but perform the required task inefficiently (e.g., calling new Boolean(true) instead of Boolean.valueOf(true), or even Boolean.TRUE). This patch removes the all-out filter for this category of warnings. Issues previously suppressed by this filter are either fixed where possible, or replaced with a more fine-grained filter where not possible. A notable case where these issues cannot be fixed in is GWT's auto-generated hashCode() methods for classes containing a boolean member. Change-Id: I6b904dfea1991b6ce5bb7c5a534127ee10e56a24 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M exclude-filters-general.xml M frontend/webadmin/modules/frontend/exclude-filters.xml M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java M frontend/webadmin/modules/webadmin/exclude-filters.xml 7 files changed, 15 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/26473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b904dfea1991b6ce5bb7c5a534127ee10e56a24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0