April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: Persist advanced/basic mode per dialog ...
by tjelinek＠redhat.com 04 Apr '14

04 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Persist advanced/basic mode per dialog type ...................................................................... userportal,webadmin: Persist advanced/basic mode per dialog type The setting is persisted in the local storage. Always the last state is persisted. Change-Id: I786daf31eb5cf713bf5b7afe1210d2655ef7bd4a Bug-Url: https://bugzilla.redhat.com/1075115 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/popup/AbstractVmBasedPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/template/TemplateNewPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmClonePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/BasePoolPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/PoolEditPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/PoolNewPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/template/TemplateNewPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmClonePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmPopupPresenterWidget.java 17 files changed, 87 insertions(+), 22 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I786daf31eb5cf713bf5b7afe1210d2655ef7bd4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: extract the ClientStorage interface
by tjelinek＠redhat.com 04 Apr '14

04 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: extract the ClientStorage interface ...................................................................... userportal,webadmin: extract the ClientStorage interface This patch makes the ClientStorage to be an interface (e.g. simply mockable) and bound to a ClientStorageImpl class in the BaseSystemModule. Change-Id: If5eaa942181c9df77278e736ddd6ac6b08e83fc7 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorage.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorageImpl.java 3 files changed, 108 insertions(+), 57 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5eaa942181c9df77278e736ddd6ac6b08e83fc7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Changing API to 3.3 behavior
by yzaslavs＠redhat.com 04 Apr '14

04 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Changing API to 3.3 behavior ...................................................................... aaa: Changing API to 3.3 behavior Changing back the behavior of the API to 3.3 behavior. Changing also the behavior of internal id allocation - this is cancelled, and internal id (primary key) will always be the guid returned from the directory. Although in 3.5 we will have directories that are non ldap, hence can have ids that are not GUID, we would like to handle the user id representation differently, and this is a first stage. Topic: AAA Change-Id: Iff51fb9df33b4b679eba5b1c3ef2bea6ea7b3e07 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java A packaging/dbscripts/upgrade/03_05_0210_change_group_ids.sql A packaging/dbscripts/upgrade/03_05_0220_update_user_ids.sql 18 files changed, 104 insertions(+), 68 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff51fb9df33b4b679eba5b1c3ef2bea6ea7b3e07 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in samples-uiplugins[master]: docker: new docker plugin
by vszocs＠redhat.com 03 Apr '14

03 Apr '14

Vojtech Szocs has submitted this change and it was merged. Change subject: docker: new docker plugin ...................................................................... docker: new docker plugin This patch adds a docker UI plugin, which allows you to create a VM that runs a docker image. See README file for more details. Change-Id: I6fbeecd38207815399f1e4afc86dd57465a010a9 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A docker-plugin/README A docker-plugin/docker-resources/icon_help.png A docker-plugin/docker-resources/launch-docker-dialog.html A docker-plugin/docker-resources/plugin.html A docker-plugin/docker-resources/progress.gif A docker-plugin/docker.json 6 files changed, 478 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/25814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fbeecd38207815399f1e4afc86dd57465a010a9 Gerrit-PatchSet: 4 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: Display correctly proto for Manage by
by dougsland＠redhat.com 03 Apr '14

03 Apr '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Display correctly proto for Manage by ...................................................................... engine_page: Display correctly proto for Manage by On status page, we have the "Manage by" string to show to users which oVirt Engine the node is registered. This patch will add a validation which protocol it used during the registration (http or https) and put it in the display. Change-Id: Iecfc53bab7e5f6ab226ded7f00bd6d140b6846b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065401 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecfc53bab7e5f6ab226ded7f00bd6d140b6846b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: Remove Retrieve Certificate button
by dougsland＠redhat.com 03 Apr '14

03 Apr '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Remove Retrieve Certificate button ...................................................................... engine_page: Remove Retrieve Certificate button ovirt-node-plugin-vdsm should popup to users the certificate when they register via https to accept it or not. This patch will add such schema and will remove the unneeded Retrieve Certificate button. Change-Id: I9f0e47242380c511e8ed672eeb0f541616696f8e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1081042 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 72 insertions(+), 33 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f0e47242380c511e8ed672eeb0f541616696f8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix DAO test error
by shavivi＠redhat.com 03 Apr '14

03 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: core: Fix DAO test error ...................................................................... core: Fix DAO test error Fixes DAO test error introcuded in Ibb63316e8505affd5d78edd90881b2c7cd83e05f. Change-Id: I4c80ce4e7366713e960bcbfed20d06b8a66bf8ff Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c80ce4e7366713e960bcbfed20d06b8a66bf8ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: findbugs: remove unused field in CreateVmVDSCommandParameters
by shavivi＠redhat.com 03 Apr '14

03 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: remove unused field in CreateVmVDSCommandParameters ...................................................................... findbugs: remove unused field in CreateVmVDSCommandParameters Change-Id: Ic58c109a8d350ea9b36c8ee73a98ce6aec94fcd4 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVmVDSCommandParameters.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic58c109a8d350ea9b36c8ee73a98ce6aec94fcd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: NFS config on update change
by oourfali＠redhat.com 03 Apr '14

03 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: NFS config on update change ...................................................................... packaging: setup: NFS config on update change Do not allow configuring an NFS ISO domain on upgrade by default. Allow user to override the new behavior of not re-configuring NFS while upgrading. User may now override the default behavior by setting otopi environment variable: OVESETUP_SYSTEM/nfsConfigEnabled Replace-Change-Id: I10734f3debd5e3fb122707deb0cb8b354fbe2fa6 Change-Id: I1fb4a9eb4af5e811a1fa1a63b8c11126b01ae56c Related-To: http://gerrit.ovirt.org/26043 Bug-Url: https://bugzilla.redhat.com/1073464 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 2 files changed, 15 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fb4a9eb4af5e811a1fa1a63b8c11126b01ae56c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: NFS config on update change
by oourfali＠redhat.com 03 Apr '14

03 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: NFS config on update change ...................................................................... packaging: setup: NFS config on update change Allow user to override the new behavior of not re-configuring NFS while upgrading. User may now override the default behavior by setting otopi environment variable: OVESETUP_SYSTEM/nfsConfigEnabled Change-Id: I1fb4a9eb4af5e811a1fa1a63b8c11126b01ae56c Related-To: http://gerrit.ovirt.org/26043 Bug-Url: https://bugzilla.redhat.com/1056777 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 8e1055290a636967f4f2eb8ec54c1a5c00721efa) --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 2 files changed, 15 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fb4a9eb4af5e811a1fa1a63b8c11126b01ae56c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0