Change in ovirt-engine[master]: webadmin: edit running vm
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: webadmin: edit running vm
......................................................................
webadmin: edit running vm
Update vm-type column in vm main tab to show if vm has next-run configuration.
on edit vm, get the next-run configuration if available.
Feature page: http://www.ovirt.org/Features/Edit_Running_VM
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072313
Change-Id: Ica093428d180fb280d53fd40dc5a4109b2aa842e
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/desktop_changes.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/server_changes.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/vm_desktop_stateless_changes.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/vm_server_stateless_changes.png
10 files changed, 100 insertions(+), 18 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27369
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica093428d180fb280d53fd40dc5a4109b2aa842e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: add support to update running vm
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add support to update running vm
......................................................................
core: add support to update running vm
Allow user update running vm, by saving configuration in a special
next_run snapshot (if needed).
and restore this configuration once the vm is down.
Feature page: http://www.ovirt.org/Features/Edit_Running_VM
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072313
Change-Id: Ie433352852f53f62e58349ce85475ee89e37ce89
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
16 files changed, 238 insertions(+), 16 deletions(-)
Approvals:
Roy Golan: Looks good to me, but someone else must approve
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26758
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie433352852f53f62e58349ce85475ee89e37ce89
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Audit log messages - grammar fix
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Audit log messages - grammar fix
......................................................................
core: Audit log messages - grammar fix
Change-Id: I3a8400104103a4899dfb6b1b908997af51e0631a
Bug-Url: https://bugzilla.redhat.com/1017030
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a8400104103a4899dfb6b1b908997af51e0631a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine-sdk[master]: codegen: Update generateDS.py version to 2.12a
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Update generateDS.py version to 2.12a
......................................................................
codegen: Update generateDS.py version to 2.12a
This update is required in order to make sure that empty XML elements
aren't lost during conversions.
Change-Id: I1fc08804b71aa316262c65ac5a8b6659db467251
Related: https://bugzilla.redhat.com/1091688
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/codegen/xsd/genparams.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fc08804b71aa316262c65ac5a8b6659db467251
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine-sdk[sdk_3.4]: codegen: Check version of generateDS.py
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Check version of generateDS.py
......................................................................
codegen: Check version of generateDS.py
Currently we don't check the version of the generateDS.py, as a
consecuence the generated code can be different depending on the machine
where the code generator is executed. This patch adds a check of the
version of generateDS.py, so if isn't the correct one the generation
will fail.
Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517
Related: https://bugzilla.redhat.com/1091688
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 05bc663ecd3ce1e2d20bbbeb45504ed949a9fd7f)
---
M src/codegen/xsd/genparams.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine-sdk[master]: codegen: Check version of generateDS.py
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Check version of generateDS.py
......................................................................
codegen: Check version of generateDS.py
Currently we don't check the version of the generateDS.py, as a
consecuence the generated code can be different depending on the machine
where the code generator is executed. This patch adds a check of the
version of generateDS.py, so if isn't the correct one the generation
will fail.
Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517
Related: https://bugzilla.redhat.com/1091688
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/codegen/xsd/genparams.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Vlan id should be shown next to vlan device name
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Vlan id should be shown next to vlan device name
......................................................................
webadmin: Vlan id should be shown next to vlan device name
In order to show the vlan id next to the vlan device name some changes
were done to the host interface sub tab.
1. Removing the address from the brackets next to the vlan device and bond
name.
2. Moving the adress column to the VLanPanel next to the network column.
All the addresses, vlan and non-vlan will be shown in this column.
3. Splitting the Interface panel into two panels- InterfacePanel and
StatisticsPanel. The StatisticsPanel will be the last panel- after the
VLanPanel.
Notice: there were some look-and-feel issues caused to this tab in commit
0248286a6b70ffe9076731aea406fdbfd6a97b0a.
This patch doesn't fix them.
Change-Id: Ia900e7d293df479cd9c98cfe66dcd0cb8b1f4fe4
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HostInterfaceBondNameRenderer.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HostVLanNameRenderer.java
9 files changed, 162 insertions(+), 107 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia900e7d293df479cd9c98cfe66dcd0cb8b1f4fe4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine : Refactored gluster volume profile query
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine : Refactored gluster volume profile query
......................................................................
engine : Refactored gluster volume profile query
This patch refactors the volume profile query
to take an additional boolean parameter nfs which
helps to query the vds for 2 types of stats
nfs and brick profile stats
Change-Id: I41d80dbb8b6865f67fcadf78baed2a813c423d03
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQueryTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeProfileParameters.java
3 files changed, 68 insertions(+), 9 deletions(-)
Approvals:
anmolbabu: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41d80dbb8b6865f67fcadf78baed2a813c423d03
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine : Refactored gluster volume profile VdsCommand
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine : Refactored gluster volume profile VdsCommand
......................................................................
engine : Refactored gluster volume profile VdsCommand
This patch refactors the volume profile vds command
to take an additional boolean parameter nfs which
helps to query the glusterfs for 2 types of stats
nfs and brick profile stats
Change-Id: I26cda9f8603e77296720f2dc062b94d5c10e7fd1
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProfileDetails.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileInfo.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/NfsProfileDetails.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeProfileInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
9 files changed, 176 insertions(+), 6 deletions(-)
Approvals:
anmolbabu: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26cda9f8603e77296720f2dc062b94d5c10e7fd1
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: missing final in VmInfoBuilderBase
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: missing final in VmInfoBuilderBase
......................................................................
core: missing final in VmInfoBuilderBase
Auto format fix
Change-Id: I2225ae8ccc2f7d404d7cc2997cfb42e75745bbcc
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2225ae8ccc2f7d404d7cc2997cfb42e75745bbcc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months