Change in ovirt-engine[ovirt-engine-3.4]: core: BaseImagesCommand - update disk volume type
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: BaseImagesCommand - update disk volume type
......................................................................
core: BaseImagesCommand - update disk volume type
BaseImagesCommand -> endSuccessfully: update disk's VolumeType/VolumeFormat.
Specifically in bug context, needed when moving a raw/thin provisioned disk
from file domain to block domain.
Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c
Bug-Url: https://bugzilla.redhat.com/1098258
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: tools: add snmp oid validation.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: add snmp oid validation.
......................................................................
tools: add snmp oid validation.
An oid is valid iff 2 <= size() <= 128 and if the first
two sub-identifiers are less than 3 and 40 respectively.
Emtpy values are not valid. a missing value already generates an
exception when getting property.
Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073498
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
mooli tayer: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: BaseImagesCommand - update disk volume type
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: BaseImagesCommand - update disk volume type
......................................................................
core: BaseImagesCommand - update disk volume type
BaseImagesCommand -> endSuccessfully: update disk's VolumeType/VolumeFormat.
Specifically in bug context, needed when moving a raw/thin provisioned disk
from file domain to block domain.
Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c
Bug-Url: https://bugzilla.redhat.com/1098258
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: history: updated network_name in dwh views
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: history: updated network_name in dwh views
......................................................................
history: updated network_name in dwh views
updated network_name to logical_network_name
in dhw views.
Change-Id: I9b3317062760a7d854ebb90ce6320cbeb73d98bb
Bug-Url: https://bugzilla.redhat.com/891073
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/dbscripts/create_dwh_views.sql
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Yaniv Dary: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b3317062760a7d854ebb90ce6320cbeb73d98bb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: removed unused member from command test
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: removed unused member from command test
......................................................................
core: removed unused member from command test
Removed unused member from RemoveDiskSnapshotsCommandTest
Change-Id: I4c88d40f0ecfa0235d0e801e2a8013e78bc29bd6
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandTest.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c88d40f0ecfa0235d0e801e2a8013e78bc29bd6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Added download_image to StepEnum for monitoring
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Added download_image to StepEnum for monitoring
......................................................................
core: Added download_image to StepEnum for monitoring
Added DOWNLOAD_IMAGE to StepEnum and ExecutionMessages
for proper task monitoring (currently used by
ImportRepoImageCopyTaskHandler and DownloadImageVDSCommand).
Change-Id: I2ee2669edff2d385d759fba3bf7caf77d89efecf
Related-To: https://bugzilla.redhat.com/1074311
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DownloadImageVDSCommand.java
4 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ee2669edff2d385d759fba3bf7caf77d89efecf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Mark management network as display and migration
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Mark management network as display and migration
......................................................................
core: Mark management network as display and migration
Introducing an upgrade script to mark the management network as
display and/or migration, if no other network in the cluster has that
role. This is implicitly the case anyway because when these roles
haven't been assigned they fall back to the management network, this
makes it explicit.
Also added code to assign the roles to the management network when
another network loses the role, or when a new cluster is created.
Change-Id: I73bf3c583ae28bf32d7c602ec9f4b0fb5c7f391d
Bug-Url: https://bugzilla.redhat.com/1023722
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java
A packaging/dbscripts/upgrade/03_05_0460_set_display_migration_cluster_network.sql
5 files changed, 61 insertions(+), 8 deletions(-)
Approvals:
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22382
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73bf3c583ae28bf32d7c602ec9f4b0fb5c7f391d
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine: Maintain lowercase mac addresses
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Maintain lowercase mac addresses
......................................................................
engine: Maintain lowercase mac addresses
The mac addresses used to be stored in lowercase.
This patch preserves that old behaviour.
Change-Id: Ia2fb0ce1baed6882381065a2cd3eec58ce60302a
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/27707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2fb0ce1baed6882381065a2cd3eec58ce60302a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-dwh[master]: history: Fixed sleep time for delete/aggregations
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: Fixed sleep time for delete/aggregations
......................................................................
history: Fixed sleep time for delete/aggregations
Fixed sleep time for interations of
DeleteTimeKeepingJob,HourlyTimeKeepingJob
and DailyTimeKeepingJob so it will run
at the correct time.
Change-Id: I1a1a05400812b41fa70bf618c03afb72a606f525
Bug-Url: https://bugzilla.redhat.com/1086389
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_5/DailyTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/deletetimekeepingjob_3_5/DeleteTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_5/HourlyTimeKeepingJob.java
M tos_project/process/DailyTimeKeepingJob_3.5.item
M tos_project/process/DailyTimeKeepingJob_3.5.properties
M tos_project/process/DeleteTimeKeepingJob_3.5.item
M tos_project/process/DeleteTimeKeepingJob_3.5.properties
M tos_project/process/HourlyTimeKeepingJob_3.5.item
M tos_project/process/HourlyTimeKeepingJob_3.5.properties
9 files changed, 2,054 insertions(+), 311 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a1a05400812b41fa70bf618c03afb72a606f525
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-node-plugin-vdsm[node-3.0]: engine_page: replace netinfo to xmlrpc
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: engine_page: replace netinfo to xmlrpc
......................................................................
engine_page: replace netinfo to xmlrpc
Currently ovirt-node-plugin-vdsm uses vdsm netinfo
module to consult data. However, if for some reason
the connection between vdsm and libvirt is not
available vdsm kills the caller. This patch will
replace the uses of netinfo to use xmlrpc via
vdscli module.
Change-Id: I2a1243342a5f46861940dda353798e3413587969
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097645
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 19 insertions(+), 8 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a1243342a5f46861940dda353798e3413587969
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months