Change in ovirt-reports[master]: reports: remove war file for new db
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: remove war file for new db
......................................................................
reports: remove war file for new db
updated abort, when clean install will remove
deployed files.
Change-Id: Iabf039c1ba864a1f3b7d84443e1bc4538919e6fd
Bug-Url: https://bugzilla.redhat.com/1072357
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28653
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabf039c1ba864a1f3b7d84443e1bc4538919e6fd
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[master]: core: Fix ConfigValues.SSHInactivityTimoutSeconds name
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix ConfigValues.SSHInactivityTimoutSeconds name
......................................................................
core: Fix ConfigValues.SSHInactivityTimoutSeconds name
Renames ConfigValues attribute SSHInactivityTimoutSeconds to
SSHInactivityTimeoutSeconds.
Change-Id: I1dcd2ecc787869892eb63a157b4efd0b468113f5
Bug-Url: https://bugzilla.redhat.com/1112036
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
4 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dcd2ecc787869892eb63a157b4efd0b468113f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[master]: core: [CDI] Introduce CDI for Commands dependencies
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: [CDI] Introduce CDI for Commands dependencies
......................................................................
core: [CDI] Introduce CDI for Commands dependencies
introducing the use of the powerfull yet light weld framework for
injecting dependencies to our Command objects.
command object are not EJBs and they have no reason to be ones.
Yet they carry lots of dependencies although they are a cardinal part of
the system they are hard to test.
using weld's tools we can inject dependencies programmaticly, letting
weld figure out how to fulfill all annotated fields.
this means the CommandFactory is responsible for instantiating a new
instance and dependency injection (as long as commands are not CDI
beans)
@See
InjectionHelper
a helper with a refrence to weld's bean manager which
we fullfuill dependecies programmatically with
jboss-deplpoyment-structure.xml
The mechanism jboss uses to define additional mofules/dependencies that
help discover beans inside modules. nessecary for cross-module
resolution (e.g inject a utils/Logger to bll/CommandBase
META-INF/beans.xml
a marker file to signal the deployment scanner to start bean discovery
on the jar/war/ear (for war file it should be under WEB-INF/beans.xml)
FUTURE (following patches)
* All singletons will move to be @ApplicationScopped beans
* Commands will never use dependecies inside the constructre. all init
goes into @postConstruct method
* No JNDI usage - all can be injected instead
* No EJB beans - unless out use-case is relevant
* create empty META-INF/beans.xml file.
* create default empty consturctor for Backend
Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
A backend/manager/modules/bll/src/main/resources/META-INF/beans.xml
M backend/manager/modules/common/pom.xml
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Injector.java
M backend/manager/modules/common/src/main/modules/org/ovirt/engine/core/common/main/module.xml
A backend/manager/modules/common/src/main/resources/META-INF/beans.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/LogFactory.java
A ear/src/main/application/META-INF/jboss-deployment-structure.xml
M packaging/services/ovirt-engine/ovirt-engine.xml.in
M pom.xml
14 files changed, 193 insertions(+), 4 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: use Collections.newHashSet instead of apache.mina
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: use Collections.newHashSet instead of apache.mina
......................................................................
core: use Collections.newHashSet instead of apache.mina
Change-Id: I8135e30fb0514f0c7963a8ae403b3043c461cce8
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
Kobi Ianko: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8135e30fb0514f0c7963a8ae403b3043c461cce8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[master]: engine: Do not access storage domain for gluster only hosts
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Do not access storage domain for gluster only hosts
......................................................................
engine: Do not access storage domain for gluster only hosts
Gluster hosts are moved to non-operation as they cannot
access the storage domain. This check is not necessary
for gluster hosts
Change-Id: Ic6e9c02bf68146975987c6cb48cccf5c198a2e5b
Bug-Url: https://bugzilla.redhat.com/1105513
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M packaging/dbscripts/vds_sp.sql
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sahina Bose: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6e9c02bf68146975987c6cb48cccf5c198a2e5b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: engine: skip cpu checks when moving host to gluster-cluster
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: skip cpu checks when moving host to gluster-cluster
......................................................................
engine: skip cpu checks when moving host to gluster-cluster
While moving a host from one cluster to another cluster,
cpu and architecture will be checked only if the target
cluster supports virtualization.
Change-Id: I785fce50e730743bfd3dcc28773a37e8eb33f82e
Bug-Url: https://bugzilla.redhat.com/1106459
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kanagaraj M: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I785fce50e730743bfd3dcc28773a37e8eb33f82e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: restapi : RestApi to export volume profile to pdf
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi : RestApi to export volume profile to pdf
......................................................................
restapi : RestApi to export volume profile to pdf
RestApi to export volume profile to pdf
Change-Id: Ie3ff28f5cf18bd7a2bcb53a169873fe6ae3541ed
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
A backend/manager/dependencies/src/main/modules/org/apache/avalon/framework/main/module.xml
A backend/manager/dependencies/src/main/modules/org/apache/commons/io/main/module.xml
A backend/manager/dependencies/src/main/modules/org/apache/xmlgraphics/batik/main/module.xml
A backend/manager/dependencies/src/main/modules/org/apache/xmlgraphics/commons/main/module.xml
A backend/manager/dependencies/src/main/modules/org/apache/xmlgraphics/fop/main/module.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/pdf/FOPMessageBodyWriter.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ApiMediaType.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java
A backend/manager/modules/restapi/interface/definition/src/main/resources/GlusterVolumeProfileDetailsAsPdf.xsl
M backend/manager/modules/restapi/interface/definition/src/main/resources/META-INF/services/javax.ws.rs.ext.Providers
M backend/manager/modules/restapi/jaxrs/pom.xml
M ear/src/main/resources/META-INF/MANIFEST.MF
M ovirt-engine.spec.in
M pom.xml
16 files changed, 632 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3ff28f5cf18bd7a2bcb53a169873fe6ae3541ed
Gerrit-PatchSet: 36
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: bll: LoginBaseCommand cleanup: findbugs issues
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bll: LoginBaseCommand cleanup: findbugs issues
......................................................................
bll: LoginBaseCommand cleanup: findbugs issues
it actually found one old bug...
Topic: AAA
Change-Id: Ia82aed06df510d0f4d4b5c062cf5543f94372f74
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia82aed06df510d0f4d4b5c062cf5543f94372f74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: bll: LoginBaseCommand cleanup: avoid using object state
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bll: LoginBaseCommand cleanup: avoid using object state
......................................................................
bll: LoginBaseCommand cleanup: avoid using object state
there is no reason to use object state as helper to avoid parameter
passing, per single flow.
in some control paths variables were not set.
Topic: AAA
Change-Id: I6bda9adef3630f8e2f7e4da90838261f20a52ea0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginAdminUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
2 files changed, 21 insertions(+), 27 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29050
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bda9adef3630f8e2f7e4da90838261f20a52ea0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[master]: core: removal of unneeded line in fixtures.xml
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: removal of unneeded line in fixtures.xml
......................................................................
core: removal of unneeded line in fixtures.xml
Change-Id: I76c6c9a1a7af24b053d2da999830b2a9d9593207
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76c6c9a1a7af24b053d2da999830b2a9d9593207
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months