Change in ovirt-engine[master]: aaa: Convert list of ldap server names to URIs
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Convert list of ldap server names to URIs
......................................................................
aaa: Convert list of ldap server names to URIs
Convert list of ldap server names contained in ConfigValue.LdapServers
to list of URIs stored in extension config under key "config.LdapServers"
during kerberosldap extension startup.
Topic: AAA
Change-Id: Ic436192e0072af09c4be1cfaa78c9e5bb66743ad
Bug-Url: https://bugzilla.redhat.com/1111071
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java
1 file changed, 14 insertions(+), 8 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic436192e0072af09c4be1cfaa78c9e5bb66743ad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: aaa: Server in LdapServers option are separated by '; '
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Server in LdapServers option are separated by ';'
......................................................................
aaa: Server in LdapServers option are separated by ';'
LDAP servers in ConfigValue.LdapServers option are separated by
semicolon.
Topic: AAA
Change-Id: I5da2f60b889febb6fba7d8a06a1830f573802106
Bug-Url: https://bugzilla.redhat.com/1111071
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5da2f60b889febb6fba7d8a06a1830f573802106
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: aaa: Add LdapServers into domain separated config values
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Add LdapServers into domain separated config values
......................................................................
aaa: Add LdapServers into domain separated config values
1) Adds LdapServers into domain separated config values
(EngineExtensionsManager.multipleValuesKeys)
2) LdapServers value may be empty, which is valid in case
that --ldap-servers in engine-manage-domains was not specified,
so EngineExtensionsManager.getValue was adapted to support empty
values
Topic: AAA
Change-Id: I9ff932f1a8dec1ba2f9c834e4e62601202ee97ec
Bug-Url: https://bugzilla.redhat.com/1111071
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java
1 file changed, 15 insertions(+), 12 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ff932f1a8dec1ba2f9c834e4e62601202ee97ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: aaa: Fix the name of property for list of ldap servers
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Fix the name of property for list of ldap servers
......................................................................
aaa: Fix the name of property for list of ldap servers
Fixes the name property for list of ldap servers to be the same as
in ConfigValue -> "LdapServers" (of course in aaa part with prefix
"config."
Topic: AAA
Change-Id: I796385144fb163d2ddf0298bcb653cf88bc77772
Bug-Url: https://bugzilla.redhat.com/1111071
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28968
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I796385144fb163d2ddf0298bcb653cf88bc77772
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: write answer file also on error
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: write answer file also on error
......................................................................
packaging: setup: write answer file also on error
previously answer file was not written if an error occurred
at customization or if user did not accept configuration preview.
Also the answer file was not updated with late values asked at
closeup stage if an error occurred in that stage.
Now the answer file is always written.
Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca
Bug-Url: https://bugzilla.redhat.com/1055497
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/core/answerfile.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/28900
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-node-plugin-vdsm[node-3.0]: hooks: Add hook for ovirt-node boot
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: hooks: Add hook for ovirt-node boot
......................................................................
hooks: Add hook for ovirt-node boot
Configure VDSM every boot to avoid error
on upgrades which vdsm configuration files might
bring different header/footer versions.
Requires http://gerrit.ovirt.org/#/c/28953/
Change-Id: I793d21768c103547cd8082e5353c074245c54535
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1101215
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M hooks/Makefile.am
M hooks/README
A hooks/on-boot/01-vdsm-configure
M ovirt-node-plugin-vdsm.spec.in
4 files changed, 27 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I793d21768c103547cd8082e5353c074245c54535
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-node-plugin-vdsm[master]: hooks: Add hook for ovirt-node boot
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: hooks: Add hook for ovirt-node boot
......................................................................
hooks: Add hook for ovirt-node boot
Configure VDSM every boot to avoid error
on upgrades which vdsm configuration files might
bring different header/footer versions.
Requires http://gerrit.ovirt.org/#/c/28953/
Change-Id: I793d21768c103547cd8082e5353c074245c54535
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1101215
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M hooks/Makefile.am
M hooks/README
A hooks/on-boot/01-vdsm-configure
M ovirt-node-plugin-vdsm.spec.in
4 files changed, 27 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28962
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I793d21768c103547cd8082e5353c074245c54535
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: removed unused methods from AsyncDataProvider
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: removed unused methods from AsyncDataProvider
......................................................................
webadmin: removed unused methods from AsyncDataProvider
AsyncDataProvider -> removed redundant methods.
Change-Id: I5615bf224da3e2987d2157ff30dafc0c27da0cae
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 0 insertions(+), 132 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/28927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5615bf224da3e2987d2157ff30dafc0c27da0cae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: DiscoverTargetsView - remove redundant styling
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DiscoverTargetsView - remove redundant styling
......................................................................
webadmin: DiscoverTargetsView - remove redundant styling
'discoverTargetsButton' class doesn't exist; hence, styling
is redundant.
Change-Id: I869885c35f8d788647bd9c3da8a10302b2069a5b
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/28926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I869885c35f8d788647bd9c3da8a10302b2069a5b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: remove redundant methods in ImportEntityData
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: remove redundant methods in ImportEntityData
......................................................................
webadmin: remove redundant methods in ImportEntityData
Remove redundant setEntity/getEntity methods from
ImportEntityData (to avoid warning [1]).
[1] "CID 1223214: Missing call to superclass (CALL_SUPER)"
Change-Id: Ifdb7706da4976bb889d2a5b1cee498746619dbc9
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportEntityData.java
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/28925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdb7706da4976bb889d2a5b1cee498746619dbc9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months