Change in ovirt-engine[master]: core: MacPoolManager strategy, alternative implementation
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: MacPoolManager strategy, alternative implementation
......................................................................
core: MacPoolManager strategy, alternative implementation
* introduced new alternative implentation of MacPoolManager
which is less eager browsing its internal structures and
less in need of RAM. There is still need of counting how many
times is each MAC used, but duplicate MAC address is something which
is not expected to occur very often. BitSet is used to store whether
is MAC used or not, and if it has usage higher than 1, pair
MAC<-->count is stored in Map. Counts of user specified MAC outside
from that MAC range are
still stored in HashMap, but modifiable int wrappers are used
instead of java.lang.Integer to cut down calls to HashMap.
*user can input multiple MAC ranges and original implementation
dealt with duplicates using HashSet, which means potentially lot
of unnecessary effort and copying data in RAM from one place to
another. New class RangesWithoutOverlaps was introduced, which
takes user input and transfors it into N intervals
(as few as possible) without overlaps.
*MacPoolManager is singleton; only 'getInstance()' has to be
static other methods should be instance methods. Having them
static is mixing concepts.
Change-Id: I69a5c1b3b43966e49fa6039597c06966ce514618
Bug-Url: https://bugzilla.redhat.com/1063064
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerOriginal.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerStrategy.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacsStorage.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ObjectCounter.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/Range.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/RangeTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java
10 files changed, 682 insertions(+), 401 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26405
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69a5c1b3b43966e49fa6039597c06966ce514618
Gerrit-PatchSet: 32
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine: Add compensation for storage pool in RemoveStoragePo...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add compensation for storage pool in RemoveStoragePoolCommand
......................................................................
engine: Add compensation for storage pool in RemoveStoragePoolCommand
Change-Id: I491966e1901f5e792ebb57db65e1e076bebaddaf
Bug-Url: https://bugzilla.redhat.com/1087577
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
1 file changed, 17 insertions(+), 10 deletions(-)
Approvals:
Yevgeny Zaspitsky: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I491966e1901f5e792ebb57db65e1e076bebaddaf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in jenkins[master]: Added job to deploy the yamls
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added job to deploy the yamls
......................................................................
Added job to deploy the yamls
Improved a bit also the defaults.
Change-Id: I40a1e90fdbf9766cfdf8827c6daf79df270cee47
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
R jobs/confs/shell-scripts/jenkins_check_yaml.sh
A jobs/confs/shell-scripts/jenkins_deploy_yamls.sh
M jobs/confs/yaml/defaults/defaults.yaml
R jobs/confs/yaml/jobs/jenkins_check_yaml.yaml
A jobs/confs/yaml/jobs/jenkins_deploy_yamls.yaml
5 files changed, 44 insertions(+), 3 deletions(-)
Approvals:
Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40a1e90fdbf9766cfdf8827c6daf79df270cee47
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: npe on add storage domain flow
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: npe on add storage domain flow
......................................................................
webadmin: npe on add storage domain flow
'activateDomain' flag should be passed to parameters only on import domain
flow (when not null).
Change-Id: Icb0469654ccdffa4b113037872f5392155fd1494
Bug-Url: https://bugzilla.redhat.com/1106458
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/28826
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb0469654ccdffa4b113037872f5392155fd1494
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: handle down VM in separate thread on destroy
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: handle down VM in separate thread on destroy
......................................................................
core: handle down VM in separate thread on destroy
We used to execute the handling of down VM in a new transaction in
DestroyVmVDSCommand so it won't be affected by the current transaction.
Now that this handling is made on a different thread, there is no need
for the new transaction anymore.
Change-Id: I1f20edfece133465aade00127ff973da9b726975
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
1 file changed, 2 insertions(+), 20 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/28222
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f20edfece133465aade00127ff973da9b726975
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: data copied from incorrect source
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: data copied from incorrect source
......................................................................
webadmin: data copied from incorrect source
when the custom instance type is selected and the template selection changes,
the data has been copied always from the newly selected template.
This is not always correct. The problem is on edit VM/pool when the VM can
already have some fields changed comparing to the template and the source has
to be the VM/pool itself.
The logic deciding about the appropriate source has already been implemented in
the getSource() method and was used in updateFields() which is supposed to be
called at the end of the initialization of the dialog. They were some race
situations when the updateFields() has been called before the setSelectedItem
on the template causing incorrect data to be copied to the dialog.
Fixed by using the proper getSource() instead of hardcoded usage of the
selected template.
Change-Id: I3f0114e7fb5741694127d5ab50b6953e98c58139
Bug-Url: https://bugzilla.redhat.com/1104318
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28834
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f0114e7fb5741694127d5ab50b6953e98c58139
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: restapi: IO exception mapper
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: IO exception mapper
......................................................................
restapi: IO exception mapper
This patch introduces a new message body reader that generates always an
IO exception, containing the cause of the error, and a generic exception
mapper that takes that IO exception, extracts the cause and generates
the corresponding message.
Change-Id: Id63e6eee673723ac32e3c2740f338f7ca465c6ac
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/pom.xml
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/xml/JAXBMessageBodyReader.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/xml/JAXBValidationEventHandler.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/META-INF/services/javax.ws.rs.ext.Providers
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/IOExceptionMapper.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/InvalidValueExceptionMapper.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/XmlMessageBodyReader.java
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
9 files changed, 263 insertions(+), 104 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id63e6eee673723ac32e3c2740f338f7ca465c6ac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: start PM enabled hosts after engine restart
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: start PM enabled hosts after engine restart
......................................................................
core: start PM enabled hosts after engine restart
This patch handles the following scenario
host non-responding->Restart->Stop->off->engine restart
In this case the host will not be started again after the engine is up.
This patch handle such scenarios by searching for hosts that both have
PM enabled and are in 'Reboot' status after the
DisableFenceAtStartupInSec quite time in which PM operations are
skipped.
If such hosts are found after the quite time, an attempt to start the
host via its PM card is executed.
Since the status of a Host is moved to 'Reboot' when it is restarted
just after the Stop command (Reboot=stop->wait for off->start->wait for
on), if the engine fails or stopped at this point the Host will be left
in the Reboot status.
Change-Id: Ibbfe83535364556df72eaac348e58d4b7146156e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005756
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
3 files changed, 76 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28305
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbfe83535364556df72eaac348e58d4b7146156e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: Remove useless prefix in variable name
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Remove useless prefix in variable name
......................................................................
webadmin: Remove useless prefix in variable name
Change-Id: I8b4382cd3a2f22cd32c367c4cdc89fbbe7520336
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderNetworkListModel.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Lior Vernia: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/28789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b4382cd3a2f22cd32c367c4cdc89fbbe7520336
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: runMultipleActions - disable aggregateErrors
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: runMultipleActions - disable aggregateErrors
......................................................................
webadmin: runMultipleActions - disable aggregateErrors
When 'failureCallback != null', aggregateErrors should be disabled
to allow invocation of an error dialog. Otherwise, on sequentially
running multiple actions of different types, no error
message is being displayed; as a failure in a sequential run
should break the chain and invoke an error dialog rather than
aggregate errors.
A scenario for example: add storage domain dialog ->
enter an invalid nfs path - the execution error dialog
is missing.
Change-Id: Ib7331889f56dc7da7460390411ee3ce9f3604973
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7331889f56dc7da7460390411ee3ce9f3604973
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months