June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: engine: Persist empty QoS for VM
by oourfali＠redhat.com 16 Jun '14

16 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Persist empty QoS for VM ...................................................................... engine: Persist empty QoS for VM This has been fixed previously for host QoS but not for VMs; in case no QoS is assigned to a profile, an empty entry is sent (rather than no entry). Change-Id: Iffe16ac863d338aa82cab1248b8fb1769ac7fcd3 Bug-Url: https://bugzilla.redhat.com/1105080 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 12 insertions(+), 14 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe16ac863d338aa82cab1248b8fb1769ac7fcd3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix rsdl generation for move and copy disk
by juan.hernandez＠redhat.com 16 Jun '14

16 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: fix rsdl generation for move and copy disk ...................................................................... restapi: fix rsdl generation for move and copy disk Move/Copy actions have been missing under '/api/disks/{disk:id}'; hence: * Changed 'DisksResource -> getDeviceSubResource' return type to MovableCopyableDiskResource. * Added missing '-' prefix in rsdl_metadata. Change-Id: I4fc36ea6e8042f3632da8f03f8a009e9f5bce857 Bug-Url: https://bugzilla.redhat.com/1097681 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DisksResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/28778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fc36ea6e8042f3632da8f03f8a009e9f5bce857 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: expose the host live snapshot support
by juan.hernandez＠redhat.com 16 Jun '14

16 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: expose the host live snapshot support ...................................................................... restapi: expose the host live snapshot support this patch reports the QEMU live snapshot support through the REST API. The live snapshot support is provided by the QEMU binary, so it is not expected to change often, and it is not configurable. Change-Id: I7c1f162195d639955a3e324ac0f52dae97ecaa13 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c1f162195d639955a3e324ac0f52dae97ecaa13 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: VirtIO RNG in instance types
by juan.hernandez＠redhat.com 16 Jun '14

16 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: VirtIO RNG in instance types ...................................................................... restapi: VirtIO RNG in instance types Change-Id: I7c0486c899f237c88aff8d137f963c57ff00dd95 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java 6 files changed, 40 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/28692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c0486c899f237c88aff8d137f963c57ff00dd95 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: VirtIO RNG device in instance types
by tjelinek＠redhat.com 16 Jun '14

16 Jun '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: VirtIO RNG device in instance types ...................................................................... frontend: VirtIO RNG device in instance types This patch adds RNG device to instance types. (Attached/detached icon is added only to RNG enabled/disabled checkbox). Change-Id: I4d4eadff40f9a855d9ad8a1c42909d0ae7dfc09a Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeAttachDetachManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 7 files changed, 95 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/28691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d4eadff40f9a855d9ad8a1c42909d0ae7dfc09a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adjust RNG commands for instance type support
by tjelinek＠redhat.com 16 Jun '14

16 Jun '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Adjust RNG commands for instance type support ...................................................................... core: Adjust RNG commands for instance type support This small patch adjusts RNG commands so they ignore cluster level check when edited entity is instance type since instance types aren't bound to cluster. Change-Id: I5078c22b60a99d1907eede3927f589d1e94565e0 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java 3 files changed, 19 insertions(+), 5 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5078c22b60a99d1907eede3927f589d1e94565e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.4]: Fix win-guest-agent-build-exe.bat
by vfeenstr＠redhat.com 16 Jun '14

16 Jun '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Fix win-guest-agent-build-exe.bat ...................................................................... Fix win-guest-agent-build-exe.bat File paths must use backslashes. Change-Id: I24609f3afccd364ba2717e57cf241711f2461c91 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M ovirt-guest-agent/win-guest-agent-build-exe.bat 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24609f3afccd364ba2717e57cf241711f2461c91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Fix win-guest-agent-build-exe.bat
by vfeenstr＠redhat.com 16 Jun '14

16 Jun '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Fix win-guest-agent-build-exe.bat ...................................................................... Fix win-guest-agent-build-exe.bat File paths must use backslashes. Change-Id: I24609f3afccd364ba2717e57cf241711f2461c91 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M ovirt-guest-agent/win-guest-agent-build-exe.bat 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, but someone else must approve Vinzenz Feenstra: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24609f3afccd364ba2717e57cf241711f2461c91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improve Dynamic Query SQL generator
by oourfali＠redhat.com 16 Jun '14

16 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Improve Dynamic Query SQL generator ...................................................................... core: Improve Dynamic Query SQL generator Optimize SQL created by the dynamic query generator. Change-Id: I862873171c6753f8c8863c10c336e981e39dc8cb Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java M packaging/dbscripts/create_views.sql 9 files changed, 543 insertions(+), 195 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862873171c6753f8c8863c10c336e981e39dc8cb Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: Template admin don't get permission to add permissions
by shavivi＠redhat.com 16 Jun '14

16 Jun '14

Shahar Havivi has submitted this change and it was merged. Change subject: db: Template admin don't get permission to add permissions ...................................................................... db: Template admin don't get permission to add permissions in order to template admin to be able to add permission for users we need to give it manipulate-permissions and add-users-and-groups for manipulating active directory data Change-Id: Ib110c05f595bf87b89df1df56766137ffaef1fdc Bug-Url: https://bugzilla.redhat.com/1104233 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0710_add_manipulate_permissions_for_template_admin.sql 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib110c05f595bf87b89df1df56766137ffaef1fdc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0