June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: few fixes in MacAddressRangeUtils.java
by mkolesni＠redhat.com 16 Jun '14

16 Jun '14

Mike Kolesnik has submitted this change and it was merged. Change subject: core: few fixes in MacAddressRangeUtils.java ...................................................................... core: few fixes in MacAddressRangeUtils.java * encapsulated check whether multicast bit is set. * fixed use of stopAfter which stopped one iteration later than it should * encapsulated parsing MAC from string to long -- fixed exception handling * added methods for reverse trasnformation: long to string Change-Id: I098ade5fc3854ad23236abceebb87cc51908c65f Bug-Url: https://bugzilla.redhat.com/1063064 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java 2 files changed, 62 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I098ade5fc3854ad23236abceebb87cc51908c65f Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: long query response time while many simultaneously que...
by oourfali＠redhat.com 16 Jun '14

16 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: long query response time while many simultaneously queries are running ...................................................................... core: long query response time while many simultaneously queries are running we found the postgres running this function 'getdiskbydiskid' so many times when the engine started which makes disaster on the sys with 100% CPU utilization Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Bug-Url: https://bugzilla.redhat.com/1085408 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M packaging/dbscripts/disk_image_dynamic_sp.sql 5 files changed, 64 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Liran Zelkha: Verified Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: EntityModelTextAreaEditor add new line only at the end o...
by shavivi＠redhat.com 16 Jun '14

16 Jun '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: EntityModelTextAreaEditor add new line only at the end of the text ...................................................................... ui: EntityModelTextAreaEditor add new line only at the end of the text When editing TextArea and adding 'enter' to the text the enter is concatenation at the end of the text regardless of the cursor position. Change-Id: I8a390834a952a4ff41dacb150b58aacfaa680dde Bug-Url: https://bugzilla.redhat.com/1109330 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextAreaEditor.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a390834a952a4ff41dacb150b58aacfaa680dde Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: custom script doesn't persist sysprep
by shavivi＠redhat.com 16 Jun '14

16 Jun '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: custom script doesn't persist sysprep ...................................................................... ui: custom script doesn't persist sysprep VmInit custom script is mapped for Cloud-Init and Windows Sysprep. Sysprep doesn't persist to DB. also remove unusable css style for Windows Sysprep Bug-Url: https://bugzilla.redhat.com/1080002 Change-Id: I461d82d4ab2e8b940b37f8f9d3c03d5bc1b81df4 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I461d82d4ab2e8b940b37f8f9d3c03d5bc1b81df4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add missing enum localization
by alkaplan＠redhat.com 16 Jun '14

16 Jun '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add missing enum localization ...................................................................... webadmin: Add missing enum localization VdcObjectType.Network wasn't properly localized. Change-Id: I4fadef418d438988e15a6354ad6af60f3eb8eee7 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fadef418d438988e15a6354ad6af60f3eb8eee7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix NPE in SafeHtmlWithSafeHtmlTooltipColumn
by alkaplan＠redhat.com 16 Jun '14

16 Jun '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fix NPE in SafeHtmlWithSafeHtmlTooltipColumn ...................................................................... webadmin: Fix NPE in SafeHtmlWithSafeHtmlTooltipColumn It was assumed that the tooltip couldn't be null, but this was apparently wrong in some case. Change-Id: I34e8d63dab5e5da6edecdd8323ec667e4fe0a3d9 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34e8d63dab5e5da6edecdd8323ec667e4fe0a3d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: util for removing overlaps in ranges
by mkolesni＠redhat.com 16 Jun '14

16 Jun '14

Mike Kolesnik has submitted this change and it was merged. Change subject: core: util for removing overlaps in ranges ...................................................................... core: util for removing overlaps in ranges user defined MacPool ranges can contain overlaps. Previously this was handled by adding each MAC from each mac range into HashSet. This was inefficient and can cause lot of MACs being initialized pointlessly. This util takes N ranges and transform it into M ranges (M<=N) where are no overlaps. Change-Id: Id7dbacd11b610a5885d574356a695c6e879dcdbc Bug-Url: https://bugzilla.redhat.com/1063064 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/DisjointRanges.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DisjointRangesTest.java 2 files changed, 126 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7dbacd11b610a5885d574356a695c6e879dcdbc Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: StorageRegisterEntityListModel - extract syncSearch
by derez＠redhat.com 15 Jun '14

15 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageRegisterEntityListModel - extract syncSearch ...................................................................... webadmin: StorageRegisterEntityListModel - extract syncSearch Extracted logic of syncSearch to StorageRegisterEntityListModel. Change-Id: Ia9cb6a096c61be38acfc3c93dc7399fdcfc506df Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterEntityListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterVmListModel.java 3 files changed, 29 insertions(+), 50 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/28764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9cb6a096c61be38acfc3c93dc7399fdcfc506df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: storage quota in import VM from data SD dialog
by derez＠redhat.com 15 Jun '14

15 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: storage quota in import VM from data SD dialog ...................................................................... webadmin: storage quota in import VM from data SD dialog Import VM/Template from data SD dialog: introduced storage quota column. Change-Id: I1bb85c0f5bee8a06c967a50e6309ff28c3ea3dfd Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterEntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportEntityData.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterTemplateInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmPopupView.java 10 files changed, 182 insertions(+), 44 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/28729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bb85c0f5bee8a06c967a50e6309ff28c3ea3dfd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixed assign quota to disks in register Template
by derez＠redhat.com 15 Jun '14

15 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fixed assign quota to disks in register Template ...................................................................... core: fixed assign quota to disks in register Template Fixed assign storage quota to disks in register Template. Change-Id: Id8287a4b777ec1fe01bbd99ae7be10738732471f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8287a4b777ec1fe01bbd99ae7be10738732471f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0