June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use formatter for AttachStorageDomainToPoolCommandTest
by mlipchuk＠redhat.com 26 Jun '14

26 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use formatter for AttachStorageDomainToPoolCommandTest ...................................................................... core: Use formatter for AttachStorageDomainToPoolCommandTest Use formatter for AttachStorageDomainToPoolCommandTest Change-Id: I10c682a8cb123320da3e3cf2453ee1ea3a3091c5 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10c682a8cb123320da3e3cf2453ee1ea3a3091c5 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding support for TarInMemoryExport
by mlipchuk＠redhat.com 26 Jun '14

26 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding support for TarInMemoryExport ...................................................................... core: Adding support for TarInMemoryExport Adding a utility to retrieve OVF data of entities from a tar file. Change-Id: Ie4fbc12337c16baca4be8a82d4a51b8b3ab0af4a Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/TarInMemoryExport.java 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4fbc12337c16baca4be8a82d4a51b8b3ab0af4a Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: kdump: Remove kexec-tools check from offlinepackager
by Alon Bar-Lev 26 Jun '14

26 Jun '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: kdump: Remove kexec-tools check from offlinepackager ...................................................................... kdump: Remove kexec-tools check from offlinepackager Removes kexec-tools package check from offlinepackager, so for now kdump detection is completely disabled for oVirt Node hosts. Change-Id: I7d53b0467f8f2663f42a7665e1cfe611ca66546f Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M src/plugins/ovirt-host-deploy/core/offlinepackager.py 1 file changed, 0 insertions(+), 29 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved Martin Peřina: Verified -- To view, visit http://gerrit.ovirt.org/29282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d53b0467f8f2663f42a7665e1cfe611ca66546f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding SANState for Storage Domain Static
by mlipchuk＠redhat.com 26 Jun '14

26 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding SANState for Storage Domain Static ...................................................................... core: Adding SANState for Storage Domain Static Adding transitive attribute of SANState to Storage Domain Static, so it will be initialized when calling vdsCommand HSMGetStorageDomainInfoVDSCommand. Change-Id: I044676a8707846a51e9028dc67410d3ee944c747 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I044676a8707846a51e9028dc67410d3ee944c747 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: updateAllInBatch - pass sorted collection
by amureini＠redhat.com 26 Jun '14

26 Jun '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: updateAllInBatch - pass sorted collection ...................................................................... core: updateAllInBatch - pass sorted collection Currently the passed collection is sorted in updateAllInBatch to avoid possible deadlock but it isn't passed to the actual method that performs the update. Change-Id: I30f23e9aecd5a20063ba42ff4e1170c21b1bb675 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30f23e9aecd5a20063ba42ff4e1170c21b1bb675 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: avoid deadlocks on images related updated
by amureini＠redhat.com 26 Jun '14

26 Jun '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: avoid deadlocks on images related updated ...................................................................... core: avoid deadlocks on images related updated Currently VdsUpdateRuntimeInfo updates the disc_image_dynamic table according to the statistics retreived from the running vms. Those updates are executed in a batchUpdate call, which currently executes all the updates within the same transaction, as there is a FK between the disk_image_dynamic on postgres version earlier than 9.3 a lock will be taken on the referenced row which means that any other concurrent operation on those images may cause to a deadlock unless they are sorted. Sorting the images on all the flows in more tricky and unneeded as this issue has been resolved in postgres 9.3 (http://www.postgresql.org/docs/9.3/static/release-9-3.html) in the meanwhile we can drop the fk constraint and delete the records by adding trigger. Change-Id: Ifa160402787a7902169ab5fd3ce6661918fdebb2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1112720 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0730_drop_disk_image_dynamic_fk.sql 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa160402787a7902169ab5fd3ce6661918fdebb2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: kdump: Fix required kexec-tools versions
by Alon Bar-Lev 26 Jun '14

26 Jun '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: kdump: Fix required kexec-tools versions ...................................................................... kdump: Fix required kexec-tools versions Fixes required kexec-tools versions to RPMs provided on oVirt repositories so kdump detection feature will be available for RHEL 6/7 host before RHEL 6.6/7.1 release. Change-Id: I807f308d22616dd044a1318339564d3a7ebbb1e9 Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-host-deploy-offline.spec.in M src/plugins/ovirt-host-deploy/kdump/packages.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved Martin Peřina: Verified -- To view, visit http://gerrit.ovirt.org/29308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I807f308d22616dd044a1318339564d3a7ebbb1e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: use Java naming convention
by amureini＠redhat.com 26 Jun '14

26 Jun '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: use Java naming convention ...................................................................... core: use Java naming convention In CreateSnapshotCommand changed mnewCreatedDiskImage data member to newDiskImage. Also dropped the 'Created' for a shorter name, which is just as clear. Change-Id: I614acc66ff631202b786f65daa2451803304ba4d Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 3 files changed, 43 insertions(+), 43 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I614acc66ff631202b786f65daa2451803304ba4d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup - Removed unused code.
by amureini＠redhat.com 26 Jun '14

26 Jun '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: cleanup - Removed unused code. ...................................................................... core: cleanup - Removed unused code. CreateSnapshotCommand.getImagesContainterParameters() is not used. Now removed. Change-Id: I74f155cb0facdfb52095de21e2daaff7c3b44708 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/29262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f155cb0facdfb52095de21e2daaff7c3b44708 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: replace regexp validation for user email.
by oourfali＠redhat.com 26 Jun '14

26 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: replace regexp validation for user email. ...................................................................... core: replace regexp validation for user email. validating using an ad-hock regexp may cause problems(see bug). using strict java.mail.internetAddress() [1] for validation. This enforces some (but not all) RFC822 syntax. Using the strict form does not allow simple names (e.g 'user') but requires a domain. 'user@localhost' is now accepted. [1] https://javamail.java.net/nonav/docs/api/ Change-Id: I18904a669453baef632af1cd427b61852e7ab583 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109169 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/pom.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java 2 files changed, 22 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18904a669453baef632af1cd427b61852e7ab583 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0