Change in ovirt-engine[ovirt-engine-3.4]: restapi:Fix CRUD operations for iSCSI Storage connection.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: restapi:Fix CRUD operations for iSCSI Storage connection.
......................................................................
restapi:Fix CRUD operations for iSCSI Storage connection.
1) renaming class BackendIscsiBondStorageServerConnection to
BackendIscsiBondStorageConnectionResource to be compatible with the
plural resource name
2) Fix remove and get operations for Storage Connection in IscsiBond
3) Adding appropriate tests for resource commands in REST.
Usages:
Get a list of Storage Connections contained in the iSCSI bond:
Get
/api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/
Get a specific Storage Connection in the iSCSI bond:
Get
/api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/{storage_id}/
Adding a new Storage Connection to an existing iSCSI Bond:
POST /api/datacenters/{datacenter_id}/iscsibonds HTTP/1.1
Accept: application/xml
<storage_connection id="{connection_id}"></storage_connection>
Remove a Storage Connection from the existing iSCSi Bond:
DELETE
/api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/{storage_id}/
HTTP/1.1
Change-Id: I2424067b4371b6a99f61ea687155c4082855aff5
Bug-Url: https://bugzilla.redhat.com/1133896
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageServerConnection.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResourceTest.java
5 files changed, 288 insertions(+), 30 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/32129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2424067b4371b6a99f61ea687155c4082855aff5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: refresh system tree when removing last leaf
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: refresh system tree when removing last leaf
......................................................................
webadmin: refresh system tree when removing last leaf
- When removing the last element of a list the system
tree would not refresh. For instance removing the last
cluster from a data center. This patch fixes that issue.
Change-Id: If9e47bb6cbc5beb4da04b98c8f4b1c38c2932445
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127600
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9e47bb6cbc5beb4da04b98c8f4b1c38c2932445
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: fixed context-sensitive help icon
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fixed context-sensitive help icon
......................................................................
webadmin: fixed context-sensitive help icon
commit 42e9396 broke the context-sensitive help icon. Fixed.
Also moved the header text up one pixel to align with the
fixed icon.
Change-Id: Iff8f6605a89dad1f57b15a63de2ffa8e67825418
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
M packaging/branding/ovirt.brand/common.css
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
4 files changed, 22 insertions(+), 10 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/31856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff8f6605a89dad1f57b15a63de2ffa8e67825418
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: userportal: Remove the rng device tab from the instance creator
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: userportal: Remove the rng device tab from the instance creator
......................................................................
userportal: Remove the rng device tab from the instance creator
Change-Id: I7bda137580e68be0718c76434a59493d098d7d52
Bug-Url: https://bugzilla.redhat.com/1135462
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/32157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bda137580e68be0718c76434a59493d098d7d52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-live[ovirt-live-3.5]: packaging: setup: centos: fixed answer file
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: centos: fixed answer file
......................................................................
packaging: setup: centos: fixed answer file
Fixed answer file avoiding question about:
Configure Engine on this host (Yes, No)
Change-Id: I6d3c0176cefc6894773bb1f90b29f53cad3d36d7
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit b22a957f21d2219f69870fc45d298d7271af2107)
---
M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32162
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d3c0176cefc6894773bb1f90b29f53cad3d36d7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-live[master]: packaging: setup: centos: fixed answer file
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: centos: fixed answer file
......................................................................
packaging: setup: centos: fixed answer file
Fixed answer file avoiding question about:
Configure Engine on this host (Yes, No)
Change-Id: I6d3c0176cefc6894773bb1f90b29f53cad3d36d7
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d3c0176cefc6894773bb1f90b29f53cad3d36d7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-live[ovirt-live-3.5]: packaging: setup: centos: fixed otopi stages order
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: centos: fixed otopi stages order
......................................................................
packaging: setup: centos: fixed otopi stages order
Fixed otopi loop:
error: method
otopi.plugins.ovirt_engine_setup.olive.core.Plugin._createstorage
is in a later stage than method
otopi.plugins.ovirt_engine_setup.olive.core.Plugin._copyiso
although it depends on it
Fix ordering issue:
Failed to execute stage 'Closing up': 'Plugin' object has no attribute
'_engine_api'
Change-Id: I1be5eb6be1c9c9f78d0273f192c0e6edd3cc46f5
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 8b5d7d329f5bbdef8c4f477976b1e77884576957)
---
M centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1be5eb6be1c9c9f78d0273f192c0e6edd3cc46f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-live[master]: packaging: setup: centos: fixed otopi stages order
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: centos: fixed otopi stages order
......................................................................
packaging: setup: centos: fixed otopi stages order
Fixed otopi loop:
error: method
otopi.plugins.ovirt_engine_setup.olive.core.Plugin._createstorage
is in a later stage than method
otopi.plugins.ovirt_engine_setup.olive.core.Plugin._copyiso
although it depends on it
Fix ordering issue:
Failed to execute stage 'Closing up': 'Plugin' object has no attribute
'_engine_api'
Change-Id: I1be5eb6be1c9c9f78d0273f192c0e6edd3cc46f5
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1be5eb6be1c9c9f78d0273f192c0e6edd3cc46f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-live[ovirt-live-3.5]: packaging: setup: centos: fixed changes after engine split
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: centos: fixed changes after engine split
......................................................................
packaging: setup: centos: fixed changes after engine split
fixed references to constants moved around when making
engine an option.
Change-Id: I44f8508fef3cd275fdd5f34c4158579ae9e73608
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit ff4644fe1a6a98b4030fc292ae20ea74b5153ae9)
---
M centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
1 file changed, 14 insertions(+), 13 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44f8508fef3cd275fdd5f34c4158579ae9e73608
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-live[master]: packaging: setup: centos: fixed changes after engine split
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: centos: fixed changes after engine split
......................................................................
packaging: setup: centos: fixed changes after engine split
fixed references to constants moved around when making
engine an option.
Change-Id: I44f8508fef3cd275fdd5f34c4158579ae9e73608
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
1 file changed, 14 insertions(+), 13 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32139
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44f8508fef3cd275fdd5f34c4158579ae9e73608
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month