August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: extract constant from HibernateVmCommand
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: extract constant from HibernateVmCommand ...................................................................... core: extract constant from HibernateVmCommand META_DATA_SIZE_IN_BYTES was extracted to MemoryUtils due to use in several vm related commands, as well as need for it in another command in bz1119022 fix. Change-Id: I1604cf4a82e3e202093acdab97939427ab335169 Bug-Url: https://bugzilla.redhat.com/1119022 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 5 files changed, 12 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1604cf4a82e3e202093acdab97939427ab335169 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing missing (English) AuditLog values
by emesika＠redhat.com 31 Aug '14

31 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing missing (English) AuditLog values ...................................................................... core: fixing missing (English) AuditLog values Fixing the reported messages in the BZ A '+' sign marks that issue was addresses and a message was added a '-' sign marks that issue was not addressed with the reason UNASSIGNED + VDS_AUTO_FENCE_STATUS + VDS_AUTO_FENCE_STATUS_FAILED + VDS_AUTO_FENCE_FAILED_CALL_FENCE_SPM + VDS_HIGH_NETWORK_USE - Deprecated USER_FAILED_REMOVE_VM - Deprecated USER_RUN_UNLOCK_ENTITY_SCRIPT - Used only from SQL script therefor should not have severity & message VDS_NETWORK_MTU_DIFFER_FROM_LOGICAL_NETWORK - Deprecated VDS_HOST_IN_CONNECTING_STATE - handled in http://gerrit.ovirt.org/#/c/31886/ STORAGE_ACTIVATE_ASYNC - Deprecated DWH_STOPPED + DWH_STARTED + DWH_ERROR + USER_REMOVE_AUDIT_LOG + USER_REMOVE_AUDIT_LOG_FAILED + USER_CLEAR_ALL_DISMISSED_AUDIT_LOG + USER_CLEAR_ALL_DISMISSED_AUDIT_LOG_FAILED + Change-Id: I74a08a8c7d5f18707bf8cbcac5d9d169c5556def Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119186 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74a08a8c7d5f18707bf8cbcac5d9d169c5556def Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Checking isProvisioned instead of the redundant entity isDis...
by oourfali＠redhat.com 31 Aug '14

31 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: Checking isProvisioned instead of the redundant entity isDiscovered ...................................................................... Checking isProvisioned instead of the redundant entity isDiscovered isDiscovered was a mistake which checked only the textbox entity. The entity is filled with value when there are discovered host, so that check was wrong. This patch checks if the flow is for discovered or provisioning based on the isProvisioned entity, which is set when changing the radio buttons. Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133540 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: WARNING when failed to create OVF Store
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: WARNING when failed to create OVF Store ...................................................................... core: WARNING when failed to create OVF Store Changed audit log severity to WARNING to indicate that there's a problem here. Change-Id: I78171fd1890435c9f98efec88496e81e5f84b9ce Bug-Url: https://bugzilla.redhat.com/1134371 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78171fd1890435c9f98efec88496e81e5f84b9ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: null safe StorageDomainFreeSpaceRenderer
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: null safe StorageDomainFreeSpaceRenderer ...................................................................... webadmin: null safe StorageDomainFreeSpaceRenderer StorageDomainFreeSpaceRenderer: verify getAvailableDiskSize's value before rendering. Change-Id: Ica5bd15bb939ec86502e406dcdd56f4dcf604ac7 Bug-Url: https://bugzilla.redhat.com/1079710 Bug-Url: https://bugzilla.redhat.com/1132406 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5bd15bb939ec86502e406dcdd56f4dcf604ac7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix style misalignments in block domain view
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix style misalignments in block domain view ...................................................................... webadmin: fix style misalignments in block domain view Some alignment issues were introduced in block storage dialog and DirectLUN disk dialog (lists/tabs/etc) - see attached screenshots in BZ. Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Bug-Url: https://bugzilla.redhat.com/1133779 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 6 files changed, 12 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/32017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent incorrect down events on migration
by ahadas＠redhat.com 31 Aug '14

31 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent incorrect down events on migration ...................................................................... core: prevent incorrect down events on migration We are not supposed to produce audit log events when VM went down on a host which is different than the one it should run on. It should only happen when the VM is migrating. We used to eliminate such audit logs when the VM went down normally, from now on we will eliminate them also when the VM went down because of an error. Change-Id: I90b684e75972ca8eb384c33f7fab8b73640ada20 Bug-Url: https://bugzilla.redhat.com/1104195 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 5 insertions(+), 8 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b684e75972ca8eb384c33f7fab8b73640ada20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao ...................................................................... core: RemoveDiskSnapshot rollback - fetch disk by DiskDao RemoveDiskSnapshotTaskHandler -> * endWithFailure: Fetching a disk by imageGroupId should be done using DiskDao. * endRemoveSnapshotSingleDisk: update TaskGroupSuccess appropriately. Change-Id: I9b6d811a86c353087479de1fc25276be62df4bec Bug-Url: https://bugzilla.redhat.com/1134382 Bug-Url: https://bugzilla.redhat.com/1134434 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotTaskHandler.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b6d811a86c353087479de1fc25276be62df4bec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: clone VM from snapshot - validate VirtIO-SCSI
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: clone VM from snapshot - validate VirtIO-SCSI ...................................................................... core: clone VM from snapshot - validate VirtIO-SCSI Validate whether VirtIO-SCSI can be disabled when cloning a VM from snapshot (similar to the validation on UpdateVmCommand): * Added a validation method to VmValidator. * Added appropriate tests. Change-Id: I31d4ebe3a964fb54cb1a905460b9da785a746419 Bug-Url: https://bugzilla.redhat.com/1133475 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java 6 files changed, 137 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31d4ebe3a964fb54cb1a905460b9da785a746419 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use correct validation for SD selection
by amureini＠redhat.com 31 Aug '14

31 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use correct validation for SD selection ...................................................................... core: Use correct validation for SD selection When creating a snapshot, use new storage allocation validations for the vm volumes when selecting a domain. Some code has been removed as a result from this change. Change-Id: Iac901a638358b9b08bcc6992d783a42cbfcd9bfa Bug-Url: https://bugzilla.redhat.com/1119022 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/NullableMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/StatelessSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 7 files changed, 23 insertions(+), 76 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/31488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac901a638358b9b08bcc6992d783a42cbfcd9bfa Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0