Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix height of EntityModelWidgetWithInfo
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix height of EntityModelWidgetWithInfo
......................................................................
webadmin: Fix height of EntityModelWidgetWithInfo
Fixed the height to be the same as most other widgets, to correct all
sorts of layout issues. Also removed references to styles that no
longer exist.
Change-Id: Ia3a8381cf747609389f6c2ec806bef65d9248ee1
Bug-Url: https://bugzilla.redhat.com/1115524
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
(cherry picked from commit ca3d2e96fbeb2473b8e004043541ab4ee8fc8f5d)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3a8381cf747609389f6c2ec806bef65d9248ee1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: backend: sysprep custom variables should be in CDATA section
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: sysprep custom variables should be in CDATA section
......................................................................
backend: sysprep custom variables should be in CDATA section
for handling special characters we need to put all inputs inside xml
CDATA section.
Change-Id: I941e1422077383386ee788e75ae5ad38d1de39a2
Bug-Url: https://bugzilla.redhat.com/1122160
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M packaging/conf/sysprep/sysprep.2k12x64
M packaging/conf/sysprep/sysprep.2k8
M packaging/conf/sysprep/sysprep.2k8x64
M packaging/conf/sysprep/sysprep.w7
M packaging/conf/sysprep/sysprep.w7x64
M packaging/conf/sysprep/sysprep.w8
M packaging/conf/sysprep/sysprep.w8x64
7 files changed, 146 insertions(+), 146 deletions(-)
Approvals:
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31973
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I941e1422077383386ee788e75ae5ad38d1de39a2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: core: edit host "advanced" parameters to change protocol
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: edit host "advanced" parameters to change protocol
......................................................................
core: edit host "advanced" parameters to change protocol
Editting host protocol was no possible. This patch enables chaning
protocol for host in maintanace mode only. After the change connection
is closed and new protocol is used when reconnecting.
Bug-Url: https://bugzilla.redhat.com/1124442
Change-Id: I8cbd88616ae156209deb3b4841fa6a67d93267f0
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java
6 files changed, 22 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cbd88616ae156209deb3b4841fa6a67d93267f0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Do not suppress dismissed alerts
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Do not suppress dismissed alerts
......................................................................
core: Do not suppress dismissed alerts
No health check alert is issued in ui after first message was issued
This patch fixed a problem when an alert is dismissed by the user.
Current functionality did not addressed dismissed alerts and show for
each host instance one alert from each type.
In the case that the alert was dismissed by the user, it will not show
again.
This patch fix the SP that insert to audit log not to suppress the alert
in case that the alert exists for the host instance but it was dismissed
by the user (delete=true in audit_log table)
Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133611
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
(cherry picked from commit 57cb88b9b75e705504fd738dbcc1b9d4eac092c3)
---
M packaging/dbscripts/audit_log_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: add managed virtio-serial device when reading ovf
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: add managed virtio-serial device when reading ovf
......................................................................
core: add managed virtio-serial device when reading ovf
virtio-serial devices were written to OVF files before, so when we
import VM/Template and such device exist we'll just add it as managed
device (virtio-serial was added to the list of 'special devices').
It could be that OVF file was created before the unmanaged virtio-serial
device was added. In this case, we'll create a new managed virtio-serial
device for the imported VM/Template.
Change-Id: I08c8dc8514edf5b291017690c654f4a9e455a658
Bug-Url: https://bugzilla.redhat.com/1028387
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
4 files changed, 45 insertions(+), 6 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08c8dc8514edf5b291017690c654f4a9e455a658
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: rest: dont always use vm dynamic values
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: rest: dont always use vm dynamic values
......................................................................
rest: dont always use vm dynamic values
Currently, when getting vm, some fields always show the dynamic values
(if exists) which contains information that is relevant for the
current/last run, for example, if vm has SPICE as display type, but on
run-once the user choose VNC, VNC will be shown while the vm is running.
another scenario, when user start the vm with SPICE and after that
change to VNC, SPICE is always shown, even if user explicitly request
the next_run info.
in this patch another option is added to the mapper to allow the caller
to decide if he wants the dynamic value or not, and it is used for the
next_run scenario. all other cases were not changed.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128453
Change-Id: Iae643bd7f887171b389b71d31a36362ba0168709
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
2 files changed, 33 insertions(+), 16 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/32006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae643bd7f887171b389b71d31a36362ba0168709
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: frontend: Allow NLA auth for Native RDP execution
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Allow NLA auth for Native RDP execution
......................................................................
frontend: Allow NLA auth for Native RDP execution
This patch allows Network Level Authentication in combination with
Native RDP client. This is done by setting enablecredsspsupport flag in
RDP descriptor to 1.
Previously this flag was set to 0 which prevented clients to connect to
RDP server with NLA enabled.
This patch only affects 'Native client' invocation. The 'Browser plugin'
still has this option disabled (enabling it would prevent passing
password to ActiveX plugin and therefore SSO would be impossible).
Also RDP info icon text in 'Console options' dialog was enhanced with
information about NLA and SSO.
Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3
Bug-Url: https://bugzilla.redhat.com/1131693
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpNativeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IRdp.java
5 files changed, 14 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/32028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: Associate users only with managed groups by oVirt
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Associate users only with managed groups by oVirt
......................................................................
aaa: Associate users only with managed groups by oVirt
This patch will store at groupNames only groups that are managed
by Ovirt (i.e - groups that exist in the groups DB table).
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java
17 files changed, 67 insertions(+), 77 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: Engine should start even if exception occured in load o...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Engine should start even if exception occured in load of legacy provider
......................................................................
aaa: Engine should start even if exception occured in load of legacy provider
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129203
Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java
M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml
4 files changed, 27 insertions(+), 10 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: extmgr: Add logging for extension load/initialize
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: extmgr: Add logging for extension load/initialize
......................................................................
extmgr: Add logging for extension load/initialize
Easier to track what extension may misbehave.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
1 file changed, 12 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32024
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months