Change in ovirt-engine[master]: core: Modify CDA message when adding connection to iSCSI bond
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Modify CDA message when adding connection to iSCSI bond
......................................................................
core: Modify CDA message when adding connection to iSCSI bond
Modify a CDA message to also indicate the use case when user adds a
connection which already exists in the iSCSI bond.
Change-Id: Id66ef71008ed67901c388c82ec47d954e4ac60d7
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/31980
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id66ef71008ed67901c388c82ec47d954e4ac60d7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix NPE on ChangeCD with 'Down' VM
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix NPE on ChangeCD with 'Down' VM
......................................................................
core: Fix NPE on ChangeCD with 'Down' VM
Moved invocation of ImagesHandler.cdPathWindowsToLinux after check that
assures vm is running and storage domain available.
Change-Id: Ie3bf10dbeb8dd645a515dc140bd9081dc1d1acab
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067407
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
1 file changed, 19 insertions(+), 21 deletions(-)
Approvals:
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3bf10dbeb8dd645a515dc140bd9081dc1d1acab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: setting default protocol to jsonrpc again
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: setting default protocol to jsonrpc again
......................................................................
core: setting default protocol to jsonrpc again
Bug-Url: https://bugzilla.redhat.com/1131944
Change-Id: Ia0e98eb30e5411140a7618c38f56206f054cf891
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31981
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0e98eb30e5411140a7618c38f56206f054cf891
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: soundcard not persisted on new instance type
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: soundcard not persisted on new instance type
......................................................................
core: soundcard not persisted on new instance type
The problem was that the sondcard was persisted only when there was a cluster.
This is not the case for the instance type. Solved the same way as for the new
instance type (sending null cluster version).
Change-Id: I81d0adf9f8873e2e0b9c1a28c068c2de4ad59751
Bug-Url: https://bugzilla.redhat.com/1124270
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31767
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81d0adf9f8873e2e0b9c1a28c068c2de4ad59751
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: setting default protocol to jsonrpc again
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: setting default protocol to jsonrpc again
......................................................................
core: setting default protocol to jsonrpc again
Change-Id: Ia0e98eb30e5411140a7618c38f56206f054cf891
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0e98eb30e5411140a7618c38f56206f054cf891
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: Version update
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: jsonrpc: Version update
......................................................................
jsonrpc: Version update
Bug-Url: https://bugzilla.redhat.com/1131944
Change-Id: I506610619dcb61e5fd8a7cf7933183286c9a19bd
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32109
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I506610619dcb61e5fd8a7cf7933183286c9a19bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine-sdk[sdk_3.5]: codegen: Remove the Python code generator
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Remove the Python code generator
......................................................................
codegen: Remove the Python code generator
The Python code used to generate the SDK has been replaced by an
equivalent Java program.
Change-Id: Ic5a0ea85c62b904aa36781852189e5f7f49b1071
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
D src/codegen/__init__.py
D src/codegen/collection/__init__.py
D src/codegen/collection/collection.py
D src/codegen/collection/collectionexceptions.py
D src/codegen/common/__init__.py
D src/codegen/common/icodegen.py
D src/codegen/doc/__init__.py
D src/codegen/doc/documentation.py
D src/codegen/entrypoint/__init__.py
D src/codegen/entrypoint/entrypoint.py
D src/codegen/imprt/__init__.py
D src/codegen/imprt/imprt.py
D src/codegen/infrastructure/__init__.py
D src/codegen/infrastructure/staticdataholder.py
D src/codegen/main.py
D src/codegen/resource/__init__.py
D src/codegen/resource/resource.py
D src/codegen/rsdl/__init__.py
D src/codegen/rsdl/abstractrsdlcodegen.py
D src/codegen/rsdl/rsdlcodegen.py
D src/codegen/subcollection/__init__.py
D src/codegen/subcollection/subcollection.py
D src/codegen/subresource/__init__.py
D src/codegen/subresource/subresource.py
D src/codegen/templates/__init__.py
D src/codegen/templates/abstracttemplate.py
D src/codegen/templates/collectionaddtemplate
D src/codegen/templates/collectionaddtemplate.py
D src/codegen/templates/collectiongetcapabilitiestemplate
D src/codegen/templates/collectiongetcapabilitiestemplate.py
D src/codegen/templates/collectiongetdiskstemplate
D src/codegen/templates/collectiongetdiskstemplate.py
D src/codegen/templates/collectiongetnotsearchabletemplate
D src/codegen/templates/collectiongetnotsearchabletemplate.py
D src/codegen/templates/collectiongetsearchabletemplate
D src/codegen/templates/collectiongetsearchabletemplate.py
D src/codegen/templates/collectionlistcapabilitiestemplate
D src/codegen/templates/collectionlistcapabilitiestemplate.py
D src/codegen/templates/collectionlistnotsearchabletemplate
D src/codegen/templates/collectionlistnotsearchabletemplate.py
D src/codegen/templates/collectionlistsearchabletemplate
D src/codegen/templates/collectionlistsearchabletemplate.py
D src/codegen/templates/collectiontemplate
D src/codegen/templates/collectiontemplate.py
D src/codegen/templates/copyrighttemplate
D src/codegen/templates/copyrighttemplate.py
D src/codegen/templates/entrypointdyinamicmethodtemplate
D src/codegen/templates/entrypointdyinamicmethodtemplate.py
D src/codegen/templates/entrypointheadtemplate
D src/codegen/templates/entrypointheadtemplate.py
D src/codegen/templates/entrypointmethodstemplate
D src/codegen/templates/entrypointmethodstemplate.py
D src/codegen/templates/entrypointstaticmethodtemplate
D src/codegen/templates/entrypointstaticmethodtemplate.py
D src/codegen/templates/entrypointtemplate
D src/codegen/templates/entrypointtemplate.py
D src/codegen/templates/importstemplate
D src/codegen/templates/importstemplate.py
D src/codegen/templates/itemplate.py
D src/codegen/templates/resourceactiontemplate
D src/codegen/templates/resourceactiontemplate.py
D src/codegen/templates/resourcedeletetemplate
D src/codegen/templates/resourcedeletetemplate.py
D src/codegen/templates/resourcedeletewithbodyandparamstemplate
D src/codegen/templates/resourcedeletewithbodyandparamstemplate.py
D src/codegen/templates/resourcedeletewithbodytemplate
D src/codegen/templates/resourcedeletewithbodytemplate.py
D src/codegen/templates/resourcedeletewithparamstemplate
D src/codegen/templates/resourcedeletewithparamstemplate.py
D src/codegen/templates/resourcetemplate
D src/codegen/templates/resourcetemplate.py
D src/codegen/templates/resourceupdatetemplate
D src/codegen/templates/resourceupdatetemplate.py
D src/codegen/templates/subcollectionaddtemplate
D src/codegen/templates/subcollectionaddtemplate.py
D src/codegen/templates/subcollectiongettemplate
D src/codegen/templates/subcollectiongettemplate.py
D src/codegen/templates/subcollectionlisttemplate
D src/codegen/templates/subcollectionlisttemplate.py
D src/codegen/templates/subcollectionlistwithparamstemplate
D src/codegen/templates/subcollectionlistwithparamstemplate.py
D src/codegen/templates/subcollectiontemplate
D src/codegen/templates/subcollectiontemplate.py
D src/codegen/templates/subresourceactiontemplate
D src/codegen/templates/subresourceactiontemplate.py
D src/codegen/templates/subresourcecollectionactiontemplate
D src/codegen/templates/subresourcecollectionactiontemplate.py
D src/codegen/templates/subresourcedeletetemplate
D src/codegen/templates/subresourcedeletetemplate.py
D src/codegen/templates/subresourcedeletewithbodytemplate
D src/codegen/templates/subresourcedeletewithbodytemplate.py
D src/codegen/templates/subresourcedeletewithurlparamsandbodytemplate
D src/codegen/templates/subresourcedeletewithurlparamsandbodytemplate.py
D src/codegen/templates/subresourcedeletewithurlparamstemplate
D src/codegen/templates/subresourcedeletewithurlparamstemplate.py
D src/codegen/templates/subresourcetemplate
D src/codegen/templates/subresourcetemplate.py
D src/codegen/templates/subresourceupdatetemplate
D src/codegen/templates/subresourceupdatetemplate.py
D src/codegen/utils/__init__.py
D src/codegen/utils/fileutils.py
D src/codegen/utils/headerutils.py
D src/codegen/utils/paramscontainer.py
D src/codegen/utils/paramutils.py
D src/codegen/utils/stringutils.py
D src/codegen/utils/typeutil.py
D src/codegen/utils/urlutils.py
D src/codegen/xsd/README
D src/codegen/xsd/__init__.py
D src/codegen/xsd/abstractxsdcodegen.py
D src/codegen/xsd/genparams.py
D src/codegen/xsd/paramsconf.py
D src/codegen/xsd/xsdcodegen.py
113 files changed, 0 insertions(+), 5,424 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5a0ea85c62b904aa36781852189e5f7f49b1071
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: create OVF store as non shareable on gluster domain
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: create OVF store as non shareable on gluster domain
......................................................................
core: create OVF store as non shareable on gluster domain
oVirt doesn't support the creation of shareable disks on gluster
storage domains. Therefore the OVF store disks on gluster domains should
be created as non shareable.
Change-Id: I8e5d05a80061b963d61e09919824830b3624d3e6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1134366
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfVolumeForStorageDomainCommand.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e5d05a80061b963d61e09919824830b3624d3e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: RemoveStoragePool - operations order
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: RemoveStoragePool - operations order
......................................................................
core: RemoveStoragePool - operations order
It makes more sense to attempt to diconnect from the StoragePool before
disconnecting from the storage server as different operations might
be affected (for example - domain monitoring thread).
Change-Id: I67e801df32f330d7b89bab6a189a5a15fa119f68
Bug-Url: https://bugzilla.redhat.com/1059769
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67e801df32f330d7b89bab6a189a5a15fa119f68
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: tools: StorageDomainOvfStoreCount config value
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: tools: StorageDomainOvfStoreCount config value
......................................................................
tools: StorageDomainOvfStoreCount config value
adding StorageDomainOvfStoreCount to engine-config.
Change-Id: If35b26983a2d42d1b950572bdad4e0fbf657c7cd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1134242
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If35b26983a2d42d1b950572bdad4e0fbf657c7cd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months