Change in ovirt-engine[ovirt-engine-3.5]: webadmin: warning for moving disk when VM is paused
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: warning for moving disk when VM is paused
......................................................................
webadmin: warning for moving disk when VM is paused
Added warning [1] also when VM is in Paused status.
[1] "Moving disk(s) while the VM is running"
Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e
Bug-Url: https://bugzilla.redhat.com/1110803
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: reset blank template CPU profile
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: reset blank template CPU profile
......................................................................
core: reset blank template CPU profile
Although blank template resides in default cluster (probably because
of db restrictions), it shouldn't be linked to any CPU profile.
This causes any VM created in other Cluster than default, to have wrong
CPU profile (derived from template).
Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293
Bug-Url: https://bugzilla.redhat.com/1084930
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_1010_remove_blank_template_cpu_profile.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: reset CPU profile when changing VM cluster
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: reset CPU profile when changing VM cluster
......................................................................
core: reset CPU profile when changing VM cluster
Since CPU profile is coupled to cluster, when changing a cluster
the 'old' CPU profile is invalid.
The edit VM command will validate a right profile for
new cluster.
Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31
Bug-Url: https://bugzilla.redhat.com/1084930
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
(cherry picked from commit c9401694b4471e0b30db5d7eba2f9568f0818847)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32000
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core: reset CPU profile when changing VM cluster
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: reset CPU profile when changing VM cluster
......................................................................
core: reset CPU profile when changing VM cluster
Since CPU profile is coupled to cluster, when changing a cluster
the 'old' CPU profile is invalid.
The edit VM command will validate a right profile for
new cluster.
Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31
Bug-Url: https://bugzilla.redhat.com/1084930
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31999
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core: reset blank template CPU profile
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: reset blank template CPU profile
......................................................................
core: reset blank template CPU profile
Although blank template resides in default cluster (probably because
of db restrictions), it shouldn't be linked to any CPU profile.
This causes any VM created in other Cluster than default, to have wrong
CPU profile (derived from template).
Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293
Bug-Url: https://bugzilla.redhat.com/1084930
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_0320_remove_blank_template_cpu_profile.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31994
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: remove unused value from UIConstants
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: remove unused value from UIConstants
......................................................................
webadmin: remove unused value from UIConstants
Removed redundant value form UIConstants interface.
Change-Id: I88b9a5049801f5b94805bcd87315b5ff2cf8ef8a
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88b9a5049801f5b94805bcd87315b5ff2cf8ef8a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin:renaming "OpenStack Network" to "OpenStack Networking"
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin:renaming "OpenStack Network" to "OpenStack Networking"
......................................................................
webadmin:renaming "OpenStack Network" to "OpenStack Networking"
Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022
Bug-Url: https://bugzilla.redhat.com/1096170
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31975
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-release[master]: Include antlr3 and stringtemplate from JPackage on el6
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Include antlr3 and stringtemplate from JPackage on el6
......................................................................
Include antlr3 and stringtemplate from JPackage on el6
Those two packages are not present in CentOS 6, but
are required by Drools. Drools is then used in
ovirt-optimizer, which is a new component from the
SLA kitchen.
Change-Id: I2bde18752ae739de468257f3a51ec8b3326ce5f4
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M ovirt-release-3.5/ovirt-el6-deps.repo.in
M ovirt-release-master/ovirt-el6-deps.repo.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bde18752ae739de468257f3a51ec8b3326ce5f4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: frontend: Fix display of custom properties on edit VM
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: frontend: Fix display of custom properties on edit VM
......................................................................
frontend: Fix display of custom properties on edit VM
In ExistingVmModelBehavior the custom properties sheet was not
deserialized from entity to corresponding widget.
Also on backend when we were dealing with VM that has next runtime
configuration the OvfImport did copy the userDefined and predefined
properties but not the aggregate customProperties.
Change-Id: I523c61595911138b07ee74563239dd80ccb8cc99
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128433
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31773
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I523c61595911138b07ee74563239dd80ccb8cc99
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: ignore cpu profile for instance type
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ignore cpu profile for instance type
......................................................................
core: ignore cpu profile for instance type
Since both template and instance type use same commands,
CPU profile should be checked only for template.
Change-Id: I5d2b043fbcfacd59d61cb26e28078df38554dc9f
Bug-Url: https://bugzilla.redhat.com/1084930
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
(cherry picked from commit c9436ab000dbde8cbcc55d6d7582c2b651184149)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d2b043fbcfacd59d61cb26e28078df38554dc9f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months