Change in ovirt-engine[ovirt-engine-3.5]: restapi: add disk profile support
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: add disk profile support
......................................................................
restapi: add disk profile support
href="/ovirt-engine/api/diskprofiles"; "add"; method: POST; request type: DiskProfile; response type: DiskProfile
href="/ovirt-engine/api/diskprofiles"; "get"; method: GET; response type: DiskProfiles
href="/ovirt-engine/api/diskprofiles/{diskprofile:id}"; "delete"; method: DELETE
href="/ovirt-engine/api/diskprofiles/{diskprofile:id}"; "get"; method: GET; response type: DiskProfile
href="/ovirt-engine/api/diskprofiles/{diskprofile:id}"; "update"; method: PUT; request type: DiskProfile; response type: DiskProfile
href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions"; "add"; method: POST; request type: Permission; response type: Permission
href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions"; "get"; method: GET; response type: Permissions
href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions/{permission:id}"; "delete"; method: DELETE
href="/ovirt-engine/api/diskprofiles/{diskprofile:id}/permissions/{permission:id}"; "get"; method: GET; response type: Permission
href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles"; "add"; method: POST; request type: DiskProfile; response type: DiskProfile
href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles"; "get"; method: GET; response type: DiskProfiles
href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles/{diskprofile:id}"; "delete"; method: DELETE
href="/ovirt-engine/api/storagedomains/{storagedomain:id}/diskprofiles/{diskprofile:id}"; "get"; method: GET; response type: DiskProfile
Bug-Url: https://bugzilla.redhat.com/1085049
Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c58548c
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedDiskProfileResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedDiskProfilesResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskProfileResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskProfilesResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfileResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfileResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfilesResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfileResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfilesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfileResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedDiskProfilesResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfileResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfilesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskProfileMapper.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskProfileMapperTest.java
29 files changed, 1,333 insertions(+), 7 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c58548c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: add logging to SpmStopVDSCommand
by laravot@redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: add logging to SpmStopVDSCommand
......................................................................
core: add logging to SpmStopVDSCommand
currently SpmStopVdsCommand performs nothing in case of tasks return by
the current spm, this patch just adds logging to that case.
Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130766
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: TypeAheadListBox to display default text
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: TypeAheadListBox to display default text
......................................................................
webadmin: TypeAheadListBox to display default text
Adjusted the widget to display default grayed-out text when it has no
content.
Change-Id: I18d43efadde607867be440af73a9d67a14c293e0
Bug-Url: https://bugzilla.redhat.com/1086259
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
2 files changed, 18 insertions(+), 17 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18d43efadde607867be440af73a9d67a14c293e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in jenkins[master]: repoclosure: changed epel mirror
by dcaroest@redhat.com
David Caro has submitted this change and it was merged.
Change subject: repoclosure: changed epel mirror
......................................................................
repoclosure: changed epel mirror
Previously used mirror is not available anymore.
Moving to switch.ch.
Change-Id: I07040d01d9942770134a1323a0d085fd539ca6d1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/packaging/repo_closure_check.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve
David Caro: Looks good to me, approved
Ohad Basan: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07040d01d9942770134a1323a0d085fd539ca6d1
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 4 months
Change in ovirt-engine[master]: core: fixing a missing fencing audit log message
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: fixing a missing fencing audit log message
......................................................................
core: fixing a missing fencing audit log message
This patch fixes the message to the audit log where the Host is set to Connecting state.
The patches addresses
1) fix the audit log key from VDS_HOST_IN_CONNECTING_STATE which had no
message to VDS_HOST_NOT_RESPONDING_CONNECTING
2) add a flood rate to this audit log such that it will not logged in
each network exception event
3) fix a minor issue in the regular engine log ( ${1} => {1} )
Change-Id: I33b683664a33fa27df283e0abc448eb6564b678e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070674
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33b683664a33fa27df283e0abc448eb6564b678e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-log-collector[ovirt-log-collector-3.4]: ux: added disclaimer on collected data
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ux: added disclaimer on collected data
......................................................................
ux: added disclaimer on collected data
Change-Id: Ia65a0b37553026471279f67f50c4657441db673e
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 62fbb525648c1a9992f13bc5f442403bfefed676)
---
M src/__main__.py
1 file changed, 17 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia65a0b37553026471279f67f50c4657441db673e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-log-collector[ovirt-log-collector-3.4]: archive: allow access only to the user
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: archive: allow access only to the user
......................................................................
archive: allow access only to the user
Change mode permission bits to 600
Change-Id: I90a69f1ea9d09915d04bd84339d64ec6d9e6c05a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 77d69d24c46207a16ecb5fc732cc1c84de0ca947)
---
M src/__main__.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90a69f1ea9d09915d04bd84339d64ec6d9e6c05a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core: wrong name is shown in event log when cloning a VM
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: wrong name is shown in event log when cloning a VM
......................................................................
core: wrong name is shown in event log when cloning a VM
The problem was that the VM name in CloneVmCommand was set to the source VM
while it was supposed to be set to the VM beeing created.
Change-Id: Ic1e09991269b3efc9b2f8f3befa95eb00efe19c7
Bug-Url: https://bugzilla.redhat.com/1128239
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31903
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1e09991269b3efc9b2f8f3befa95eb00efe19c7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: removal of comments with developer names/usernames
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: removal of comments with developer names/usernames
......................................................................
core: removal of comments with developer names/usernames
Change-Id: Icd7cf60b05972bbe98a68fe1c7216812d8790927
Topic: cleanup
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EjbUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Aggregator.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/All.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Function.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Mapper.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Predicate.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/RollbackHandler.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionMethod.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java
13 files changed, 3 insertions(+), 43 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd7cf60b05972bbe98a68fe1c7216812d8790927
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: LUN disk creation - storage is not applicable
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: LUN disk creation - storage is not applicable
......................................................................
restapi: LUN disk creation - storage is not applicable
Storage domain is not applicable for DirectLUN disks,
hence, removed from 'optionalArguments' on rsdl.
Change-Id: Ie1a28b47096016b4a5293c349399c98862978d4a
Bug-Url: https://bugzilla.redhat.com/1083096
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/31923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1a28b47096016b4a5293c349399c98862978d4a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months