August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: relax disk profile validation
by gchaplik＠redhat.com 26 Aug '14

26 Aug '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: relax disk profile validation ...................................................................... webadmin: relax disk profile validation Allow not passing the engine profile (to support lower compatibility versions) Change-Id: Ib4c9489659900f6855492c936bf71a6e2cb3c89a Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4c9489659900f6855492c936bf71a6e2cb3c89a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: master: drop Fedora 19 support
by sbonazzo＠redhat.com 26 Aug '14

26 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: master: drop Fedora 19 support ...................................................................... master: drop Fedora 19 support Fedora 19 is not supported for oVirt >= 3.6.0. Change-Id: I896aa838e591db16930196c5b3ac100a1421faec Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-master/Makefile.am M ovirt-release-master/configure.ac D ovirt-release-master/ovirt-f19-deps.repo.in M ovirt-release-master/ovirt-release-master.spec.in 4 files changed, 0 insertions(+), 19 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I896aa838e591db16930196c5b3ac100a1421faec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Change disk alias suggestions to use alias recycling
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Change disk alias suggestions to use alias recycling ...................................................................... webadmin: Change disk alias suggestions to use alias recycling In change 24061, disk alias suggestions was changed not to suggest a disk alias that is already attached to the VM, this change now also makes sure that the aliases will be recycled (i.e. if we had alias1 and alias2 and we deleted alias1, the next suggestion will be alias1) Change-Id: I8d5b8ba00a144b864208d971def7087182538be2 Bug-Url: https://bugzilla.redhat.com/1022795 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java 2 files changed, 13 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5b8ba00a144b864208d971def7087182538be2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: wrong name is shown in event log when cloning a VM
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong name is shown in event log when cloning a VM ...................................................................... core: wrong name is shown in event log when cloning a VM The problem was that the VM name in CloneVmCommand was set to the source VM while it was supposed to be set to the VM beeing created. Change-Id: Ic1e09991269b3efc9b2f8f3befa95eb00efe19c7 Bug-Url: https://bugzilla.redhat.com/1128239 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1e09991269b3efc9b2f8f3befa95eb00efe19c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Removing groups from users main tab
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Removing groups from users main tab ...................................................................... aaa: Removing groups from users main tab The groups are removed from the users main tab due to the following reasons: 1. They are presented at the users sub tab. 2. We are going to present only managed groups later on in the patchset, as a result we would like to remove groups column entirely from the users table and have the group names being calculated based on the ad_groups table and the group ids that are kept at the users table. If we calculate this for every user in the main users tab we will suffer from a performeance hit. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I53119c28426e678043544105ca69d85ec9c748c1 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 1 file changed, 1 insertion(+), 17 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53119c28426e678043544105ca69d85ec9c748c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: adding cpu profile to VM and template
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: adding cpu profile to VM and template ...................................................................... restapi: adding cpu profile to VM and template Allowing setting optional value cpu_profile.id into VM and Template elements. Change-Id: Ifef1442476ecde490414ae625ced333d1e9e6259 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 37 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifef1442476ecde490414ae625ced333d1e9e6259 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: add cpu profile support
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: add cpu profile support ...................................................................... restapi: add cpu profile support href="/ovirt-engine/api/cpuprofiles"; "add"; method: POST; request type: CpuProfile; response type: CpuProfile href="/ovirt-engine/api/cpuprofiles"; "get"; method: GET; response type: CpuProfiles href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}"; "delete"; method: DELETE href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}"; "get"; method: GET; response type: CpuProfile href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}"; "update"; method: PUT; request type: CpuProfile; response type: CpuProfile href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions"; "add"; method: POST; request type: Permission; response type: Permission href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions"; "get"; method: GET; response type: Permissions href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions/{permission:id}"; "delete"; method: DELETE href="/ovirt-engine/api/cpuprofiles/{cpuprofile:id}/permissions/{permission:id}"; "get"; method: GET; response type: Permission href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles"; "add"; method: POST; request type: CpuProfile; response type: CpuProfile href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles"; "get"; method: GET; response type: CpuProfiles href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles/{cpuprofile:id}"; "delete"; method: DELETE href="/ovirt-engine/api/clusters/{cluster:id}/cpuprofiles/{cpuprofile:id}"; "get"; method: GET; response type: CpuProfile Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c51238c Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedCpuProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedCpuProfilesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ClusterResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CpuProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CpuProfilesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedCpuProfilesResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfilesResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CpuProfileMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/CpuProfileMapperTest.java 27 files changed, 1,326 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65976b00665a7f6d87b3fa6f62e54c753c51238c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: support cpu qos limit
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: support cpu qos limit ...................................................................... restapi: support cpu qos limit Add it to current qos infra. Change-Id: I176f7d3e5776c515f09db94177eeb679e71412af Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QosType.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/CpuQosMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/QosMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageQosMapperTest.java 10 files changed, 92 insertions(+), 20 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I176f7d3e5776c515f09db94177eeb679e71412af Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: add disk profile to disk
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: add disk profile to disk ...................................................................... restapi: add disk profile to disk Change-Id: Ie16441ce28390c42a0f97ab7014aa3669964ae57 Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie16441ce28390c42a0f97ab7014aa3669964ae57 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ForceSelectSPM might fail
by laravot＠redhat.com 26 Aug '14

26 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: ForceSelectSPM might fail ...................................................................... core: ForceSelectSPM might fail ForceSelectSPM is performing nothing in case that the current SPM can't be stopped but its execution is always marked as succesful. In case of failure an appropiate audit log should be displayed. Change-Id: Ia1a32ec7b68c3643e28751d61ba070b4e4cc09ea Bug-Url: https://bugzilla.redhat.com/1119852 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ForceSelectSPMCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 10 insertions(+), 12 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1a32ec7b68c3643e28751d61ba070b4e4cc09ea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0