August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: WAD should be Ignored on File Domain Disks
by amureini＠redhat.com 21 Aug '14

21 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: WAD should be Ignored on File Domain Disks ...................................................................... core: WAD should be Ignored on File Domain Disks Since the file system is responsible for handling block allocation, there is no need for wiping disks on file domains. Change-Id: I0df2c07282994557e149db922cc1d3a166c5aa8f Bug-Url: https://bugzilla.redhat.com/1097820 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/PostZeroHandler.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/PostZeroHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CopyImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DeleteImageGroupVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeSnapshotsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/PostZero.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java 23 files changed, 273 insertions(+), 114 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0df2c07282994557e149db922cc1d3a166c5aa8f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Renamed AddDiskToVmCommandTest
by amureini＠redhat.com 21 Aug '14

21 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Renamed AddDiskToVmCommandTest ...................................................................... core: Renamed AddDiskToVmCommandTest AddDiskToVmCommandTest tests the command AddDiskCommand and thus should be called AddDiskCommandTest. Change-Id: I761c21ffa34138b19fc6e114888a5cd641b8ed1f Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/31143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I761c21ffa34138b19fc6e114888a5cd641b8ed1f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[mom-0.4.1]: Fixing vcpuCount periodic error.
by alitke＠redhat.com 21 Aug '14

21 Aug '14

Adam Litke has submitted this change and it was merged. Change subject: Fixing vcpuCount periodic error. ...................................................................... Fixing vcpuCount periodic error. When vcpu count is not available via the cpu tune, mom will display an error message every 10 sec. Change-Id: Ie913a68b95f0384dbd573275cd9e70cb6c740ee6 Bug-Url: https://bugzilla.redhat.com/1119775 Signed-off-by: Kobi Ianko <kianku(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/30181 Reviewed-by: Jiří Moskovčák <jmoskovc(a)redhat.com> Reviewed-by: Martin Sivák <msivak(a)redhat.com> Tested-by: Kobi Ianko <kobi(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> (cherry picked from commit fcedb2ddf2cf0ae41fb71f3898b19a72a957b05f) Reviewed-on: http://gerrit.ovirt.org/30486 Tested-by: Martin Sivák <msivak(a)redhat.com> --- M mom/HypervisorInterfaces/vdsmInterface.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified Jiří Moskovčák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie913a68b95f0384dbd573275cd9e70cb6c740ee6 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: mom-0.4.1 Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: 'Start-on-boot' of a nic should be respected
by masayag＠redhat.com 21 Aug '14

21 Aug '14

Moti Asayag has submitted this change and it was merged. Change subject: core: 'Start-on-boot' of a nic should be respected ...................................................................... core: 'Start-on-boot' of a nic should be respected The user should be able to instruct which network interface will be booted on startup when the interface is configured by cloud-init. Change-Id: I325c5edaa27be322bd5488d4397f696338e434fe Bug-Url: https://bugzilla.redhat.com/1132439 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/31765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I325c5edaa27be322bd5488d4397f696338e434fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add managed virtio-serial devices on upgrade
by ofrenkel＠redhat.com 21 Aug '14

21 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add managed virtio-serial devices on upgrade ...................................................................... core: add managed virtio-serial devices on upgrade The upgrade scripts do the following things: - Change every existing virtio-serial device to be managed - Then is adds managed virtio-serial device to VMs that don't have it In addition, we might get reports of unmanaged virtio-serial devices from VMs that were running at the time of the upgrade, so in that case we'll not add new device, but use the managed device instead. Change-Id: I5b99dd3fa0d43307788a685c0115b32691757454 Bug-Url: https://bugzilla.redhat.com/1028387 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java A packaging/dbscripts/upgrade/03_06_0310_change_virtio_serial_to_managed_device.sql 2 files changed, 36 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b99dd3fa0d43307788a685c0115b32691757454 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Allow selection of None for Cloud-Init network boo...
by masayag＠redhat.com 21 Aug '14

21 Aug '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Allow selection of None for Cloud-Init network boot protocol ...................................................................... webadmin: Allow selection of None for Cloud-Init network boot protocol The REST API supported DHCP, Static IP, and None as NIC address types for cloud-init VM startup. Make the same available in the UI as well. Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083 Bug-Url: https://bugzilla.redhat.com/1120092 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 4 files changed, 44 insertions(+), 27 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/31051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Making separate WSP CSR available also in ...
by tnisan＠redhat.com 21 Aug '14

21 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Making separate WSP CSR available also in temp file ...................................................................... packaging: setup: Making separate WSP CSR available also in temp file Making CSR for a WebsocketProxy on a sperate host available also in a temp file. Fixing name and file permission of default cert. Change-Id: If517c577ead43e604442c7d468f034c2c8eaf276 Bug-Url: https://bugzilla.redhat.com/1115993 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 839a391dd70120027327288a640cc83d7647f4fc) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 4 files changed, 32 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/31752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If517c577ead43e604442c7d468f034c2c8eaf276 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Add REST API support for iSCSI multipathing
by tnisan＠redhat.com 21 Aug '14

21 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add REST API support for iSCSI multipathing ...................................................................... restapi: Add REST API support for iSCSI multipathing Enable getting, creating, updating and removing iSCSI Bonds through REST API including adding/removing a storage target (Engine term is storage connection is a little bit misleading) and adding/removing a logical network. In case of storage target and network the "add" acts more like "attach" because its adding an already existing target or/and network to the iscsi bond. Usages: Creating a new iSCSI Bond: POST /api/datacenters/{datacenter_id}/iscsibonds HTTP/1.1 Accept: application/xml Content-type: application/xml <iscsi_bond> <name>fromRest</name> <storage_connections> <storage_connection id={storageconnection_id} /> .... </storage_connections> <networks> <network id={network_id} /> .... </networks> </iscsi_bond> Updating an iSCSI Bond, only name and description can be editing that way: PUT /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id} HTTP/1.1 Accept: application/xml Content-type: application/xml <iscsi_bond> <name>{name}</name> <description>{description}</description> </iscsi_bond> Removing an iSCSI Bond: DELETE /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id} HTTP/1.1 Getting all iSCSI Bonds for the specified datacenter: GET /api/datacenters/{datacenter_id}/iscsibonds HTTP/1.1 Accept: application/xml Content-type: application/xml Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490 Bug-Url: https://bugzilla.redhat.com/1075686 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetIscsiBondByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworksByIscsiBondIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageServerConnectionByIscsiBondIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddIscsiBondCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddIscsiBondParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DataCenterResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IscsiBondResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IscsiBondsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworkResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworksResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageServerConnection.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworkResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworksResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/IscsiBondMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/IscsiBondMapperTest.java 27 files changed, 1,137 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/31750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clean osinfo unused property
by ofrenkel＠redhat.com 21 Aug '14

21 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: clean osinfo unused property ...................................................................... core: clean osinfo unused property Change-Id: I1ceb1f5e5b7b813fbd7af85c6425debe0be72f3c Bug-Url: https://bugzilla.redhat.com/1089239 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ceb1f5e5b7b813fbd7af85c6425debe0be72f3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: NPE when mapping watchdog without id
by tnisan＠redhat.com 21 Aug '14

21 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: NPE when mapping watchdog without id ...................................................................... restapi: NPE when mapping watchdog without id Currently the operation to add a watchdog to a VM fails if the id isn't provided, as this triggers a NPE. This adds a check to prevent that NPE. Change-Id: Ib526525b37e74e2e4d863e4418dfb852a7ca4200 Bug-Url: https://bugzilla.redhat.com/1129781 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit c8dda3faf38f91854ce79d832fb0506b8da37b88) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogMapper.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib526525b37e74e2e4d863e4418dfb852a7ca4200 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0