Change in ovirt-engine[master]: core: fix possible NPE on run/migrate commands
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix possible NPE on run/migrate commands
......................................................................
core: fix possible NPE on run/migrate commands
In some cases we might reach the runningFailed method when no host was
selected by the scheduler, so we could get NPE when trying to decrease
the pending memory. So null-check is added.
Change-Id: I664b2aaabc855ed3b28a9b8fdee64d32c4191e65
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I664b2aaabc855ed3b28a9b8fdee64d32c4191e65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: add 'Comment' field to OVF
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add 'Comment' field to OVF
......................................................................
core: add 'Comment' field to OVF
'Comment' is missing from the OVF, therfore, missing from snapshots,
import-export and also not working when editing running vm.
this patch add the fields to the OVF and solving all above.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128446
Change-Id: I79fdcfd10d2bd510b57314f330f349b38e6f5ee2
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
3 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/31666
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79fdcfd10d2bd510b57314f330f349b38e6f5ee2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine-cli[cli_3.5]: cli: Use UTF-8 for writing output files
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Use UTF-8 for writing output files
......................................................................
cli: Use UTF-8 for writing output files
Currently when the CLI opens an output file due to a redirection it
opens it using the ASCII character encoding. If the text written to the
file contains characters outside of the ASCII set an exception is
generated. This patch changes the CLI so that it uses UTF-8 when writing
these files.
Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b
Bug-Url: https://bugzilla.redhat.com/1126763
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 80ed3042919b6cf4442cb5a8bae9117a934b56b8)
---
M src/cli/context.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core, db: disk profile: handle attach/detach
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core, db: disk profile: handle attach/detach
......................................................................
core, db: disk profile: handle attach/detach
Attach: create disk profile for new storage domain
in pool (attach/create)
Detach: remove qos id from disk profiles of detached
storage domain
Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java
M packaging/dbscripts/disk_profiles_sp.sql
7 files changed, 77 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine-cli[master]: cli: Use UTF-8 for writing output files
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Use UTF-8 for writing output files
......................................................................
cli: Use UTF-8 for writing output files
Currently when the CLI opens an output file due to a redirection it
opens it using the ASCII character encoding. If the text written to the
file contains characters outside of the ASCII set an exception is
generated. This patch changes the CLI so that it uses UTF-8 when writing
these files.
Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b
Bug-Url: https://bugzilla.redhat.com/1126763
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/context.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: userportal, webadmin: Fix layout issues in vNIC dialog
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: userportal,webadmin: Fix layout issues in vNIC dialog
......................................................................
userportal,webadmin: Fix layout issues in vNIC dialog
There were all sorts of layout issues in the dialog in different
locales. This fixes all of them; more space is allocated to the radio
button labels which fixes breakage, and it's put at the end of the
dialog (so all aligned text boxes will appear first).
Change-Id: I31877f7f2370bd92161d2792533e410f16bf0254
Bug-Url: https://bugzilla.redhat.com/1032519
Bug-Url: https://bugzilla.redhat.com/1079877
Bug-Url: https://bugzilla.redhat.com/1115018
Bug-Url: https://bugzilla.redhat.com/1120976
Bug-Url: https://bugzilla.redhat.com/1123747
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
2 files changed, 24 insertions(+), 41 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31877f7f2370bd92161d2792533e410f16bf0254
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Slightly amend checkbox header logic
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Slightly amend checkbox header logic
......................................................................
webadmin: Slightly amend checkbox header logic
Previously the logic only relied on enabled entries to determine
whether the checkbox header should be checked or not, however this
produced inconsistent results when all entries are disabled. Special
attention is now paid to that case.
Also, the logic for determining whether an entry is enabled seemed to
be out-of-date and wasn't functioning properly.
Change-Id: I2e7786d55c0f639c0e2f4af4685d125462724175
Bug-Url: https://bugzilla.redhat.com/1100292
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7786d55c0f639c0e2f4af4685d125462724175
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Don't store Neutron physical network on import
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Don't store Neutron physical network on import
......................................................................
core: Don't store Neutron physical network on import
This allowed Neutron physical network entries to sneak into our
DB. Except for eliminating that possibility, such existing entries are
cleared from the DB.
Change-Id: Icb8751f06690ffb34cc72f1f2e5e14e66b4d40f1
Bug-Url: https://bugzilla.redhat.com/1127687
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
A packaging/dbscripts/upgrade/03_06_0260_remove_external_network_labels.sql
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb8751f06690ffb34cc72f1f2e5e14e66b4d40f1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core, db: disk profile for disk image
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core, db: disk profile for disk image
......................................................................
core, db: disk profile for disk image
* Add disk profile to all disk image flows.
* Handle image_storage_domain_map db flows.
Change-Id: I9488a1e31e85013a01ee088fdf71854f765059c9
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LiveMigrateDiskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/image_storage_domain_map.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/image_storage_domain_map_sp.sql
A packaging/dbscripts/upgrade/03_06_0250_disk_profile_for_disk_image.sql
34 files changed, 270 insertions(+), 32 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9488a1e31e85013a01ee088fdf71854f765059c9
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Add memory allocation check to hibernate VM
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Add memory allocation check to hibernate VM
......................................................................
core: Add memory allocation check to hibernate VM
When hibernating a VM, two volumes are created, one to save memory,
and one for the metadata. When searching for a Storage Domain with
enough space for these volumes, wrong space allocations checks are done.
Added the correct storage allocation checks, replacing existing checks
in HibernateVmCommand.
Added test class to the command - HibernateVmCommandTest, as well as a
test to VmHandlerTest.
Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a
Bug-Url: https://bugzilla.redhat.com/1124143
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
4 files changed, 136 insertions(+), 7 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months